FileHelper::__construct() - Code Metrics - Inspection of "[MediaBundle] Use parameter instead of hardcoded m..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2782)

unknown

created 2020-10-13 08:14 UTC

FileHelper::__construct() A

↳ Parent: FileHelper

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2.0932

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	5
cts	7
cp	0.7143
rs	9.9
c	0
b	0
f	0
cc	2
nc	2
nop	2
crap	2.0932

<?php

namespace Kunstmaan\MediaBundle\Helper\File;

use Kunstmaan\MediaBundle\Entity\Folder;
use Kunstmaan\MediaBundle\Entity\Media;
use Symfony\Component\HttpFoundation\File\Exception\AccessDeniedException;
use Symfony\Component\HttpFoundation\File\File;
use Symfony\Component\HttpFoundation\File\UploadedFile;

/**
 * FileHelper
 */
class FileHelper
{
    /**
     * @var Media
     */
    protected $media;

    /**
     * @var File
     */
    protected $file;

    /**
     * @var string
     */
    protected $path;

    protected $mediaPath;

    /**
     * @param Media  $media
     * @param string $mediaPath

     */
    public function __construct(Media $media, string $mediaPath = null)
    {
        $this->media = $media;

        if ($mediaPath === null) {
            @trigger_error(sprintf('Not passing the media path as the second argument of "%s" is deprecated since KunstmaanMediaBundle 5.7 and will be required in KunstmaanMediaBundle 6.0. Injected the required parameter in the constructor instead.', __METHOD__), E_USER_DEPRECATED);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            $mediaPath = '/uploads/media/';
        }

        $this->mediaPath = $mediaPath;
    }

    /**
     * @return string
     */
    public function getName()
    {
        return $this->media->getName();
    }

    /**
     * @param string $name
     */
    public function setName($name)
    {
        $this->media->setName($name);
    }

    /**
     * @return Folder
     */
    public function getFolder()
    {
        return $this->media->getFolder();
    }

    /**
     * @param Folder $folder
     */
    public function setFolder(Folder $folder)
    {
        $this->media->setFolder($folder);
    }

    /**
     * @return string
     */
    public function getCopyright()
    {
        return $this->media->getCopyright();
    }

    /**
     * @param string $copyright
     */
    public function setCopyright($copyright)
    {
        $this->media->setCopyright($copyright);
    }

    /**
     * @return string
     */
    public function getDescription()
    {
        return $this->media->getDescription();
    }

    /**
     * @param string $description
     */
    public function setDescription($description)
    {
        $this->media->setDescription($description);
    }

    public function getOriginalFilename()
    {
        return $this->media->getOriginalFilename();
    }

    /**
     * @param string $name
     */
    public function setOriginalFilename($name)
    {
        $this->media->setOriginalFilename($name);
    }

    /**
     * @return UploadedFile
     */
    public function getFile()
    {
        return $this->file;
    }

    /**
     * @param File $file
     */
    public function setFile(File $file)
    {
        $this->file = $file;
        if (\strlen($file->getPathname()) > 0) {
            $this->media->setContent($file);
            $this->media->setContentType($file->getMimeType());
            $this->media->setUrl(
                $this->mediaPath . $this->media->getUuid() . '.' . $this->media->getContent()->getExtension()
            );
        }
    }

    /**
     * @param string $mediaUrl
     *
     * @throws \Symfony\Component\HttpFoundation\File\Exception\AccessDeniedException
     */
    public function getMediaFromUrl($mediaUrl)
    {
        $path = tempnam(sys_get_temp_dir(), 'kuma_');
        $saveFile = fopen($path, 'w');
        $this->path = $path;

        $ch = curl_init($mediaUrl);
        curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);
        curl_setopt($ch, CURLOPT_FILE, $saveFile);
        curl_exec($ch);
        $effectiveUrl = curl_getinfo($ch, CURLINFO_EFFECTIVE_URL);
        curl_close($ch);

        fclose($saveFile);
        chmod($path, 0777);

        $url = parse_url($effectiveUrl);
        $info = pathinfo($url['path']);
        $filename = $info['filename'] . '.' . $info['extension'];

        $upload = new UploadedFile($path, $filename);
        $this->getMedia()->setContent($upload);

        if ($this->getMedia() === null) {
            unlink($path);

            throw new AccessDeniedException('Can not link file');
        }
    }

    /**
     * @return Media
     */
    public function getMedia()
    {
        return $this->media;
    }

    /**
     * __destruct
     */
    public function __destruct()
    {
        if ($this->path !== null) {
            unlink($this->path);
        }
    }
}


1		<?php
2
3		namespace Kunstmaan\MediaBundle\Helper\File;
4
5		use Kunstmaan\MediaBundle\Entity\Folder;
6		use Kunstmaan\MediaBundle\Entity\Media;
7		use Symfony\Component\HttpFoundation\File\Exception\AccessDeniedException;
8		use Symfony\Component\HttpFoundation\File\File;
9		use Symfony\Component\HttpFoundation\File\UploadedFile;
10
11		/**
12		* FileHelper
13		*/
14		class FileHelper
15		{
16		/**
17		* @var Media
18		*/
19		protected $media;
20
21		/**
22		* @var File
23		*/
24		protected $file;
25
26		/**
27		* @var string
28		*/
29		protected $path;
30
31		protected $mediaPath;
32
33		/**
34		* @param Media $media
35		* @param string $mediaPath
		0 ignored issues – show Documentation introduced 2020-10-13 08:30 UTC by Report Bug Copy Issue Report Should the type for parameter `$mediaPath` not be `null\|string`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
36		*/
37	7	public function __construct(Media $media, string $mediaPath = null)
38		{
39	7	$this->media = $media;
40
41	7	if ($mediaPath === null) {
42		@trigger_error(sprintf('Not passing the media path as the second argument of "%s" is deprecated since KunstmaanMediaBundle 5.7 and will be required in KunstmaanMediaBundle 6.0. Injected the required parameter in the constructor instead.', __METHOD__), E_USER_DEPRECATED);
		0 ignored issues – show Security Best Practice introduced 2020-10-08 08:40 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
43		$mediaPath = '/uploads/media/';
44		}
45
46	7	$this->mediaPath = $mediaPath;
47	7	}
48
49		/**
50		* @return string
51		*/
52	1	public function getName()
53		{
54	1	return $this->media->getName();
55		}
56
57		/**
58		* @param string $name
59		*/
60	1	public function setName($name)
61		{
62	1	$this->media->setName($name);
63	1	}
64
65		/**
66		* @return Folder
67		*/
68	1	public function getFolder()
69		{
70	1	return $this->media->getFolder();
71		}
72
73		/**
74		* @param Folder $folder
75		*/
76	1	public function setFolder(Folder $folder)
77		{
78	1	$this->media->setFolder($folder);
79	1	}
80
81		/**
82		* @return string
83		*/
84	1	public function getCopyright()
85		{
86	1	return $this->media->getCopyright();
87		}
88
89		/**
90		* @param string $copyright
91		*/
92	1	public function setCopyright($copyright)
93		{
94	1	$this->media->setCopyright($copyright);
95	1	}
96
97		/**
98		* @return string
99		*/
100	1	public function getDescription()
101		{
102	1	return $this->media->getDescription();
103		}
104
105		/**
106		* @param string $description
107		*/
108	1	public function setDescription($description)
109		{
110	1	$this->media->setDescription($description);
111	1	}
112
113	1	public function getOriginalFilename()
114		{
115	1	return $this->media->getOriginalFilename();
116		}
117
118		/**
119		* @param string $name
120		*/
121	1	public function setOriginalFilename($name)
122		{
123	1	$this->media->setOriginalFilename($name);
124	1	}
125
126		/**
127		* @return UploadedFile
128		*/
129	1	public function getFile()
130		{
131	1	return $this->file;
132		}
133
134		/**
135		* @param File $file
136		*/
137	1	public function setFile(File $file)
138		{
139	1	$this->file = $file;
140	1	if (\strlen($file->getPathname()) > 0) {
141	1	$this->media->setContent($file);
142	1	$this->media->setContentType($file->getMimeType());
143	1	$this->media->setUrl(
144	1	$this->mediaPath . $this->media->getUuid() . '.' . $this->media->getContent()->getExtension()
145		);
146		}
147	1	}
148
149		/**
150		* @param string $mediaUrl
151		*
152		* @throws \Symfony\Component\HttpFoundation\File\Exception\AccessDeniedException
153		*/
154		public function getMediaFromUrl($mediaUrl)
155		{
156		$path = tempnam(sys_get_temp_dir(), 'kuma_');
157		$saveFile = fopen($path, 'w');
158		$this->path = $path;
159
160		$ch = curl_init($mediaUrl);
161		curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);
162		curl_setopt($ch, CURLOPT_FILE, $saveFile);
163		curl_exec($ch);
164		$effectiveUrl = curl_getinfo($ch, CURLINFO_EFFECTIVE_URL);
165		curl_close($ch);
166
167		fclose($saveFile);
168		chmod($path, 0777);
169
170		$url = parse_url($effectiveUrl);
171		$info = pathinfo($url['path']);
172		$filename = $info['filename'] . '.' . $info['extension'];
173
174		$upload = new UploadedFile($path, $filename);
175		$this->getMedia()->setContent($upload);
176
177		if ($this->getMedia() === null) {
178		unlink($path);
179
180		throw new AccessDeniedException('Can not link file');
181		}
182		}
183
184		/**
185		* @return Media
186		*/
187	1	public function getMedia()
188		{
189	1	return $this->media;
190		}
191
192		/**
193		* __destruct
194		*/
195		public function __destruct()
196		{
197		if ($this->path !== null) {
198		unlink($this->path);
199		}
200		}
201		}
202

Kunstmaan / KunstmaanBundlesCMS

Pull Request — master (#2782)

FileHelper::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like