Completed
Pull Request — master (#2657)
by Jeroen
06:22
created
src/Kunstmaan/AdminListBundle/Controller/AdminListController.php 1 patch
Doc Comments   +8 added lines, -5 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
     /**
34 34
      * You can override this method to return the correct entity manager when using multiple databases ...
35 35
      *
36
-     * @return \Doctrine\Common\Persistence\ObjectManager|object
36
+     * @return \Doctrine\Persistence\ObjectManager
37 37
      */
38 38
     protected function getEntityManager()
39 39
     {
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
      * Shows the list of entities
45 45
      *
46 46
      * @param AbstractAdminListConfigurator $configurator
47
-     * @param null|Request                  $request
47
+     * @param Request                  $request
48 48
      *
49 49
      * @return Response
50 50
      */
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
      *
94 94
      * @param AbstractAdminListConfigurator $configurator The adminlist configurator
95 95
      * @param string                        $type         The type to add
96
-     * @param null|Request                  $request
96
+     * @param Request                  $request
97 97
      *
98 98
      * @throws AccessDeniedHttpException
99 99
      *
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
      *
189 189
      * @param AbstractAdminListConfigurator $configurator The adminlist configurator
190 190
      * @param string                        $entityId     The id of the entity that will be edited
191
-     * @param null|Request                  $request
191
+     * @param Request                  $request
192 192
      *
193 193
      * @throws NotFoundHttpException
194 194
      * @throws AccessDeniedHttpException
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
      *
343 343
      * @param AbstractAdminListConfigurator $configurator The adminlist configurator
344 344
      * @param int                           $entityId     The id to delete
345
-     * @param null|Request                  $request
345
+     * @param Request                  $request
346 346
      *
347 347
      * @throws NotFoundHttpException
348 348
      * @throws AccessDeniedHttpException
@@ -469,6 +469,9 @@  discard block
 block discarded – undo
469 469
         );
470 470
     }
471 471
 
472
+    /**
473
+     * @param \Doctrine\Persistence\ObjectRepository $repo
474
+     */
472 475
     private function getMaxSortableField($repo, $sort)
473 476
     {
474 477
         $maxWeight = $repo->createQueryBuilder('i')
Please login to merge, or discard this patch.
src/Kunstmaan/AdminListBundle/Controller/EntityLockCheckController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
     /**
18 18
      * You can override this method to return the correct entity manager when using multiple databases ...
19 19
      *
20
-     * @return \Doctrine\Common\Persistence\ObjectManager|object
20
+     * @return \Doctrine\Persistence\ObjectManager
21 21
      */
22 22
     protected function getEntityManager()
23 23
     {
Please login to merge, or discard this patch.
src/Kunstmaan/MediaBundle/Helper/Imagine/WebPathResolver.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -29,6 +29,8 @@  discard block
 block discarded – undo
29 29
 
30 30
     /**
31 31
      * {@inheritdoc}
32
+     * @param string $path
33
+     * @param string $filter
32 34
      */
33 35
     protected function getFileUrl($path, $filter)
34 36
     {
@@ -75,6 +77,7 @@  discard block
 block discarded – undo
75 77
 
76 78
     /**
77 79
      * Copy from \Liip\ImagineBundle\Imagine\Cache\Resolver\WebPathResolver::getFullPath
80
+     * @param string $path
78 81
      */
79 82
     private function getFullPath($path, $filter)
80 83
     {
Please login to merge, or discard this patch.
src/Kunstmaan/ArticleBundle/Entity/AbstractArticleOverviewPage.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
     }
23 23
 
24 24
     /**
25
-     * @return AbstractPagePartAdminConfigurator[]
25
+     * @return AbstractArticleOverviewPagePagePartAdminConfigurator[]
26 26
      */
27 27
     public function getPagePartAdminConfigurations()
28 28
     {
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
     /**
33 33
      * Return the Article repository
34 34
      *
35
-     * @param $em
35
+     * @param \Doctrine\ORM\EntityManagerInterface $em
36 36
      *
37 37
      * @return mixed
38 38
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Kunstmaan\ArticleBundle\Entity;
4 4
 
5 5
 use Kunstmaan\ArticleBundle\PagePartAdmin\AbstractArticleOverviewPagePagePartAdminConfigurator;
6
-use Kunstmaan\NodeBundle\Controller\SlugActionInterface;
7 6
 use Kunstmaan\NodeBundle\Entity\AbstractPage;
8 7
 use Kunstmaan\PagePartBundle\Helper\HasPagePartsInterface;
9 8
 use Kunstmaan\PagePartBundle\PagePartAdmin\AbstractPagePartAdminConfigurator;
Please login to merge, or discard this patch.