Completed
Pull Request — master (#2657)
by Jeroen
06:22
created
src/Kunstmaan/LeadGenerationBundle/Controller/PopupsAdminListController.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
      *
57 57
      * @Route("/{id}/delete", requirements={"id" = "\d+"}, name="kunstmaanleadgenerationbundle_admin_popup_abstractpopup_delete", methods={"GET", "POST"})
58 58
      *
59
-     * @return array
59
+     * @return \Symfony\Component\HttpFoundation\Response
60 60
      */
61 61
     public function deleteAction(Request $request, $id)
62 62
     {
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
      *
71 71
      * @Route("/{id}/edit", requirements={"id" = "\d+"}, name="kunstmaanleadgenerationbundle_admin_popup_abstractpopup_edit", methods={"GET", "POST"})
72 72
      *
73
-     * @return array
73
+     * @return \Symfony\Component\HttpFoundation\Response
74 74
      */
75 75
     public function editAction(Request $request, $id)
76 76
     {
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
      *
83 83
      * @Route("/add",  name="kunstmaanleadgenerationbundle_admin_popup_abstractpopup_add", methods={"GET", "POST"})
84 84
      *
85
-     * @return array
85
+     * @return \Symfony\Component\HttpFoundation\Response
86 86
      */
87 87
     public function addAction(Request $request)
88 88
     {
Please login to merge, or discard this patch.
src/Kunstmaan/LeadGenerationBundle/Controller/RulesAdminListController.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
      *
43 43
      * @Route("/{popup}/add", requirements={"popup" = "\d+"}, name="kunstmaanleadgenerationbundle_admin_rule_abstractrule_add", methods={"GET", "POST"})
44 44
      *
45
-     * @return array
45
+     * @return \Symfony\Component\HttpFoundation\Response
46 46
      */
47 47
     public function addAction(Request $request, $popup)
48 48
     {
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
      *
59 59
      * @Route("/{popup}/rules/{id}/edit", requirements={"popup" = "\d+", "rule" = "\d+"}, name="kunstmaanleadgenerationbundle_admin_rule_abstractrule_edit", methods={"GET", "POST"})
60 60
      *
61
-     * @return array
61
+     * @return \Symfony\Component\HttpFoundation\Response
62 62
      */
63 63
     public function editAction(Request $request, $id, $popup)
64 64
     {
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
      *
73 73
      * @Route("/{popup}/rules/{id}/delete", requirements={"popup" = "\d+"}, name="kunstmaanleadgenerationbundle_admin_rule_abstractrule_delete", methods={"GET", "POST"})
74 74
      *
75
-     * @return array
75
+     * @return \Symfony\Component\HttpFoundation\Response
76 76
      */
77 77
     public function deleteAction(Request $request, $id, $popup)
78 78
     {
Please login to merge, or discard this patch.
src/Kunstmaan/MediaBundle/Controller/MediaController.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -274,6 +274,10 @@  discard block
 block discarded – undo
274 274
         return $response;
275 275
     }
276 276
 
277
+    /**
278
+     * @param string $code
279
+     * @param string $message
280
+     */
277 281
     private function returnJsonError($code, $message)
278 282
     {
279 283
         return new JsonResponse(
@@ -452,7 +456,7 @@  discard block
 block discarded – undo
452 456
      *
453 457
      * @Route("move/", name="KunstmaanMediaBundle_media_move", methods={"POST"})
454 458
      *
455
-     * @return string
459
+     * @return JsonResponse
456 460
      */
457 461
     public function moveMedia(Request $request)
458 462
     {
Please login to merge, or discard this patch.
src/Kunstmaan/MenuBundle/Controller/MenuItemAdminListController.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
      *
103 103
      * @Route("/{menuid}/items/add", name="kunstmaanmenubundle_admin_menuitem_add", methods={"GET", "POST"})
104 104
      *
105
-     * @return array
105
+     * @return Response
106 106
      */
107 107
     public function addAction(Request $request, $menuid)
108 108
     {
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
      *
117 117
      * @Route("{menuid}/items/{id}/edit", requirements={"id" = "\d+"}, name="kunstmaanmenubundle_admin_menuitem_edit", methods={"GET", "POST"})
118 118
      *
119
-     * @return array
119
+     * @return Response
120 120
      */
121 121
     public function editAction(Request $request, $menuid, $id)
122 122
     {
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
      *
131 131
      * @Route("{menuid}/items/{id}/delete", requirements={"id" = "\d+"}, name="kunstmaanmenubundle_admin_menuitem_delete", methods={"GET", "POST"})
132 132
      *
133
-     * @return array
133
+     * @return Response
134 134
      */
135 135
     public function deleteAction(Request $request, $menuid, $id)
136 136
     {
Please login to merge, or discard this patch.
src/Kunstmaan/AdminBundle/Entity/GroupPropertiesTrait.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
      *
136 136
      * @param Role $role
137 137
      *
138
-     * @return GroupInterface
138
+     * @return GroupPropertiesTrait
139 139
      *
140 140
      * @throws InvalidArgumentException
141 141
      */
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
      *
158 158
      * @param string $role
159 159
      *
160
-     * @return GroupInterface
160
+     * @return GroupPropertiesTrait
161 161
      */
162 162
     public function removeRole($role)
163 163
     {
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
      *
175 175
      * @param Role[] $roles array of Role objects
176 176
      *
177
-     * @return GroupInterface
177
+     * @return GroupPropertiesTrait
178 178
      */
179 179
     public function setRoles(array $roles)
180 180
     {
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
      *
192 192
      * @param Collection $collection
193 193
      *
194
-     * @return GroupInterface
194
+     * @return GroupPropertiesTrait
195 195
      */
196 196
     public function setRolesCollection(Collection $collection)
197 197
     {
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
      *
216 216
      * @param string $name New name of the group
217 217
      *
218
-     * @return GroupInterface
218
+     * @return GroupPropertiesTrait
219 219
      */
220 220
     public function setName($name)
221 221
     {
Please login to merge, or discard this patch.
src/Kunstmaan/ArticleBundle/Entity/AbstractAuthor.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
     }
52 52
 
53 53
     /**
54
-     * @param $link
54
+     * @param string $link
55 55
      */
56 56
     public function setLink($link)
57 57
     {
Please login to merge, or discard this patch.
src/Kunstmaan/GeneratorBundle/Helper/CommandAssistant.php 1 patch
Doc Comments   +27 added lines, -1 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
     }
87 87
 
88 88
     /**
89
-     * @return Questionhelper
89
+     * @return QuestionHelper
90 90
      */
91 91
     private function getQuestionHelper()
92 92
     {
@@ -119,6 +119,10 @@  discard block
 block discarded – undo
119 119
         }
120 120
     }
121 121
 
122
+    /**
123
+     * @param string $question
124
+     * @param \Closure $validator
125
+     */
122 126
     public function askAndValidate(
123 127
         $question,
124 128
         $validator,
@@ -139,6 +143,10 @@  discard block
 block discarded – undo
139 143
         );
140 144
     }
141 145
 
146
+    /**
147
+     * @param string $question
148
+     * @param string $defaultString
149
+     */
142 150
     public function askConfirmation(
143 151
         $question,
144 152
         $defaultString,
@@ -160,6 +168,10 @@  discard block
 block discarded – undo
160 168
         );
161 169
     }
162 170
 
171
+    /**
172
+     * @param string $question
173
+     * @param string $default
174
+     */
163 175
     public function ask($question, $default = null, array $autoComplete = null)
164 176
     {
165 177
         $askQuestion = new Question(
@@ -174,6 +186,9 @@  discard block
 block discarded – undo
174 186
         );
175 187
     }
176 188
 
189
+    /**
190
+     * @param string $question
191
+     */
177 192
     public function askSelect(
178 193
         $question,
179 194
         $choices,
@@ -212,6 +227,10 @@  discard block
 block discarded – undo
212 227
         }
213 228
     }
214 229
 
230
+    /**
231
+     * @param string $name
232
+     * @param null|string $value
233
+     */
215 234
     public function setOption($name, $value)
216 235
     {
217 236
         $this->input->setOption($name, $value);
@@ -222,6 +241,9 @@  discard block
 block discarded – undo
222 241
         return $this->input->hasOption($name);
223 242
     }
224 243
 
244
+    /**
245
+     * @param string $name
246
+     */
225 247
     public function getOption($name)
226 248
     {
227 249
         return $this->input->getOption($name);
@@ -232,6 +254,10 @@  discard block
 block discarded – undo
232 254
         return $this->input->isInteractive();
233 255
     }
234 256
 
257
+    /**
258
+     * @param string $option
259
+     * @param false $default
260
+     */
235 261
     public function getOptionOrDefault($option, $default = null)
236 262
     {
237 263
         return $this->input->hasOption($option) ? $this->input->getOption(
Please login to merge, or discard this patch.
Kunstmaan/GeneratorBundle/Generator/Symfony4EntityRepositoryGenerator.php 1 patch
Doc Comments   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -26,8 +26,8 @@  discard block
 block discarded – undo
26 26
 ';
27 27
 
28 28
     /**
29
-     * @param string $entityClassName
30
-     * @param string $repositoryClassName
29
+     * @param string $entityClass
30
+     * @param string $repositoryClass
31 31
      *
32 32
      * @return string
33 33
      */
@@ -44,8 +44,9 @@  discard block
 block discarded – undo
44 44
     }
45 45
 
46 46
     /**
47
-     * @param string $fullClassName
48 47
      * @param string $outputDirectory
48
+     * @param string $entityClass
49
+     * @param string $repositoryClass
49 50
      */
50 51
     public function writeEntityRepositoryClass($entityClass, $repositoryClass, $outputDirectory)
51 52
     {
Please login to merge, or discard this patch.
MediaBundle/Tests/unit/DependencyInjection/KunstmaanMediaExtensionTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
 class KunstmaanMediaExtensionTest extends AbstractExtensionTestCase
13 13
 {
14 14
     /**
15
-     * @return ExtensionInterface[]
15
+     * @return KunstmaanMediaExtension[]
16 16
      */
17 17
     protected function getContainerExtensions()
18 18
     {
Please login to merge, or discard this patch.