PagePartConfigurationParser::parse() - Code Metrics - Inspection of "Merge pull request #2061 from acrobat/update-depen..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9684f5...5d31f9 )

by Sander

created 2018-12-04 13:17 UTC

PagePartConfigurationParser::parse() C

↳ Parent: PagePartConfigurationParser

Complexity

Conditions	13
Paths	73

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	60
rs	6.6166
c	0
b	0
f	0
cc	13
nc	73
nop	2

How to fix Long Method Complexity

<?php

namespace Kunstmaan\PagePartBundle\PagePartConfigurationReader;

use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminConfigurator;
use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminConfiguratorInterface;
use Symfony\Component\HttpKernel\KernelInterface;
use Symfony\Component\Yaml\Yaml;

class PagePartConfigurationParser implements PagePartConfigurationParserInterface
{
    /**
     * @var KernelInterface
     */
    private $kernel;

    private $presets = [];

    private $stack = [];

    /**
     * @param KernelInterface $kernel
     * @param array           $presets
     */
    public function __construct(KernelInterface $kernel, array $presets = [])
    {
        $this->kernel = $kernel;
        $this->presets = $presets;
    }

    /**
     * This will read the $name file and parse it to the PageTemplate
     *
     * @param string                               $name
     * @param PagePartAdminConfiguratorInterface[] $existing
     *
     * @return PagePartAdminConfiguratorInterface
     *
     * @throws \Exception
     */
    public function parse($name, array $existing = [])
    {
        if (in_array($name, $this->stack)) {
            throw new \RuntimeException(sprintf('Recursion detected when parsing %s -> %s', implode(' -> ', $this->stack), $name));
        }
        $this->stack[] = $name;

        $value = $this->getValue($name);

        if (!array_key_exists('types', $value)) {
            $value['types'] = [];
        }

        if (array_key_exists('extends', $value)) {
            $namespace = '';
            if (false !== strpos($name, ':')) {
                $namespace = substr($name, 0, strpos($name, ':') + 1);
            }

            foreach ((array) $value['extends'] as $extend) {
                if (false === strpos($extend, ':')) {
                    $extend = $namespace . $extend;
                }

                if (false === isset($existing[$extend])) {
                    $existing[$extend] = $this->parse($extend, $existing);
                }

                $value['types'] = array_merge($existing[$extend]->getPossiblePagePartTypes(), $value['types']);
            }
        }

        $types = [];
        foreach ($value['types'] as $type) {
            if ('' === (string) $type['class']) {
                unset($types[$type['name']]);

                continue;
            }

            $types[$type['name']] = ['name' => $type['name'], 'class' => $type['class'], 'preview' => array_key_exists('preview', $type) ? $type['preview'] : ''];
            if (isset($type['pagelimit'])) {
                $types[$type['name']]['pagelimit'] = $type['pagelimit'];
            }
        }

        $result = new PagePartAdminConfigurator();
        $result->setName($value['name']);
        $result->setInternalName($name);
        $result->setPossiblePagePartTypes(array_values($types));
        $result->setContext($value['context']);

        if (isset($value['widget_template'])) {
            $result->setWidgetTemplate($value['widget_template']);
        }

        array_pop($this->stack);

        return $result;
    }

    private function getValue($name)

    {
        if (isset($this->presets[$name])) {
            return $this->presets[$name];
        }

        $nameParts = explode(':', $name);
        if (2 !== count($nameParts)) {
            throw new \Exception(sprintf('Malformed namespaced configuration name "%s" (expecting "namespace:pagename").',
                $name));
        }

        list($namespace, $name) = $nameParts;
        $path = $this->kernel->locateResource('@' . $namespace . '/Resources/config/pageparts/' . $name . '.yml');
        $value = Yaml::parse(file_get_contents($path));

        return $value;
    }
}


1			<?php
2
3			namespace Kunstmaan\PagePartBundle\PagePartConfigurationReader;
4
5			use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminConfigurator;
6			use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminConfiguratorInterface;
7			use Symfony\Component\HttpKernel\KernelInterface;
8			use Symfony\Component\Yaml\Yaml;
9
10			class PagePartConfigurationParser implements PagePartConfigurationParserInterface
11			{
12			/**
13			* @var KernelInterface
14			*/
15			private $kernel;
16
17			private $presets = [];
18
19			private $stack = [];
20
21			/**
22			* @param KernelInterface $kernel
23			* @param array $presets
24			*/
25			public function __construct(KernelInterface $kernel, array $presets = [])
26			{
27			$this->kernel = $kernel;
28			$this->presets = $presets;
29			}
30
31			/**
32			* This will read the $name file and parse it to the PageTemplate
33			*
34			* @param string $name
35			* @param PagePartAdminConfiguratorInterface[] $existing
36			*
37			* @return PagePartAdminConfiguratorInterface
38			*
39			* @throws \Exception
40			*/
41			public function parse($name, array $existing = [])
42			{
43			if (in_array($name, $this->stack)) {
44			throw new \RuntimeException(sprintf('Recursion detected when parsing %s -> %s', implode(' -> ', $this->stack), $name));
45			}
46			$this->stack[] = $name;
47
48			$value = $this->getValue($name);
49
50			if (!array_key_exists('types', $value)) {
51			$value['types'] = [];
52			}
53
54			if (array_key_exists('extends', $value)) {
55			$namespace = '';
56			if (false !== strpos($name, ':')) {
57			$namespace = substr($name, 0, strpos($name, ':') + 1);
58			}
59
60			foreach ((array) $value['extends'] as $extend) {
61			if (false === strpos($extend, ':')) {
62			$extend = $namespace . $extend;
63			}
64
65			if (false === isset($existing[$extend])) {
66			$existing[$extend] = $this->parse($extend, $existing);
67			}
68
69			$value['types'] = array_merge($existing[$extend]->getPossiblePagePartTypes(), $value['types']);
70			}
71			}
72
73			$types = [];
74			foreach ($value['types'] as $type) {
75			if ('' === (string) $type['class']) {
76			unset($types[$type['name']]);
77
78			continue;
79			}
80
81			$types[$type['name']] = ['name' => $type['name'], 'class' => $type['class'], 'preview' => array_key_exists('preview', $type) ? $type['preview'] : ''];
82			if (isset($type['pagelimit'])) {
83			$types[$type['name']]['pagelimit'] = $type['pagelimit'];
84			}
85			}
86
87			$result = new PagePartAdminConfigurator();
88			$result->setName($value['name']);
89			$result->setInternalName($name);
90			$result->setPossiblePagePartTypes(array_values($types));
91			$result->setContext($value['context']);
92
93			if (isset($value['widget_template'])) {
94			$result->setWidgetTemplate($value['widget_template']);
95			}
96
97			array_pop($this->stack);
98
99			return $result;
100			}
101
102			private function getValue($name)
			0 ignored issues – show Documentation introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
103			{
104			if (isset($this->presets[$name])) {
105			return $this->presets[$name];
106			}
107
108			$nameParts = explode(':', $name);
109			if (2 !== count($nameParts)) {
110			throw new \Exception(sprintf('Malformed namespaced configuration name "%s" (expecting "namespace:pagename").',
111			$name));
112			}
113
114			list($namespace, $name) = $nameParts;
115			$path = $this->kernel->locateResource('@' . $namespace . '/Resources/config/pageparts/' . $name . '.yml');
116			$value = Yaml::parse(file_get_contents($path));
117
118			return $value;
119			}
120			}
121

Kunstmaan / KunstmaanBundlesCMS

Push — master ( 9684f5...5d31f9 )

PagePartConfigurationParser::parse() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like