GoogleAnalyticsSegmentsListCommand::execute() - Code Metrics - Inspection of "Merge pull request #2061 from acrobat/update-depen..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9684f5...5d31f9 )

by Sander

created 2018-12-04 13:17 UTC

GoogleAnalyticsSegmentsListCommand::execute() B

↳ Parent: GoogleAnalyticsSegmentsListCommand

Complexity

Conditions	6
Paths	52

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	35
rs	8.7377
c	0
b	0
f	0
cc	6
nc	52
nop	2

<?php

namespace Kunstmaan\DashboardBundle\Command;

use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Doctrine\ORM\EntityManagerInterface;

/**
 * @final since 5.1
 * NEXT_MAJOR extend from `Command` and remove `$this->getContainer` usages
 */
class GoogleAnalyticsSegmentsListCommand extends ContainerAwareCommand
{
    /** @var EntityManagerInterface $em */
    private $em;

    /**
     * @param EntityManagerInterface|null $em
     */
    public function __construct(/* EntityManagerInterface */ $em = null)
    {
        parent::__construct();

        if (!$em instanceof EntityManagerInterface) {
            @trigger_error(sprintf('Passing a command name as the first argument of "%s" is deprecated since version symfony 3.4 and will be removed in symfony 4.0. If the command was registered by convention, make it a service instead. ', __METHOD__), E_USER_DEPRECATED);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

            $this->setName(null === $em ? 'kuma:dashboard:widget:googleanalytics:segments:list' : $em);

            return;
        }

        $this->em = $em;
    }

    protected function configure()
    {
        $this
            ->setName('kuma:dashboard:widget:googleanalytics:segments:list')
            ->setDescription('List available segments')
            ->addOption(
                'config',
                null,
                InputOption::VALUE_OPTIONAL,
                'Specify to only list overviews of one config',
                false
            );
    }

    /**
     * @param InputInterface  $input
     * @param OutputInterface $output
     *
     * @return int|null|void
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        if (null === $this->em) {
            $this->em = $this->getContainer()->get('doctrine.orm.entity_manager');
        }

        // get params
        $configId = $input->getOption('config');

        try {
            $segments = [];

            if ($configId) {
                $segments = $this->getSegmentsOfConfig($configId);
            } else {
                $segments = $this->getAllSegments();
            }

            if (count($segments)) {
                $result = "\t".'<fg=green>' . count($segments) . '</fg=green> segments found:';
                $output->writeln($result);
                foreach ($segments as $segment) {
                    $result = "\t".'(id: <fg=cyan>' .$segment->getId() . '</fg=cyan>)';
                    $result .= "\t".'(config: <fg=cyan>' .$segment->getconfig()->getId() . '</fg=cyan>)';
                    $result .= "\t" .'<fg=cyan>'. $segment->getquery() .'</fg=cyan> ('.$segment->getName().')';

                    $output->writeln($result);
                }
            } else {
                $output->writeln('No segments found');
            }
        } catch (\Exception $e) {
            $output->writeln('<fg=red>'.$e->getMessage().'</fg=red>');
        }
    }

    /**
     * get all segments of a config
     *
     * @param int $configId
     *
     * @return array
     */
    private function getSegmentsOfConfig($configId)

    {
        // get specified config
        $configRepository = $this->em->getRepository('KunstmaanDashboardBundle:AnalyticsConfig');
        $config = $configRepository->find($configId);

        if (!$config) {
            throw new \Exception('Unkown config ID');
        }

        // get the segments
        return $config->getSegments();
    }

    /**
     * get all segments
     *
     * @return array

     */
    private function getAllSegments()
    {
        // get all segments
        $segmentRepository = $this->em->getRepository('KunstmaanDashboardBundle:AnalyticsSegment');

        return $segmentRepository->findAll();
    }
}


1		<?php
2
3		namespace Kunstmaan\DashboardBundle\Command;
4
5		use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
6		use Symfony\Component\Console\Input\InputInterface;
7		use Symfony\Component\Console\Input\InputOption;
8		use Symfony\Component\Console\Output\OutputInterface;
9		use Doctrine\ORM\EntityManagerInterface;
10
11		/**
12		* @final since 5.1
13		* NEXT_MAJOR extend from `Command` and remove `$this->getContainer` usages
14		*/
15		class GoogleAnalyticsSegmentsListCommand extends ContainerAwareCommand
16		{
17		/** @var EntityManagerInterface $em */
18		private $em;
19
20		/**
21		* @param EntityManagerInterface\|null $em
22		*/
23		public function __construct(/* EntityManagerInterface */ $em = null)
24		{
25		parent::__construct();
26
27		if (!$em instanceof EntityManagerInterface) {
28		@trigger_error(sprintf('Passing a command name as the first argument of "%s" is deprecated since version symfony 3.4 and will be removed in symfony 4.0. If the command was registered by convention, make it a service instead. ', __METHOD__), E_USER_DEPRECATED);
		0 ignored issues – show Security Best Practice introduced 2018-06-15 13:01 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
29
30		$this->setName(null === $em ? 'kuma:dashboard:widget:googleanalytics:segments:list' : $em);
31
32		return;
33		}
34
35		$this->em = $em;
36		}
37
38		protected function configure()
39		{
40		$this
41		->setName('kuma:dashboard:widget:googleanalytics:segments:list')
42		->setDescription('List available segments')
43		->addOption(
44		'config',
45		null,
46		InputOption::VALUE_OPTIONAL,
47		'Specify to only list overviews of one config',
48		false
49		);
50		}
51
52		/**
53		* @param InputInterface $input
54		* @param OutputInterface $output
55		*
56		* @return int\|null\|void
57		*/
58		protected function execute(InputInterface $input, OutputInterface $output)
59		{
60		if (null === $this->em) {
61		$this->em = $this->getContainer()->get('doctrine.orm.entity_manager');
62		}
63
64		// get params
65		$configId = $input->getOption('config');
66
67		try {
68		$segments = [];
69
70		if ($configId) {
71		$segments = $this->getSegmentsOfConfig($configId);
72		} else {
73		$segments = $this->getAllSegments();
74		}
75
76		if (count($segments)) {
77		$result = "\t".'<fg=green>' . count($segments) . '</fg=green> segments found:';
78		$output->writeln($result);
79		foreach ($segments as $segment) {
80		$result = "\t".'(id: <fg=cyan>' .$segment->getId() . '</fg=cyan>)';
81		$result .= "\t".'(config: <fg=cyan>' .$segment->getconfig()->getId() . '</fg=cyan>)';
82		$result .= "\t" .'<fg=cyan>'. $segment->getquery() .'</fg=cyan> ('.$segment->getName().')';
83
84		$output->writeln($result);
85		}
86		} else {
87		$output->writeln('No segments found');
88		}
89		} catch (\Exception $e) {
90		$output->writeln('<fg=red>'.$e->getMessage().'</fg=red>');
91		}
92		}
93
94		/**
95		* get all segments of a config
96		*
97		* @param int $configId
98		*
99		* @return array
100		*/
101	View Code Duplication	private function getSegmentsOfConfig($configId)
		0 ignored issues – show Duplication introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
102		{
103		// get specified config
104		$configRepository = $this->em->getRepository('KunstmaanDashboardBundle:AnalyticsConfig');
105		$config = $configRepository->find($configId);
106
107		if (!$config) {
108		throw new \Exception('Unkown config ID');
109		}
110
111		// get the segments
112		return $config->getSegments();
113		}
114
115		/**
116		* get all segments
117		*
118		* @return array
		0 ignored issues – show Documentation introduced 2018-08-28 14:47 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `object[]`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
119		*/
120		private function getAllSegments()
121		{
122		// get all segments
123		$segmentRepository = $this->em->getRepository('KunstmaanDashboardBundle:AnalyticsSegment');
124
125		return $segmentRepository->findAll();
126		}
127		}
128

Kunstmaan / KunstmaanBundlesCMS

Push — master ( 9684f5...5d31f9 )

GoogleAnalyticsSegmentsListCommand::execute() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like