BaseSettingsController::get() - Code Metrics - Inspection of "Merge branch 'master' into 6.0" - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 6.0 ( eb641c...92cb73 )

by Ruud

created 2018-06-08 14:19 UTC

BaseSettingsController::get() A

↳ Parent: BaseSettingsController

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1

<?php

namespace Kunstmaan\AdminBundle\Controller;

use Symfony\Bundle\FrameworkBundle\Controller\Controller;

class BaseSettingsController extends Controller
{
    /**
     * {@inheritdoc}
     *
     * @deprecated
     */
    protected function get($id)
    {
        @trigger_error('Getting services directly from the container is deprecated in KunstmaanAdminBundle 5.1 and will be removed in KunstmaanAdminBundle 6.0. Register your controllers as services and inject the necessary dependencies.', E_USER_DEPRECATED);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        return parent::get($id);
    }

    /**
     * {@inheritdoc}
     *
     * @deprecated
     */
    protected function getParameter($name)
    {
        @trigger_error('Getting parameters directly from the container is deprecated in KunstmaanAdminBundle 5.1 and will be removed in KunstmaanAdminBundle 6.0. Register your controllers as services and inject the necessary parameters.', E_USER_DEPRECATED);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        return parent::getParameter($name);
    }
}


1			<?php
2
3			namespace Kunstmaan\AdminBundle\Controller;
4
5			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
6
7			class BaseSettingsController extends Controller
8			{
9			/**
10			* {@inheritdoc}
11			*
12			* @deprecated
13			*/
14			protected function get($id)
15			{
16			@trigger_error('Getting services directly from the container is deprecated in KunstmaanAdminBundle 5.1 and will be removed in KunstmaanAdminBundle 6.0. Register your controllers as services and inject the necessary dependencies.', E_USER_DEPRECATED);
			0 ignored issues – show Security Best Practice introduced 2018-05-31 09:33 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
17
18			return parent::get($id);
19			}
20
21			/**
22			* {@inheritdoc}
23			*
24			* @deprecated
25			*/
26			protected function getParameter($name)
27			{
28			@trigger_error('Getting parameters directly from the container is deprecated in KunstmaanAdminBundle 5.1 and will be removed in KunstmaanAdminBundle 6.0. Register your controllers as services and inject the necessary parameters.', E_USER_DEPRECATED);
			0 ignored issues – show Security Best Practice introduced 2018-05-31 09:33 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
29
30			return parent::getParameter($name);
31			}
32			}
33

Kunstmaan / KunstmaanBundlesCMS

Push — 6.0 ( eb641c...92cb73 )

BaseSettingsController::get() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like