Kunstmaan\MenuBundle\AdminList\MenuItemAdminListConfigurator

Complexity

Total Complexity

15

Size/Duplication

Total Lines	132
Duplicated Lines	6.82 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	9	9	1
A	buildFields()	0	8	1
A	getBundleName()	0	4	1
A	getEntityName()	0	4	1
A	adaptQueryBuilder()	0	6	1
B	getValue()	0	24	6
A	getExtraParameters()	0	4	1
A	decorateNewEntity()	0	6	1
A	getMenu()	0	4	1
A	getLimit()	0	4	1

<?php

namespace Kunstmaan\MenuBundle\AdminList;

use Doctrine\ORM\EntityManager;
use Doctrine\ORM\QueryBuilder;
use Kunstmaan\AdminBundle\Helper\Security\Acl\AclHelper;
use Kunstmaan\AdminListBundle\AdminList\Configurator\AbstractDoctrineORMAdminListConfigurator;
use Kunstmaan\MenuBundle\Entity\Menu;
use Kunstmaan\MenuBundle\Entity\MenuItem;

class MenuItemAdminListConfigurator extends AbstractDoctrineORMAdminListConfigurator
{
    /**
     * @var Menu
     */
    private $menu;

    /**
     * @param EntityManager $em        The entity manager
     * @param AclHelper     $aclHelper The acl helper

Should the type for parameter $aclHelper not be null|AclHelper?

     * @param Menu          $menu
     */
    public function __construct(EntityManager $em, AclHelper $aclHelper = null, Menu $menu)

This method seems to be duplicated in your project.

    {
        parent::__construct($em, $aclHelper);

        $this->setListTemplate('KunstmaanMenuBundle:AdminList:list-menu-item.html.twig');
        $this->setAddTemplate('KunstmaanMenuBundle:AdminList:edit-menu-item.html.twig');
        $this->setEditTemplate('KunstmaanMenuBundle:AdminList:edit-menu-item.html.twig');
        $this->menu = $menu;
    }

    /**
     * Configure the visible columns
     */
    public function buildFields()
    {
        $this->addField('title', 'kuma_menu.menu_item.adminlist.field.title', false, 'KunstmaanMenuBundle:AdminList:menu-item-title.html.twig');
        $this->addField('online', 'kuma_menu.menu_item.adminlist.field.online', false, 'KunstmaanMenuBundle:AdminList:menu-item-online.html.twig');
        $this->addField('type', 'kuma_menu.menu_item.adminlist.field.type', false);
        $this->addField('url', 'kuma_menu.menu_item.adminlist.field.url', false, 'KunstmaanMenuBundle:AdminList:menu-item-url.html.twig');
        $this->addField('newWindow', 'kuma_menu.menu_item.adminlist.field.new_window', false);
    }

    /**
     * Get bundle name
     *
     * @return string
     */
    public function getBundleName()
    {
        return 'KunstmaanMenuBundle';
    }

    /**
     * Get entity name
     *
     * @return string
     */
    public function getEntityName()
    {
        return 'MenuItem';
    }

    /**
     * @param QueryBuilder $qb
     */
    public function adaptQueryBuilder(QueryBuilder $qb)
    {
        $qb->andWhere('b.menu = :menu');
        $qb->setParameter('menu', $this->menu);
        $qb->orderBy('b.lft', 'ASC');
    }

    /**
     * @param array|object $item       The item
     * @param string       $columnName The column name
     *
     * @return mixed
     */
    public function getValue($item, $columnName)
    {
        if ($columnName == 'title') {
            return $item->getDisplayTitle();
        }

        if ($columnName == 'online') {
            return $item;
        }

        if ($columnName == 'type') {
            if ($item->getType() == MenuItem::TYPE_PAGE_LINK) {
                return 'Page link';
            }

            return 'External link';
        }

        if ($columnName == 'url') {
            return $item;
        }

        return parent::getValue($item, $columnName);
    }

    /**
     * Return extra parameters for use in list actions.
     *
     * @return array

Consider making the return type a bit more specific; maybe use array<string,integer>.

     */
    public function getExtraParameters()
    {
        return array('menuid' => $this->menu->getId());
    }

    /**
     * You can override this method to do some custom things you need to do when adding an entity
     *
     * @param object $entity
     *
     * @return mixed

Consider making the return type a bit more specific; maybe use object.

     */
    public function decorateNewEntity($entity)
    {
        $entity->setMenu($this->menu);

        return $entity;
    }

    public function getMenu()
    {
        return $this->menu;
    }

    /**
     * @return int
     */
    public function getLimit()
    {
        return 1000;
    }
}