CreateUserCommand::getGroups() - Code Metrics - Inspection of "Fixed issue when running kuma:user:create with --n..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 5.0 (#2103)

by Kevin

created 2018-09-06 18:25 UTC

CreateUserCommand::getGroups() A

↳ Parent: CreateUserCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.8666
c	0
b	0
f	0
cc	2
nc	2
nop	0

<?php

namespace Kunstmaan\AdminBundle\Command;

use Doctrine\ORM\EntityManager;
use Kunstmaan\AdminBundle\Entity\Group;
use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ChoiceQuestion;
use Symfony\Component\Console\Question\Question;
use Symfony\Component\Console\Exception\InvalidArgumentException;

/**
 * Symfony CLI command to create a user using bin/console kuma:user:create <username_of_the_user>
 */
class CreateUserCommand extends ContainerAwareCommand
{
    /** @var array */
    protected $groups = [];

    protected function configure()
    {
        parent::configure();

        $this->setName('kuma:user:create')
            ->setDescription('Create a user.')
            ->setDefinition(array(
                new InputArgument('username', InputArgument::REQUIRED, 'The username'),
                new InputArgument('email', InputArgument::REQUIRED, 'The email'),
                new InputArgument('password', InputArgument::REQUIRED, 'The password'),
                new InputArgument('locale', InputArgument::OPTIONAL, 'The locale (language)'),
                new InputOption('group', null, InputOption::VALUE_REQUIRED, 'The group(s) the user should belong to'),
                new InputOption('super-admin', null, InputOption::VALUE_NONE, 'Set the user as super admin'),
                new InputOption('inactive', null, InputOption::VALUE_NONE, 'Set the user as inactive'),
            ))
            ->setHelp(<<<EOT
The <info>kuma:user:create</info> command creates a user:

  <info>php bin/console kuma:user:create matthieu --group=Users</info>

This interactive shell will ask you for an email and then a password.

You can alternatively specify the email, password and locale and group as extra arguments:

  <info>php bin/console kuma:user:create matthieu [email protected] mypassword en --group=Users</info>

You can create a super admin via the super-admin flag:

  <info>php bin/console kuma:user:create admin --super-admin --group=Administrators</info>

You can create an inactive user (will not be able to log in):

  <info>php bin/console kuma:user:create thibault --inactive --group=Users</info>

<comment>Note:</comment> You have to specify at least one group.

EOT
            );
    }

    protected function initialize(InputInterface $input, OutputInterface $output)
    {
        $this->groups = $this->getGroups();
    }


    /**
     * Executes the current command.
     *
     * @param InputInterface $input The input
     * @param OutputInterface $output The output
     *
     * @return int

     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        /* @var EntityManager $em */
        $em = $this->getContainer()->get('doctrine.orm.entity_manager');

        $username = $input->getArgument('username');
        $email = $input->getArgument('email');
        $password = $input->getArgument('password');
        $locale = $input->getArgument('locale');
        $superAdmin = $input->getOption('super-admin');
        $inactive = $input->getOption('inactive');
        $groupOption = $input->getOption('group');

        if (null !== $locale) {
            $locale = $this->getContainer()->getParameter('kunstmaan_admin.default_admin_locale');
        }
        $command = $this->getApplication()->find('fos:user:create');
        $arguments = array(
            'command' => 'fos:user:create',
            'username' => $username,
            'email' => $email,
            'password' => $password,
            '--super-admin' => $superAdmin,
            '--inactive' => $inactive,
        );

        $input = new ArrayInput($arguments);
        $command->run($input, $output);

        // Fetch user that was just created
        $userClassName = $this->getContainer()->getParameter('fos_user.model.user.class');
        $user = $em->getRepository($userClassName)->findOneBy(array('username' => $username));

        // Attach groups
        $groupOutput = [];


        foreach (explode(',', $groupOption) as $groupId) {

            if ((int)$groupId === 0) {
                foreach ($this->groups as $value) {
                    if ($groupId === $value->getName()) {
                        $group = $value;
                        break;
                    }
                }
            } else {
                $group = $this->groups[$groupId];
            }

            if (isset($group) && $group instanceof Group) {
                $groupOutput[] = $group->getName();
                $user->getGroups()->add($group);
            } else {
                throw new \RuntimeException(
                    'The selected group(s) can\'t be found.'
                );
            }
        }

        // Set admin interface locale and enable password changed
        $user->setAdminLocale($locale);
        $user->setPasswordChanged(true);

        // Persist
        $em->persist($user);
        $em->flush();

        $output->writeln(sprintf('Added user <comment>%s</comment> to groups <comment>%s</comment>', $input->getArgument('username'), implode(',', $groupOutput)));
    }

    /**
     * Interacts with the user.
     *
     * @param InputInterface $input The input
     * @param OutputInterface $output The output
     *
     * @throws \InvalidArgumentException
     *
     * @return void
     */
    protected function interact(InputInterface $input, OutputInterface $output)
    {
        if (!$input->getArgument('username')) {

            $question = New Question('Please choose a username:');
            $question->setValidator(function ($username) {
                if (null === $username) {
                    throw new \InvalidArgumentException('Username can not be empty');
                }

                return $username;
            });
            $username = $this->getHelper('question')->ask(
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                $input,
                $output,
                $question
            );
            $input->setArgument('username', $username);
        }

        if (!$input->getArgument('email')) {

            $question = New Question('Please choose an email:');
            $question->setValidator(function ($email) {
                if (null === $email) {
                    throw new \InvalidArgumentException('Email can not be empty');
                }

                return $email;
            });
            $email = $this->getHelper('question')->ask(
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                $input,
                $output,
                $question
            );
            $input->setArgument('email', $email);
        }

        if (!$input->getArgument('password')) {

            $question = New Question('Please choose a password:');
            $question->setHidden(true);
            $question->setHiddenFallback(false);
            $question->setValidator(function ($password) {
                if (null === $password) {
                    throw new \InvalidArgumentException('Password can not be empty');
                }

                return $password;
            });
            $password = $this->getHelper('question')->ask(
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                $input,
                $output,
                $question
            );

            $input->setArgument('password', $password);
        }

        if (!$input->getArgument('locale')) {
            $locale = $this->getHelper('question')->ask(
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                $input,
                $output,
                new Question('Please enter the locale (or leave empty for default admin locale):')
            );
            $input->setArgument('locale', $locale);
        }

        if (!$input->getOption('group')) {
            $question = new ChoiceQuestion(
                'Please enter the group(s) the user should be a member of (multiple possible, separated by comma):',
                $this->groups,
                ''
            );
            $question->setMultiselect(true);
            $question->setValidator(function ($groupsInput) {

                if (!$this->groups) {

                    throw new \RuntimeException('No user group(s) could be found');
                }

                // Validate that the chosen group options exist in the available groups
                $groupNames = array_unique(explode(',', $groupsInput));
                if (count(array_intersect_key(array_flip($groupNames),$this->groups)) !== count($groupNames)) {
                    throw new InvalidArgumentException('You have chosen non existing group(s)');
                }

                if ($groupsInput === '') {
                    throw new \RuntimeException(
                        'Group(s) must be of type integer and can not be empty'
                    );
                }
                return $groupsInput;
            });

            // Group has to be imploded because $input->setOption expects a string
            $groups = $this->getHelper('question')->ask($input, $output, $question);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

            $input->setOption('group', $groups);
        }
    }

    private function getGroups()
    {
        $groups = $this->getContainer()->get('fos_user.group_manager')->findGroups();

        // reindexing the array, using the db id as the key
        $newGroups = [];
        foreach($groups as $group) {
            $newGroups[$group->getId()] = $group;
        }

        return $newGroups;
    }
}


Pull Request — 5.0 (#2103)

CreateUserCommand::getGroups() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace Kunstmaan\AdminBundle\Command;
4
5		use Doctrine\ORM\EntityManager;
6		use Kunstmaan\AdminBundle\Entity\Group;
7		use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
8		use Symfony\Component\Console\Input\ArrayInput;
9		use Symfony\Component\Console\Input\InputArgument;
10		use Symfony\Component\Console\Input\InputInterface;
11		use Symfony\Component\Console\Input\InputOption;
12		use Symfony\Component\Console\Output\OutputInterface;
13		use Symfony\Component\Console\Question\ChoiceQuestion;
14		use Symfony\Component\Console\Question\Question;
15		use Symfony\Component\Console\Exception\InvalidArgumentException;
16
17		/**
18		* Symfony CLI command to create a user using bin/console kuma:user:create <username_of_the_user>
19		*/
20		class CreateUserCommand extends ContainerAwareCommand
21		{
22		/** @var array */
23		protected $groups = [];
24
25		protected function configure()
26		{
27		parent::configure();
28
29		$this->setName('kuma:user:create')
30		->setDescription('Create a user.')
31		->setDefinition(array(
32		new InputArgument('username', InputArgument::REQUIRED, 'The username'),
33		new InputArgument('email', InputArgument::REQUIRED, 'The email'),
34		new InputArgument('password', InputArgument::REQUIRED, 'The password'),
35		new InputArgument('locale', InputArgument::OPTIONAL, 'The locale (language)'),
36		new InputOption('group', null, InputOption::VALUE_REQUIRED, 'The group(s) the user should belong to'),
37		new InputOption('super-admin', null, InputOption::VALUE_NONE, 'Set the user as super admin'),
38		new InputOption('inactive', null, InputOption::VALUE_NONE, 'Set the user as inactive'),
39		))
40		->setHelp(<<<EOT
41		The <info>kuma:user:create</info> command creates a user:
42
43		<info>php bin/console kuma:user:create matthieu --group=Users</info>
44
45		This interactive shell will ask you for an email and then a password.
46
47		You can alternatively specify the email, password and locale and group as extra arguments:
48
49		<info>php bin/console kuma:user:create matthieu [email protected] mypassword en --group=Users</info>
50
51		You can create a super admin via the super-admin flag:
52
53		<info>php bin/console kuma:user:create admin --super-admin --group=Administrators</info>
54
55		You can create an inactive user (will not be able to log in):
56
57		<info>php bin/console kuma:user:create thibault --inactive --group=Users</info>
58
59		<comment>Note:</comment> You have to specify at least one group.
60
61		EOT
62		);
63		}
64
65		protected function initialize(InputInterface $input, OutputInterface $output)
66		{
67		$this->groups = $this->getGroups();
68		}
69
70
71		/**
72		* Executes the current command.
73		*
74		* @param InputInterface $input The input
75		* @param OutputInterface $output The output
76		*
77		* @return int
		0 ignored issues – show Documentation introduced 2018-04-20 14:09 UTC by Report Bug Copy Issue Report Should the return type not be `integer\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
78		*/
79		protected function execute(InputInterface $input, OutputInterface $output)
80		{
81		/* @var EntityManager $em */
82		$em = $this->getContainer()->get('doctrine.orm.entity_manager');
83
84		$username = $input->getArgument('username');
85		$email = $input->getArgument('email');
86		$password = $input->getArgument('password');
87		$locale = $input->getArgument('locale');
88		$superAdmin = $input->getOption('super-admin');
89		$inactive = $input->getOption('inactive');
90		$groupOption = $input->getOption('group');
91
92		if (null !== $locale) {
93		$locale = $this->getContainer()->getParameter('kunstmaan_admin.default_admin_locale');
94		}
95		$command = $this->getApplication()->find('fos:user:create');
96		$arguments = array(
97		'command' => 'fos:user:create',
98		'username' => $username,
99		'email' => $email,
100		'password' => $password,
101		'--super-admin' => $superAdmin,
102		'--inactive' => $inactive,
103		);
104
105		$input = new ArrayInput($arguments);
106		$command->run($input, $output);
107
108		// Fetch user that was just created
109		$userClassName = $this->getContainer()->getParameter('fos_user.model.user.class');
110		$user = $em->getRepository($userClassName)->findOneBy(array('username' => $username));
111
112		// Attach groups
113		$groupOutput = [];
114
115
116		foreach (explode(',', $groupOption) as $groupId) {
117
118		if ((int)$groupId === 0) {
119		foreach ($this->groups as $value) {
120		if ($groupId === $value->getName()) {
121		$group = $value;
122		break;
123		}
124		}
125		} else {
126		$group = $this->groups[$groupId];
127		}
128
129		if (isset($group) && $group instanceof Group) {
130		$groupOutput[] = $group->getName();
131		$user->getGroups()->add($group);
132		} else {
133		throw new \RuntimeException(
134		'The selected group(s) can\'t be found.'
135		);
136		}
137		}
138
139		// Set admin interface locale and enable password changed
140		$user->setAdminLocale($locale);
141		$user->setPasswordChanged(true);
142
143		// Persist
144		$em->persist($user);
145		$em->flush();
146
147		$output->writeln(sprintf('Added user <comment>%s</comment> to groups <comment>%s</comment>', $input->getArgument('username'), implode(',', $groupOutput)));
148		}
149
150		/**
151		* Interacts with the user.
152		*
153		* @param InputInterface $input The input
154		* @param OutputInterface $output The output
155		*
156		* @throws \InvalidArgumentException
157		*
158		* @return void
159		*/
160		protected function interact(InputInterface $input, OutputInterface $output)
161		{
162	View Code Duplication	if (!$input->getArgument('username')) {
		0 ignored issues – show Duplication introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
163		$question = New Question('Please choose a username:');
164		$question->setValidator(function ($username) {
165		if (null === $username) {
166		throw new \InvalidArgumentException('Username can not be empty');
167		}
168
169		return $username;
170		});
171		$username = $this->getHelper('question')->ask(
		0 ignored issues – show Bug introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Console\Helper\HelperInterface` as the method `ask()` does only exist in the following implementations of said interface: `Sensio\Bundle\GeneratorB...d\Helper\QuestionHelper`, `Symfony\Component\Console\Helper\QuestionHelper`, `Symfony\Component\Consol...r\SymfonyQuestionHelper`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
172		$input,
173		$output,
174		$question
175		);
176		$input->setArgument('username', $username);
177		}
178
179	View Code Duplication	if (!$input->getArgument('email')) {
		0 ignored issues – show Duplication introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
180		$question = New Question('Please choose an email:');
181		$question->setValidator(function ($email) {
182		if (null === $email) {
183		throw new \InvalidArgumentException('Email can not be empty');
184		}
185
186		return $email;
187		});
188		$email = $this->getHelper('question')->ask(
		0 ignored issues – show Bug introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Console\Helper\HelperInterface` as the method `ask()` does only exist in the following implementations of said interface: `Sensio\Bundle\GeneratorB...d\Helper\QuestionHelper`, `Symfony\Component\Console\Helper\QuestionHelper`, `Symfony\Component\Consol...r\SymfonyQuestionHelper`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
189		$input,
190		$output,
191		$question
192		);
193		$input->setArgument('email', $email);
194		}
195
196		if (!$input->getArgument('password')) {
197
198		$question = New Question('Please choose a password:');
199		$question->setHidden(true);
200		$question->setHiddenFallback(false);
201		$question->setValidator(function ($password) {
202		if (null === $password) {
203		throw new \InvalidArgumentException('Password can not be empty');
204		}
205
206		return $password;
207		});
208		$password = $this->getHelper('question')->ask(
		0 ignored issues – show Bug introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Console\Helper\HelperInterface` as the method `ask()` does only exist in the following implementations of said interface: `Sensio\Bundle\GeneratorB...d\Helper\QuestionHelper`, `Symfony\Component\Console\Helper\QuestionHelper`, `Symfony\Component\Consol...r\SymfonyQuestionHelper`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
209		$input,
210		$output,
211		$question
212		);
213
214		$input->setArgument('password', $password);
215		}
216
217		if (!$input->getArgument('locale')) {
218		$locale = $this->getHelper('question')->ask(
		0 ignored issues – show Bug introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Console\Helper\HelperInterface` as the method `ask()` does only exist in the following implementations of said interface: `Sensio\Bundle\GeneratorB...d\Helper\QuestionHelper`, `Symfony\Component\Console\Helper\QuestionHelper`, `Symfony\Component\Consol...r\SymfonyQuestionHelper`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
219		$input,
220		$output,
221		new Question('Please enter the locale (or leave empty for default admin locale):')
222		);
223		$input->setArgument('locale', $locale);
224		}
225
226		if (!$input->getOption('group')) {
227		$question = new ChoiceQuestion(
228		'Please enter the group(s) the user should be a member of (multiple possible, separated by comma):',
229		$this->groups,
230		''
231		);
232		$question->setMultiselect(true);
233		$question->setValidator(function ($groupsInput) {
234
235		if (!$this->groups) {
		0 ignored issues – show Bug Best Practice introduced 2018-05-30 13:34 UTC by Report Bug Copy Issue Report The expression `$this->groups` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
236		throw new \RuntimeException('No user group(s) could be found');
237		}
238
239		// Validate that the chosen group options exist in the available groups
240		$groupNames = array_unique(explode(',', $groupsInput));
241		if (count(array_intersect_key(array_flip($groupNames),$this->groups)) !== count($groupNames)) {
242		throw new InvalidArgumentException('You have chosen non existing group(s)');
243		}
244
245		if ($groupsInput === '') {
246		throw new \RuntimeException(
247		'Group(s) must be of type integer and can not be empty'
248		);
249		}
250		return $groupsInput;
251		});
252
253		// Group has to be imploded because $input->setOption expects a string
254		$groups = $this->getHelper('question')->ask($input, $output, $question);
		0 ignored issues – show Bug introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Console\Helper\HelperInterface` as the method `ask()` does only exist in the following implementations of said interface: `Sensio\Bundle\GeneratorB...d\Helper\QuestionHelper`, `Symfony\Component\Console\Helper\QuestionHelper`, `Symfony\Component\Consol...r\SymfonyQuestionHelper`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
255
256		$input->setOption('group', $groups);
257		}
258		}
259
260		private function getGroups()
261		{
262		$groups = $this->getContainer()->get('fos_user.group_manager')->findGroups();
263
264		// reindexing the array, using the db id as the key
265		$newGroups = [];
266		foreach($groups as $group) {
267		$newGroups[$group->getId()] = $group;
268		}
269
270		return $newGroups;
271		}
272		}
273

Kunstmaan / KunstmaanBundlesCMS

Pull Request — 5.0 (#2103)

CreateUserCommand::getGroups() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like