CipherCommand::execute() - Code Metrics - Inspection of "Merge pull request #2662 from acrobat/replace-doct..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6d6774...64f3ed )

by Jeroen

created 2020-06-25 11:41 UTC

CipherCommand::execute() C

↳ Parent: CipherCommand

Complexity

Conditions	15
Paths	22

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	240

Importance

Changes

Metric	Value
dl	0
loc	87
ccs	0
cts	53
cp	0
rs	5.0169
c	0
b	0
f	0
cc	15
nc	22
nop	2
crap	240

How to fix Long Method Complexity

<?php

namespace Kunstmaan\UtilitiesBundle\Command;

use Kunstmaan\UtilitiesBundle\Helper\Cipher\CipherInterface;
use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ChoiceQuestion;
use Symfony\Component\Console\Question\Question;
use Symfony\Component\Filesystem\Filesystem;

/**
 * @final since 5.1
 * NEXT_MAJOR extend from `Command` and remove `$this->getContainer` usages
 */
class CipherCommand extends ContainerAwareCommand

{
    /**
     * @var CipherInterface
     */
    private $cipher;

    private static $methods = [
        0 => 'Encrypt text',
        1 => 'Decrypt text',
        2 => 'Encrypt file',
        3 => 'Decrypt file',
    ];

    /**
     * @param CipherInterface|null $cipher
     */
    public function __construct(/* CipherInterface */ $cipher = null)
    {
        parent::__construct();

        if (!$cipher instanceof CipherInterface) {
            @trigger_error(sprintf('Passing a command name as the first argument of "%s" is deprecated since version symfony 3.4 and will be removed in symfony 4.0. If the command was registered by convention, make it a service instead. ', __METHOD__), E_USER_DEPRECATED);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

            $this->setName(null === $cipher ? 'kuma:cipher' : $cipher);

            return;
        }

        $this->cipher = $cipher;
    }

    protected function configure()
    {
        $this->setName('kuma:cipher')->setDescription('Cipher utilities commands.');
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        if (null === $this->cipher) {
            $this->cipher = $this->getContainer()->get('kunstmaan_utilities.cipher');
        }
        $helper = $this->getHelper('question');

        $question = new ChoiceQuestion(
            'Please select the method you want to use',
            self::$methods,
            0
        );

        $question->setErrorMessage('Method %s is invalid.');
        $method = $helper->ask($input, $output, $question);
        $method = array_search($method, self::$methods, true);
        switch ($method) {
            case 0:
            case 1:
                $question = new Question('Please enter the text: ');
                $question->setValidator(function ($value) {
                    if (trim($value) === '') {
                        throw new \Exception('The text cannot be empty');
                    }

                    return $value;
                });
                $question->setMaxAttempts(3);
                $text = $helper->ask($input, $output, $question);
                $text = $method === 0 ? $this->cipher->encrypt($text) : $this->cipher->decrypt($text);
                $output->writeln(sprintf('Result: %s', $text));

                break;
            case 2:
            case 3:
            $fs = new Filesystem();

            $question = new Question('Please enter the input file path: ');
                $question->setValidator(function ($value) use ($fs) {
                    if (trim($value) === '') {
                        throw new \Exception('The input file path cannot be empty');
                    }

                    if (false === $fs->exists($value)) {
                        throw new \Exception('The input file must exists');
                    }

                    if (is_dir($value)) {
                        throw new \Exception('The input file cannot be a dir');
                    }

                    return $value;
                });
                $question->setMaxAttempts(3);
                $inputFilePath = $helper->ask($input, $output, $question);

                $question = new Question('Please enter the output file path: ');
                $question->setValidator(function ($value) {
                    if (trim($value) === '') {
                        throw new \Exception('The output file path cannot be empty');
                    }

                    if (is_dir($value)) {
                        throw new \Exception('The output file path cannot be a dir');
                    }

                    return $value;
                });
                $question->setMaxAttempts(3);
                $outputFilePath = $helper->ask($input, $output, $question);

                if ($method === 2) {
                    $this->cipher->encryptFile($inputFilePath, $outputFilePath);
                } else {
                    if (false === $fs->exists($outputFilePath)) {
                        $fs->touch($outputFilePath);
                    }
                    $this->cipher->decryptFile($inputFilePath, $outputFilePath);
                }

                $output->writeln(sprintf('Check "%s" to see result', $outputFilePath));

                break;
        }

        return 0;
    }
}


1			<?php
2
3			namespace Kunstmaan\UtilitiesBundle\Command;
4
5			use Kunstmaan\UtilitiesBundle\Helper\Cipher\CipherInterface;
6			use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
7			use Symfony\Component\Console\Input\InputInterface;
8			use Symfony\Component\Console\Output\OutputInterface;
9			use Symfony\Component\Console\Question\ChoiceQuestion;
10			use Symfony\Component\Console\Question\Question;
11			use Symfony\Component\Filesystem\Filesystem;
12
13			/**
14			* @final since 5.1
15			* NEXT_MAJOR extend from `Command` and remove `$this->getContainer` usages
16			*/
17			class CipherCommand extends ContainerAwareCommand
			0 ignored issues – show Deprecated Code introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report The class `Symfony\Bundle\Framework...d\ContainerAwareCommand` has been deprecated with message: since Symfony 4.2, use {@see Command} instead. This class, trait or interface has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the type will be removed from the class and what other constant to use instead. Loading history...
18			{
19			/**
20			* @var CipherInterface
21			*/
22			private $cipher;
23
24			private static $methods = [
25			0 => 'Encrypt text',
26			1 => 'Decrypt text',
27			2 => 'Encrypt file',
28			3 => 'Decrypt file',
29			];
30
31			/**
32			* @param CipherInterface\|null $cipher
33			*/
34			public function __construct(/* CipherInterface */ $cipher = null)
35			{
36			parent::__construct();
37
38			if (!$cipher instanceof CipherInterface) {
39			@trigger_error(sprintf('Passing a command name as the first argument of "%s" is deprecated since version symfony 3.4 and will be removed in symfony 4.0. If the command was registered by convention, make it a service instead. ', __METHOD__), E_USER_DEPRECATED);
			0 ignored issues – show Security Best Practice introduced 2018-04-18 14:49 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
40
41			$this->setName(null === $cipher ? 'kuma:cipher' : $cipher);
42
43			return;
44			}
45
46			$this->cipher = $cipher;
47			}
48
49			protected function configure()
50			{
51			$this->setName('kuma:cipher')->setDescription('Cipher utilities commands.');
52			}
53
54			protected function execute(InputInterface $input, OutputInterface $output)
55			{
56			if (null === $this->cipher) {
57			$this->cipher = $this->getContainer()->get('kunstmaan_utilities.cipher');
58			}
59			$helper = $this->getHelper('question');
60
61			$question = new ChoiceQuestion(
62			'Please select the method you want to use',
63			self::$methods,
64			0
65			);
66
67			$question->setErrorMessage('Method %s is invalid.');
68			$method = $helper->ask($input, $output, $question);
69			$method = array_search($method, self::$methods, true);
70			switch ($method) {
71			case 0:
72			case 1:
73			$question = new Question('Please enter the text: ');
74			$question->setValidator(function ($value) {
75			if (trim($value) === '') {
76			throw new \Exception('The text cannot be empty');
77			}
78
79			return $value;
80			});
81			$question->setMaxAttempts(3);
82			$text = $helper->ask($input, $output, $question);
83			$text = $method === 0 ? $this->cipher->encrypt($text) : $this->cipher->decrypt($text);
84			$output->writeln(sprintf('Result: %s', $text));
85
86			break;
87			case 2:
88			case 3:
89			$fs = new Filesystem();
90
91			$question = new Question('Please enter the input file path: ');
92			$question->setValidator(function ($value) use ($fs) {
93			if (trim($value) === '') {
94			throw new \Exception('The input file path cannot be empty');
95			}
96
97			if (false === $fs->exists($value)) {
98			throw new \Exception('The input file must exists');
99			}
100
101			if (is_dir($value)) {
102			throw new \Exception('The input file cannot be a dir');
103			}
104
105			return $value;
106			});
107			$question->setMaxAttempts(3);
108			$inputFilePath = $helper->ask($input, $output, $question);
109
110			$question = new Question('Please enter the output file path: ');
111			$question->setValidator(function ($value) {
112			if (trim($value) === '') {
113			throw new \Exception('The output file path cannot be empty');
114			}
115
116			if (is_dir($value)) {
117			throw new \Exception('The output file path cannot be a dir');
118			}
119
120			return $value;
121			});
122			$question->setMaxAttempts(3);
123			$outputFilePath = $helper->ask($input, $output, $question);
124
125			if ($method === 2) {
126			$this->cipher->encryptFile($inputFilePath, $outputFilePath);
127			} else {
128			if (false === $fs->exists($outputFilePath)) {
129			$fs->touch($outputFilePath);
130			}
131			$this->cipher->decryptFile($inputFilePath, $outputFilePath);
132			}
133
134			$output->writeln(sprintf('Check "%s" to see result', $outputFilePath));
135
136			break;
137			}
138
139			return 0;
140			}
141			}
142

Kunstmaan / KunstmaanBundlesCMS

Push — master ( 6d6774...64f3ed )

CipherCommand::execute() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like