PageTemplateWidget::__construct() - Code Metrics - Inspection of "Merge pull request #2662 from acrobat/replace-doct..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6d6774...64f3ed )

by Jeroen

created 2020-06-25 11:41 UTC

PageTemplateWidget::__construct() A

↳ Parent: PageTemplateWidget

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	26
ccs	0
cts	23
cp	0
rs	9.504
c	0
b	0
f	0
cc	3
nc	3
nop	7
crap	12

<?php

namespace Kunstmaan\PagePartBundle\Helper\FormWidgets;

use Doctrine\ORM\EntityManager;
use Doctrine\ORM\EntityManagerInterface;
use Kunstmaan\AdminBundle\Helper\FormWidgets\FormWidget;
use Kunstmaan\NodeBundle\Entity\PageInterface;
use Kunstmaan\PagePartBundle\Entity\PageTemplateConfiguration;
use Kunstmaan\PagePartBundle\Helper\HasPageTemplateInterface;
use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdmin;
use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminConfiguratorInterface;
use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminFactory;
use Kunstmaan\PagePartBundle\PagePartConfigurationReader\PagePartConfigurationReaderInterface;
use Kunstmaan\PagePartBundle\PageTemplate\PageTemplateConfigurationReaderInterface;
use Kunstmaan\PagePartBundle\PageTemplate\PageTemplateConfigurationService;
use Kunstmaan\PagePartBundle\PageTemplate\PageTemplateInterface;
use Kunstmaan\PagePartBundle\PageTemplate\Region;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\Form\FormView;
use Symfony\Component\HttpFoundation\Request;

/**
 * PageTemplateWidget
 */
class PageTemplateWidget extends FormWidget
{
    /**
     * @var EntityManagerInterface
     */
    private $em;

    /**
     * @var PagePartAdminFactory
     */
    private $pagePartAdminFactory;

    /**
     * @var PageInterface
     */
    private $page;

    /**
     * @var Request
     */
    private $request;

    /**
     * @var PagePartWidget[]
     */
    private $widgets = array();

    /**
     * @var PageTemplateInterface[]
     */
    private $pageTemplates = array();

    /**
     * @var PagePartAdminConfiguratorInterface[]
     */
    private $pagePartAdminConfigurations = array();

    /**
     * @var PageTemplateConfiguration
     */
    protected $pageTemplateConfiguration;

    /**
     * @param HasPageTemplateInterface                 $page
     * @param Request                                  $request
     * @param EntityManagerInterface                   $em
     * @param PagePartAdminFactory                     $pagePartAdminFactory
     * @param PageTemplateConfigurationReaderInterface $templateReader
     * @param PagePartConfigurationReaderInterface     $pagePartReader
     * @param PageTemplateConfigurationService         $pageTemplateConfigurationService
     */
    public function __construct(
        HasPageTemplateInterface $page,
        Request $request,

        EntityManagerInterface $em,
        PagePartAdminFactory $pagePartAdminFactory,
        PageTemplateConfigurationReaderInterface $templateReader,
        PagePartConfigurationReaderInterface $pagePartReader,
        PageTemplateConfigurationService $pageTemplateConfigurationService
    ) {
        parent::__construct();

        $this->page = $page;

        $this->em = $em;
        $this->request = $request;
        $this->pagePartAdminFactory = $pagePartAdminFactory;

        $this->pageTemplates = $templateReader->getPageTemplates($page);
        $this->pagePartAdminConfigurations = $pagePartReader->getPagePartAdminConfigurators($page);
        $this->pageTemplateConfiguration = $pageTemplateConfigurationService->findOrCreateFor($page);

        foreach ($this->getPageTemplate()->getRows() as $row) {
            foreach ($row->getRegions() as $region) {
                $this->processRegion($region);
            }
        }
    }

    /**
     * @param Region $region The region
     */
    private function processRegion($region)
    {
        if (\count($region->getChildren())) {
            foreach ($region->getChildren() as $child) {
                $this->processRegion($child);
            }
        } else {
            $this->loadWidgets($region);
        }
    }

    /**
     * @param Region $region The region
     */
    private function loadWidgets($region)
    {
        $pagePartAdminConfiguration = null;
        foreach ($this->pagePartAdminConfigurations as $ppac) {
            if ($ppac->getContext() == $region->getName()) {
                $pagePartAdminConfiguration = $ppac;
            }
        }

        if ($pagePartAdminConfiguration !== null) {
            $pagePartWidget = new PagePartWidget($this->page, $this->request, $this->em, $pagePartAdminConfiguration, $this->pagePartAdminFactory);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->widgets[$region->getName()] = $pagePartWidget;
        }
    }

    /**
     * @return PageTemplateInterface
     */
    public function getPageTemplate()
    {
        return $this->pageTemplates[$this->pageTemplateConfiguration->getPageTemplate()];
    }

    /**
     * @return PageTemplateInterface[]
     */
    public function getPageTemplates()
    {
        return $this->pageTemplates;
    }

    /**
     * @return PageInterface|HasPageTemplateInterface
     */
    public function getPage()
    {
        return $this->page;
    }

    /**
     * @param FormBuilderInterface $builder The form builder
     */
    public function buildForm(FormBuilderInterface $builder)
    {
        foreach ($this->widgets as $widget) {
            $widget->buildForm($builder);
        }
    }

    /**
     * @param Request $request
     */
    public function bindRequest(Request $request)
    {
        $configurationname = $request->get('pagetemplate_template');
        $this->pageTemplateConfiguration->setPageTemplate($configurationname);
        foreach ($this->widgets as $widget) {
            $widget->bindRequest($request);
        }
    }

    /**
     * @param EntityManager $em The entity manager
     */
    public function persist(EntityManager $em)
    {
        $em->persist($this->pageTemplateConfiguration);
        foreach ($this->widgets as $widget) {
            $widget->persist($em);
        }
    }

    /**
     * @param FormView $formView
     *
     * @return array
     */
    public function getFormErrors(FormView $formView)
    {
        $errors = array();

        foreach ($this->widgets as $widget) {
            $errors = array_merge($errors, $widget->getFormErrors($formView));
        }

        return $errors;
    }

    /**
     * @return string
     */
    public function getTemplate()
    {
        return '@KunstmaanPagePart/FormWidgets/PageTemplateWidget/widget.html.twig';
    }

    /**
     * @param string $name
     *
     * @return PagePartAdmin

     */
    public function getFormWidget($name)
    {
        if (\array_key_exists($name, $this->widgets)) {
            return $this->widgets[$name];
        }

        return null;
    }

    /**
     * @param Request $request
     *
     * @return array
     */
    public function getExtraParams(Request $request)
    {
        return [];
    }
}


1			<?php
2
3			namespace Kunstmaan\PagePartBundle\Helper\FormWidgets;
4
5			use Doctrine\ORM\EntityManager;
6			use Doctrine\ORM\EntityManagerInterface;
7			use Kunstmaan\AdminBundle\Helper\FormWidgets\FormWidget;
8			use Kunstmaan\NodeBundle\Entity\PageInterface;
9			use Kunstmaan\PagePartBundle\Entity\PageTemplateConfiguration;
10			use Kunstmaan\PagePartBundle\Helper\HasPageTemplateInterface;
11			use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdmin;
12			use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminConfiguratorInterface;
13			use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminFactory;
14			use Kunstmaan\PagePartBundle\PagePartConfigurationReader\PagePartConfigurationReaderInterface;
15			use Kunstmaan\PagePartBundle\PageTemplate\PageTemplateConfigurationReaderInterface;
16			use Kunstmaan\PagePartBundle\PageTemplate\PageTemplateConfigurationService;
17			use Kunstmaan\PagePartBundle\PageTemplate\PageTemplateInterface;
18			use Kunstmaan\PagePartBundle\PageTemplate\Region;
19			use Symfony\Component\Form\FormBuilderInterface;
20			use Symfony\Component\Form\FormView;
21			use Symfony\Component\HttpFoundation\Request;
22
23			/**
24			* PageTemplateWidget
25			*/
26			class PageTemplateWidget extends FormWidget
27			{
28			/**
29			* @var EntityManagerInterface
30			*/
31			private $em;
32
33			/**
34			* @var PagePartAdminFactory
35			*/
36			private $pagePartAdminFactory;
37
38			/**
39			* @var PageInterface
40			*/
41			private $page;
42
43			/**
44			* @var Request
45			*/
46			private $request;
47
48			/**
49			* @var PagePartWidget[]
50			*/
51			private $widgets = array();
52
53			/**
54			* @var PageTemplateInterface[]
55			*/
56			private $pageTemplates = array();
57
58			/**
59			* @var PagePartAdminConfiguratorInterface[]
60			*/
61			private $pagePartAdminConfigurations = array();
62
63			/**
64			* @var PageTemplateConfiguration
65			*/
66			protected $pageTemplateConfiguration;
67
68			/**
69			* @param HasPageTemplateInterface $page
70			* @param Request $request
71			* @param EntityManagerInterface $em
72			* @param PagePartAdminFactory $pagePartAdminFactory
73			* @param PageTemplateConfigurationReaderInterface $templateReader
74			* @param PagePartConfigurationReaderInterface $pagePartReader
75			* @param PageTemplateConfigurationService $pageTemplateConfigurationService
76			*/
77			public function __construct(
78			HasPageTemplateInterface $page,
79			Request $request,
			0 ignored issues – show Bug introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report You have injected the Request via parameter `$request`. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via `getCurrentRequest()`. Loading history...
80			EntityManagerInterface $em,
81			PagePartAdminFactory $pagePartAdminFactory,
82			PageTemplateConfigurationReaderInterface $templateReader,
83			PagePartConfigurationReaderInterface $pagePartReader,
84			PageTemplateConfigurationService $pageTemplateConfigurationService
85			) {
86			parent::__construct();
87
88			$this->page = $page;
			0 ignored issues – show Documentation Bug introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report It seems like `$page` of type `object<Kunstmaan\PagePar...sPageTemplateInterface>` is incompatible with the declared type `object<Kunstmaan\NodeBundle\Entity\PageInterface>` of property `$page`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
89			$this->em = $em;
90			$this->request = $request;
91			$this->pagePartAdminFactory = $pagePartAdminFactory;
92
93			$this->pageTemplates = $templateReader->getPageTemplates($page);
94			$this->pagePartAdminConfigurations = $pagePartReader->getPagePartAdminConfigurators($page);
95			$this->pageTemplateConfiguration = $pageTemplateConfigurationService->findOrCreateFor($page);
96
97			foreach ($this->getPageTemplate()->getRows() as $row) {
98			foreach ($row->getRegions() as $region) {
99			$this->processRegion($region);
100			}
101			}
102			}
103
104			/**
105			* @param Region $region The region
106			*/
107			private function processRegion($region)
108			{
109			if (\count($region->getChildren())) {
110			foreach ($region->getChildren() as $child) {
111			$this->processRegion($child);
112			}
113			} else {
114			$this->loadWidgets($region);
115			}
116			}
117
118			/**
119			* @param Region $region The region
120			*/
121			private function loadWidgets($region)
122			{
123			$pagePartAdminConfiguration = null;
124			foreach ($this->pagePartAdminConfigurations as $ppac) {
125			if ($ppac->getContext() == $region->getName()) {
126			$pagePartAdminConfiguration = $ppac;
127			}
128			}
129
130			if ($pagePartAdminConfiguration !== null) {
131			$pagePartWidget = new PagePartWidget($this->page, $this->request, $this->em, $pagePartAdminConfiguration, $this->pagePartAdminFactory);
			0 ignored issues – show Documentation introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report `$this->page` is of type `object<Kunstmaan\NodeBundle\Entity\PageInterface>`, but the function expects a `object<Kunstmaan\PagePar...\HasPagePartsInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
132			$this->widgets[$region->getName()] = $pagePartWidget;
133			}
134			}
135
136			/**
137			* @return PageTemplateInterface
138			*/
139			public function getPageTemplate()
140			{
141			return $this->pageTemplates[$this->pageTemplateConfiguration->getPageTemplate()];
142			}
143
144			/**
145			* @return PageTemplateInterface[]
146			*/
147			public function getPageTemplates()
148			{
149			return $this->pageTemplates;
150			}
151
152			/**
153			* @return PageInterface\|HasPageTemplateInterface
154			*/
155			public function getPage()
156			{
157			return $this->page;
158			}
159
160			/**
161			* @param FormBuilderInterface $builder The form builder
162			*/
163			public function buildForm(FormBuilderInterface $builder)
164			{
165			foreach ($this->widgets as $widget) {
166			$widget->buildForm($builder);
167			}
168			}
169
170			/**
171			* @param Request $request
172			*/
173			public function bindRequest(Request $request)
174			{
175			$configurationname = $request->get('pagetemplate_template');
176			$this->pageTemplateConfiguration->setPageTemplate($configurationname);
177			foreach ($this->widgets as $widget) {
178			$widget->bindRequest($request);
179			}
180			}
181
182			/**
183			* @param EntityManager $em The entity manager
184			*/
185			public function persist(EntityManager $em)
186			{
187			$em->persist($this->pageTemplateConfiguration);
188			foreach ($this->widgets as $widget) {
189			$widget->persist($em);
190			}
191			}
192
193			/**
194			* @param FormView $formView
195			*
196			* @return array
197			*/
198			public function getFormErrors(FormView $formView)
199			{
200			$errors = array();
201
202			foreach ($this->widgets as $widget) {
203			$errors = array_merge($errors, $widget->getFormErrors($formView));
204			}
205
206			return $errors;
207			}
208
209			/**
210			* @return string
211			*/
212			public function getTemplate()
213			{
214			return '@KunstmaanPagePart/FormWidgets/PageTemplateWidget/widget.html.twig';
215			}
216
217			/**
218			* @param string $name
219			*
220			* @return PagePartAdmin
			0 ignored issues – show Documentation introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Should the return type not be `PagePartWidget\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
221			*/
222			public function getFormWidget($name)
223			{
224			if (\array_key_exists($name, $this->widgets)) {
225			return $this->widgets[$name];
226			}
227
228			return null;
229			}
230
231			/**
232			* @param Request $request
233			*
234			* @return array
235			*/
236			public function getExtraParams(Request $request)
237			{
238			return [];
239			}
240			}
241

Kunstmaan / KunstmaanBundlesCMS

Push — master ( 6d6774...64f3ed )

PageTemplateWidget::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like