Kunstmaan\DashboardBundle\Controller\GoogleAnalyticsAJAXController

Complexity

Total Complexity

22

Size/Duplication

Total Lines	306
Duplicated Lines	7.84 %

Coupling/Cohesion

Components	1
Dependencies	14

Test Coverage

Coverage

0%

Importance

Changes

0

14 Methods

Rating	Name	Duplication	Size	Complexity
A	runUpdateAction()	0	13	1
A	getOverviewAction()	0	46	2
A	getAccountsAction()	0	12	2
A	saveAccountAction()	8	8	1
A	getPropertiesAction()	0	13	2
A	savePropertyAction()	8	8	1
A	getProfilesAction()	0	14	2
A	saveProfileAction()	8	8	1
A	saveConfigAction()	0	38	4
A	removeConfigAction()	0	13	1
A	getConfigAction()	0	15	2
A	addSegmentAction()	0	24	1
A	deleteSegmentAction()	0	9	1
A	editSegmentAction()	0	15	1

<?php

namespace Kunstmaan\DashboardBundle\Controller;

use Kunstmaan\AdminBundle\FlashMessages\FlashTypes;
use Kunstmaan\DashboardBundle\Command\GoogleAnalyticsDataCollectCommand;
use Kunstmaan\DashboardBundle\Entity\AnalyticsConfig;
use Kunstmaan\DashboardBundle\Entity\AnalyticsGoal;
use Kunstmaan\DashboardBundle\Entity\AnalyticsOverview;
use Kunstmaan\DashboardBundle\Entity\AnalyticsSegment;
use Kunstmaan\DashboardBundle\Repository\AnalyticsOverviewRepository;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Output\NullOutput;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;

class GoogleAnalyticsAJAXController extends Controller

The class Symfony\Bundle\FrameworkBundle\Controller\Controller has been deprecated with message: since Symfony 4.2, use "Symfony\Bundle\FrameworkBundle\Controller\AbstractController" instead.

{
    /**
     * @Route("/updateData", name="KunstmaanDashboardBundle_analytics_update")
     */
    public function runUpdateAction(Request $request)
    {
        $configId = $request->query->get('configId');
        $segmentId = $request->query->get('segmentId');

        $command = new GoogleAnalyticsDataCollectCommand();
        $command->setContainer($this->container);
        $input = new ArrayInput(array('--config' => $configId, '--segment' => $segmentId));
        $output = new NullOutput();
        $command->run($input, $output);

        return new JsonResponse(array(), 200, array('Content-Type' => 'application/json'));
    }

    /**
     * Return an ajax response with all data for an overview
     *
     * @Route("/getOverview/{id}", requirements={"id" = "\d+"}, name="KunstmaanDashboardBundle_analytics_overview_ajax")
     */
    public function getOverviewAction($id)
    {
        $em = $this->getDoctrine()->getManager();
        /** @var AnalyticsOverviewRepository $analyticsOverviewRepository */
        $analyticsOverviewRepository = $em->getRepository(AnalyticsOverview::class);
        $overview = $analyticsOverviewRepository->find($id);

        // goals data
        $goals = array();
        foreach ($overview->getActiveGoals() as $key => $goal) {
            /* @var AnalyticsGoal $goal */
            $goals[$key]['name'] = $goal->getName();
            $goals[$key]['visits'] = $goal->getVisits();
            $goals[$key]['id'] = $goal->getId();
            $goals[$key]['chartData'] = json_decode($goal->getChartData());
        }

        // overview data
        $overviewData = array(
            'id' => $overview->getId(),
            'chartData' => json_decode($overview->getChartData(), true),
            'chartDataMaxValue' => $overview->getChartDataMaxValue(),
            'title' => $overview->getTitle(),
            'timespan' => $overview->getTimespan(),
            'startOffset' => $overview->getStartOffset(),
            'sessions' => number_format($overview->getSessions()),
            'users' => number_format($overview->getUsers()),
            'pagesPerSession' => round($overview->getPagesPerSession(), 2),
            'avgSessionDuration' => $overview->getAvgSessionDuration(),
            'returningUsers' => number_format($overview->getReturningUsers()),
            'newUsers' => round($overview->getNewUsers(), 2),
            'pageViews' => number_format($overview->getPageViews()),
            'returningUsersPercentage' => $overview->getReturningUsersPercentage(),
            'newUsersPercentage' => $overview->getNewUsersPercentage(),
        );

        // put all data in the return array
        $return = array(
            'responseCode' => 200,
            'overview' => $overviewData,
            'goals' => $goals,
        );

        // return json response
        return new JsonResponse($return, 200, array('Content-Type' => 'application/json'));
    }

    /* =============================== ACCOUNT =============================== */

    /**
     * @Route("/accounts/", name="kunstmaan_dashboard_ajax_accounts")
     */
    public function getAccountsAction(Request $request)
    {
        $configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
        $configId = $request->query->get('configId');
        if ($configId) {
            $configHelper->init($configId);
        }

        $accounts = $configHelper->getAccounts();

        return new JsonResponse($accounts, 200, array('Content-Type' => 'application/json'));
    }

    /**
     * @Route("/account/save", name="kunstmaan_dashboard_ajax_account_save")
     */
    public function saveAccountAction(Request $request)

This method seems to be duplicated in your project.

    {
        $accountId = $request->query->get('id');
        $configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
        $configHelper->saveAccountId($accountId);

        return new JsonResponse();
    }

    /* =============================== PROPERTY =============================== */

    /**
     * @Route("/properties/", name="kunstmaan_dashboard_ajax_properties")
     */
    public function getPropertiesAction(Request $request)
    {
        $accountId = $request->query->get('accountId');
        $configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
        $configId = $request->query->get('configId');
        if ($configId) {
            $configHelper->init($configId);
        }

        $properties = $configHelper->getProperties($accountId);

        return new JsonResponse($properties, 200, array('Content-Type' => 'application/json'));
    }

    /**
     * @Route("/property/save", name="kunstmaan_dashboard_ajax_property_save")
     */
    public function savePropertyAction(Request $request)

This method seems to be duplicated in your project.

    {
        $propertyId = $request->query->get('id');
        $configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
        $configHelper->savePropertyId($propertyId);

        return new JsonResponse();
    }

    /* =============================== PROFILE =============================== */

    /**
     * @Route("/profiles/", name="kunstmaan_dashboard_ajax_profiles")
     */
    public function getProfilesAction(Request $request)
    {
        $accountId = $request->query->get('accountId');
        $propertyId = $request->query->get('propertyId');
        $configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
        $configId = $request->query->get('configId');
        if ($configId) {
            $configHelper->init($configId);
        }

        $profiles = $configHelper->getProfiles($accountId, $propertyId);

        return new JsonResponse($profiles, 200, array('Content-Type' => 'application/json'));
    }

    /**
     * @Route("/profile/save", name="kunstmaan_dashboard_ajax_profile_save")
     */
    public function saveProfileAction(Request $request)

This method seems to be duplicated in your project.

    {
        $propertyId = $request->query->get('id');
        $configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
        $configHelper->saveProfileId($propertyId);

        return new JsonResponse();
    }

    /* =============================== CONFIG =============================== */

    /**
     * @Route("/config/save", name="kunstmaan_dashboard_ajax_config_save")
     */
    public function saveConfigAction(Request $request)
    {
        // get params
        $configId = $request->query->get('configId');
        $accountId = $request->query->get('accountId');
        $propertyId = $request->query->get('propertyId');
        $profileId = $request->query->get('profileId');
        $disableGoals = $request->query->get('disableGoals');

        // edit the config
        $em = $this->getDoctrine()->getManager();
        $config = $em->getRepository(AnalyticsConfig::class)->find($configId);
        if ($accountId && $propertyId && $profileId) {
            $config->setAccountId($accountId);
            $config->setPropertyId($propertyId);
            $config->setProfileId($profileId);
        }

        $em->persist($config);

It seems like $config defined by $em->getRepository(\Kunstmaan\DashboardBundle\Entity\AnalyticsConfig::class)->find($configId) on line 199 can also be of type null; however, Doctrine\Persistence\ObjectManager::persist() does only seem to accept object, maybe add an additional type check?

        $em->flush();

        // set the config name
        $configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
        $configHelper->init($configId);
        $profile = $configHelper->getActiveProfile();
        $config->setName($profile['profileName']);
        $config->setDisableGoals($disableGoals);

        $em->persist($config);

It seems like $config defined by $em->getRepository(\Kunstmaan\DashboardBundle\Entity\AnalyticsConfig::class)->find($configId) on line 199 can also be of type null; however, Doctrine\Persistence\ObjectManager::persist() does only seem to accept object, maybe add an additional type check?

        $em->flush();

        $this->addFlash(
            FlashTypes::SUCCESS,
            $this->get('translator')->trans('kuma_admin.ga_ajax_controller.flash.success')
        );

        return new JsonResponse();
    }

    /**
     * @Route("/config/remove", name="kunstmaan_dashboard_ajax_config_remove")
     */
    public function removeConfigAction(Request $request)
    {
        // get params
        $configId = $request->query->get('configId');

        // edit the config
        $em = $this->getDoctrine()->getManager();
        $config = $em->getRepository(AnalyticsConfig::class)->find($configId);
        $em->remove($config);

It seems like $config defined by $em->getRepository(\Kunstmaan\DashboardBundle\Entity\AnalyticsConfig::class)->find($configId) on line 237 can also be of type null; however, Doctrine\Persistence\ObjectManager::remove() does only seem to accept object, maybe add an additional type check?

        $em->flush();

        return new JsonResponse();
    }

    /**
     * @Route("/config/get", name="kunstmaan_dashboard_ajax_config_get")
     */
    public function getConfigAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();
        $config = $em->getRepository(AnalyticsConfig::class)->findFirst();

It seems like you code against a concrete implementation and not the interface Doctrine\Persistence\ObjectRepository as the method findFirst() does only exist in the following implementations of said interface: Kunstmaan\DashboardBundle\Repository\AnalyticsConfigRepository.

        $accountId = $config->getAccountId();

        if (!$accountId) {
            return new JsonResponse();
        }

        $configHelper = $this->container->get('kunstmaan_dashboard.helper.google.analytics.config');
        $configHelper->getAccounts();
        $configHelper->getProperties();
        $configHelper->getProfiles();
    }

    /* =============================== SEGMENT =============================== */

    /**
     * @Route("/segment/add/", name="kunstmaan_dashboard_ajax_segment_add")
     */
    public function addSegmentAction(Request $request)
    {
        $configId = $request->query->get('configId');
        $em = $this->getDoctrine()->getManager();

        // create a new segment
        $segment = new AnalyticsSegment();
        $query = $request->query->get('query');
        $name = $request->query->get('name');
        $segment->setQuery($query);
        $segment->setName($name);

        // add the segment to the config
        $config = $em->getRepository(AnalyticsConfig::class)->find($configId);
        $segment->setConfig($config);

$config is of type object|null, but the function expects a integer.

        $segments = $config->getSegments();
        $segments[] = $segment;
        $config->setSegments($segments);

        $em->persist($config);

It seems like $config defined by $em->getRepository(\Kunstmaan\DashboardBundle\Entity\AnalyticsConfig::class)->find($configId) on line 281 can also be of type null; however, Doctrine\Persistence\ObjectManager::persist() does only seem to accept object, maybe add an additional type check?

        $em->flush();

        return new JsonResponse();
    }

    /**
     * @Route("/segment/delete", name="kunstmaan_dashboard_ajax_segment_delete")
     */
    public function deleteSegmentAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();

        $id = $request->query->get('id');
        $em->getRepository(AnalyticsSegment::class)->deleteSegment($id);

It seems like you code against a concrete implementation and not the interface Doctrine\Persistence\ObjectRepository as the method deleteSegment() does only exist in the following implementations of said interface: Kunstmaan\DashboardBundle\Repository\AnalyticsSegmentRepository.

        return new JsonResponse();
    }

    /**
     * @Route("/segment/edit", name="kunstmaan_dashboard_ajax_segment_edit")
     */
    public function editSegmentAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();

        $id = $request->query->get('id');
        $query = $request->query->get('query');
        $name = $request->query->get('name');
        $segment = $em->getRepository(AnalyticsSegment::class)->find($id);
        $segment->setName($name);
        $segment->setQuery($query);
        $em->persist($segment);

It seems like $segment defined by $em->getRepository(\Kunstmaan\DashboardBundle\Entity\AnalyticsSegment::class)->find($id) on line 316 can also be of type null; however, Doctrine\Persistence\ObjectManager::persist() does only seem to accept object, maybe add an additional type check?

        $em->flush();

        return new JsonResponse();
    }
}