SessionSecurityListenerTest - Code Metrics - Inspection of "Merge pull request #2662 from acrobat/replace-doct..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6d6774...64f3ed )

by Jeroen

created 2020-06-25 11:41 UTC

SessionSecurityListenerTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	78
Duplicated Lines	64.1 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	4
dl	50
loc	78
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	testOnKernelRequest()	25	25	1
A	testOnKernelResponse()	25	25	1
A	testInvalidateSessionWithNoIpSet()	0	23	1

How to fix Duplicated Code

<?php

namespace Kunstmaan\AdminBundle\Tests\EventListener;

use Kunstmaan\AdminBundle\EventListener\SessionSecurityListener;
use PHPUnit\Framework\TestCase;
use Psr\Log\LoggerInterface;
use Symfony\Component\HttpFoundation\HeaderBag;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\ServerBag;
use Symfony\Component\HttpFoundation\Session\Session;
use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
use Symfony\Component\HttpKernel\Event\GetResponseEvent;
use Symfony\Component\HttpKernel\HttpKernelInterface;

class SessionSecurityListenerTest extends TestCase
{
    public function testOnKernelRequest()

    {
        $logger = $this->createMock(LoggerInterface::class);
        $request = $this->createMock(Request::class);
        $request->server = $this->createMock(ServerBag::class);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $request->headers = $this->createMock(HeaderBag::class);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $event = $this->createMock(GetResponseEvent::class);
        $session = $this->createMock(Session::class);

        $event->expects($this->any())->method('getRequestType')->willReturn(HttpKernelInterface::MASTER_REQUEST);
        $event->expects($this->any())->method('getRequest')->willReturn($request);
        $request->expects($this->once())->method('hasSession')->willReturn(true);
        $request->expects($this->exactly(2))->method('getSession')->willReturn($session);
        $request->server->expects($this->any())->method('get')->will($this->onConsecutiveCalls('Session ip', 'kuma_ua'));
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $request->headers->expects($this->any())->method('get')->willReturn('kuma_ua');
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $session->expects($this->once())->method('isStarted')->willReturn(true);
        $session->expects($this->any())->method('has')->willReturn(true);

        $listener = new SessionSecurityListener(true, true, $logger);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $listener->onKernelRequest($event);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $event = $this->createMock(GetResponseEvent::class);
        $listener->onKernelRequest($event);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testOnKernelResponse()

    {
        $logger = $this->createMock(LoggerInterface::class);
        $request = $this->createMock(Request::class);
        $request->server = $this->createMock(ServerBag::class);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $request->headers = $this->createMock(HeaderBag::class);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $event = $this->createMock(FilterResponseEvent::class);
        $session = $this->createMock(Session::class);

        $event->expects($this->any())->method('getRequestType')->willReturn(HttpKernelInterface::MASTER_REQUEST);
        $event->expects($this->any())->method('getRequest')->willReturn($request);
        $request->expects($this->once())->method('hasSession')->willReturn(true);
        $request->expects($this->exactly(2))->method('getSession')->willReturn($session);
        $request->server->expects($this->any())->method('get')->will($this->onConsecutiveCalls('Session ip', 'kuma_ua'));
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $request->headers->expects($this->any())->method('get')->willReturn('kuma_ua');
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $session->expects($this->once())->method('isStarted')->willReturn(true);
        $session->expects($this->exactly(2))->method('has')->willReturn(false);

        $listener = new SessionSecurityListener(true, true, $logger);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $listener->onKernelResponse($event);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $event = $this->createMock(FilterResponseEvent::class);
        $listener->onKernelResponse($event);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testInvalidateSessionWithNoIpSet()
    {
        $logger = $this->createMock(LoggerInterface::class);
        $request = $this->createMock(Request::class);
        $request->server = $this->createMock(ServerBag::class);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $request->headers = $this->createMock(HeaderBag::class);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $event = $this->createMock(FilterResponseEvent::class);
        $session = $this->createMock(Session::class);

        $event->expects($this->any())->method('getRequestType')->willReturn(HttpKernelInterface::MASTER_REQUEST);
        $event->expects($this->any())->method('getRequest')->willReturn($request);
        $request->expects($this->once())->method('hasSession')->willReturn(true);
        $request->expects($this->exactly(2))->method('getSession')->willReturn($session);
        $request->expects($this->once())->method('getClientIp')->willReturn('95.154.243.5');
        $request->server->expects($this->any())->method('get')->willReturn('');
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $request->headers->expects($this->any())->method('get')->willReturn('kuma_ua');
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $session->expects($this->once())->method('isStarted')->willReturn(true);
        $session->expects($this->exactly(2))->method('has')->willReturn(false);

        $listener = new SessionSecurityListener(true, true, $logger);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $listener->onKernelResponse($event);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


Push — master ( 6d6774...64f3ed )

SessionSecurityListenerTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace Kunstmaan\AdminBundle\Tests\EventListener;
4
5		use Kunstmaan\AdminBundle\EventListener\SessionSecurityListener;
6		use PHPUnit\Framework\TestCase;
7		use Psr\Log\LoggerInterface;
8		use Symfony\Component\HttpFoundation\HeaderBag;
9		use Symfony\Component\HttpFoundation\Request;
10		use Symfony\Component\HttpFoundation\ServerBag;
11		use Symfony\Component\HttpFoundation\Session\Session;
12		use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
13		use Symfony\Component\HttpKernel\Event\GetResponseEvent;
14		use Symfony\Component\HttpKernel\HttpKernelInterface;
15
16		class SessionSecurityListenerTest extends TestCase
17		{
18	View Code Duplication	public function testOnKernelRequest()
		0 ignored issues – show Duplication introduced 2018-04-18 14:49 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19		{
20		$logger = $this->createMock(LoggerInterface::class);
21		$request = $this->createMock(Request::class);
22		$request->server = $this->createMock(ServerBag::class);
		0 ignored issues – show Bug introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Accessing `server` on the interface `PHPUnit\Framework\MockObject\MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
23		$request->headers = $this->createMock(HeaderBag::class);
		0 ignored issues – show Bug introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Accessing `headers` on the interface `PHPUnit\Framework\MockObject\MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
24
25		$event = $this->createMock(GetResponseEvent::class);
26		$session = $this->createMock(Session::class);
27
28		$event->expects($this->any())->method('getRequestType')->willReturn(HttpKernelInterface::MASTER_REQUEST);
29		$event->expects($this->any())->method('getRequest')->willReturn($request);
30		$request->expects($this->once())->method('hasSession')->willReturn(true);
31		$request->expects($this->exactly(2))->method('getSession')->willReturn($session);
32		$request->server->expects($this->any())->method('get')->will($this->onConsecutiveCalls('Session ip', 'kuma_ua'));
		0 ignored issues – show Bug introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Accessing `server` on the interface `PHPUnit\Framework\MockObject\MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
33		$request->headers->expects($this->any())->method('get')->willReturn('kuma_ua');
		0 ignored issues – show Bug introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Accessing `headers` on the interface `PHPUnit\Framework\MockObject\MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
34		$session->expects($this->once())->method('isStarted')->willReturn(true);
35		$session->expects($this->any())->method('has')->willReturn(true);

Kunstmaan / KunstmaanBundlesCMS

Push — master ( 6d6774...64f3ed )

SessionSecurityListenerTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like