DataCollectorTranslator - Code Metrics - Inspection of "[AllBundles] Allow next majors of doctrine-bundle..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2775)

by Jeroen

created 2020-10-02 06:29 UTC

DataCollectorTranslator A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	10
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	1
lcom	0
cbo	1
dl	0
loc	10
ccs	0
cts	4
cp	0
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1

<?php

namespace Kunstmaan\TranslatorBundle\Toolbar;

use Symfony\Component\Translation\TranslatorInterface;
use Symfony\Component\Translation\DataCollectorTranslator as BaseDataCollectorTranslator;

/**
 * Class DataCollectorTranslator
 */
class DataCollectorTranslator extends BaseDataCollectorTranslator
{
    /**
     * @param TranslatorInterface $translator The translator must implement TranslatorBagInterface
     */
    public function __construct(TranslatorInterface $translator)
    {
        parent::__construct($translator);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			namespace Kunstmaan\TranslatorBundle\Toolbar;
4
5			use Symfony\Component\Translation\TranslatorInterface;
6			use Symfony\Component\Translation\DataCollectorTranslator as BaseDataCollectorTranslator;
7
8			/**
9			* Class DataCollectorTranslator
10			*/
11			class DataCollectorTranslator extends BaseDataCollectorTranslator
12			{
13			/**
14			* @param TranslatorInterface $translator The translator must implement TranslatorBagInterface
15			*/
16			public function __construct(TranslatorInterface $translator)
17			{
18			parent::__construct($translator);
			0 ignored issues – show Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report `$translator` is of type `object<Symfony\Component...on\TranslatorInterface>`, but the function expects a `object<Symfony\Contracts...on\TranslatorInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
19			}
20			}
21

Kunstmaan / KunstmaanBundlesCMS

Pull Request — master (#2775)

DataCollectorTranslator A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

Duplication Side-by-Side

Filter issues like