Kunstmaan\ArticleBundle\Tests\AdminList\AbstractArticlePageAdminListConfiguratorTest

Complexity

Total Complexity

7

Size/Duplication

Total Lines	165
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	testGetQueryBuilder()	0	28	1
A	testEntityClassName()	0	25	1
A	testGetOverViewPages()	0	18	1
A	setUp()	0	20	1
A	testGetters()	0	7	1
A	testBuildFields()	0	7	1
A	testGetUrls()	0	28	1

<?php

namespace Kunstmaan\ArticleBundle\Tests\AdminList;

use Doctrine\ORM\EntityManager;
use Doctrine\ORM\EntityRepository;
use Doctrine\ORM\QueryBuilder;
use Kunstmaan\AdminBundle\Helper\Security\Acl\AclHelper;
use Kunstmaan\ArticleBundle\AdminList\AbstractArticlePageAdminListConfigurator;
use Kunstmaan\NodeBundle\Entity\Node;
use Kunstmaan\NodeBundle\Entity\NodeTranslation;
use Kunstmaan\NodeBundle\Helper\NodeMenu;
use Kunstmaan\NodeBundle\Helper\NodeMenuItem;
use PHPUnit_Framework_TestCase;
use ReflectionClass;

class Configurator extends AbstractArticlePageAdminListConfigurator
{
    /** @var EntityRepository */
    private $repo;

    public function __construct(EntityManager $em, AclHelper $aclHelper, $locale, $permission, $repo)
    {
        parent::__construct($em, $aclHelper, $locale, $permission);
        $this->repo = $repo;
    }

    /**
     * @return bool

Should the return type not be EntityRepository?

     */
    public function getOverviewPageRepository()
    {
        return $this->repo;
    }
}

/**
 * Class AbstractArticlePageAdminListConfiguratorTest
 */
class AbstractArticlePageAdminListConfiguratorTest extends PHPUnit_Framework_TestCase

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    /**
     * @var AbstractArticlePageAdminListConfigurator
     */
    protected $object;

    /**
     * @var EntityManager
     */
    protected $em;

    /**
     * Sets up the fixture, for example, opens a network connection.
     * This method is called before a test is executed.
     */
    protected function setUp()
    {
        $em = $this->createMock(EntityManager::class);
        $em->expects($this->any())
            ->method($this->anything())
            ->willReturn($em);

        $acl = $this->createMock(AclHelper::class);

        $repo = $this->createMock(EntityRepository::class);
        $repo->expects($this->any())
            ->method($this->anything())
            ->willReturn([['fake' => 'array']]);

        $this->em = $em;

It seems like $em of type object<PHPUnit_Framework_MockObject_MockObject> is incompatible with the declared type object<Doctrine\ORM\EntityManager> of property $em.

        /* @var EntityManager $em */
        /* @var AclHelper $acl */
        $this->object = new Configurator($em, $acl, 'nl', 'admin', $repo);
    }

    public function testGetters()
    {
        $this->assertEquals('KunstmaanArticleBundle', $this->object->getBundleName());
        $this->assertEquals('AbstractArticlePage', $this->object->getEntityName());
        $this->assertEquals('KunstmaanArticleBundle:AbstractArticlePageAdminList:list.html.twig', $this->object->getListTemplate());
        $this->assertEquals('KunstmaanArticleBundle:AbstractArticlePage', $this->object->getRepositoryName());
    }

    public function testBuildFields()
    {
        $this->object->buildFields();
        $this->object->buildFilters();
        $fields = $this->object->getFields();
        $this->assertCount(4, $fields);
    }

    public function testGetUrls()
    {
        $node = new Node();
        $node->setId(1314);
        $nodeTranslation = new NodeTranslation();
        /** @var NodeMenu $menu */
        $menu = $this->createMock(NodeMenu::class);
        $item = new NodeMenuItem($node, $nodeTranslation, false, $menu);

        $url = $this->object->getEditUrlFor($item);

        $this->assertCount(2, $url);
        $this->assertArrayHasKey('path', $url);
        $this->assertArrayHasKey('params', $url);
        $this->assertEquals('KunstmaanNodeBundle_nodes_edit', $url['path']);
        $this->assertCount(1, $url['params']);
        $this->assertEquals(1314, $url['params']['id']);
        $url = $this->object->getEditUrlFor($item);

$url is not used, you could remove the assignment.

        $url = $this->object->getDeleteUrlFor($item);

        $this->assertCount(2, $url);
        $this->assertArrayHasKey('path', $url);
        $this->assertArrayHasKey('params', $url);
        $this->assertEquals('KunstmaanNodeBundle_nodes_delete', $url['path']);
        $this->assertCount(1, $url['params']);
        $this->assertEquals(1314, $url['params']['id']);
    }

    /**
     * @throws \ReflectionException
     */
    public function testGetQueryBuilder()
    {
        $em = $this->createMock(EntityManager::class);
        $qb = $this->createMock(QueryBuilder::class);
        $em->expects($this->any())
            ->method('createQueryBuilder')
            ->willReturn($qb);

        $em->expects($this->any())
            ->method('getRepository')
            ->willReturn($em);

        $this->em = $em;

It seems like $em of type object<PHPUnit_Framework_MockObject_MockObject> is incompatible with the declared type object<Doctrine\ORM\EntityManager> of property $em.

        $mirror = new ReflectionClass(Configurator::class);
        $method = $mirror->getMethod('getQueryBuilder');
        $method->setAccessible(true);

        $mirror = new ReflectionClass(Configurator::class);
        $prop = $mirror->getProperty('em');
        $prop->setAccessible(true);
        $prop->setValue($this->object, $em);

        /* @var QueryBuilder $qb */
        $this->object->adaptQueryBuilder($qb);
        $qb = $method->invoke($this->object);
        $this->assertInstanceOf(QueryBuilder::class, $qb);
    }

    /**
     * @throws \ReflectionException
     */
    public function testEntityClassName()
    {
        $em = $this->createMock(EntityManager::class);
        $repo = $this->createMock(EntityRepository::class);

        $em->expects($this->any())
            ->method('getRepository')
            ->willReturn($repo);

        $repo->expects($this->any())
            ->method('getClassName')
            ->willReturn(Configurator::class);

        $this->em = $em;

It seems like $em of type object<PHPUnit_Framework_MockObject_MockObject> is incompatible with the declared type object<Doctrine\ORM\EntityManager> of property $em.

        $mirror = new ReflectionClass(Configurator::class);
        $method = $mirror->getMethod('getQueryBuilder');
        $method->setAccessible(true);

        $mirror = new ReflectionClass(Configurator::class);
        $prop = $mirror->getProperty('em');
        $prop->setAccessible(true);
        $prop->setValue($this->object, $em);
        $this->assertEquals(Configurator::class, $this->object->getEntityClassName());
    }

    /**
     * @throws \ReflectionException
     */
    public function testGetOverViewPages()
    {
        $this->assertCount(1, $this->object->getOverviewPages());
        $this->assertCount(1, $this->object->getOverviewPage());

        $mirror = new ReflectionClass(Configurator::class);
        $prop = $mirror->getProperty('repo');
        $prop->setAccessible(true);

        $repo = $this->createMock(EntityRepository::class);
        $repo->expects($this->any())
            ->method($this->anything())
            ->willReturn([]);

        $prop->setValue($this->object, $repo);

        $this->assertNull($this->object->getOverviewPage());
    }
}