Kunstmaan\AdminBundle\Toolbar\BundleVersionDataCollector

Complexity

Total Complexity

10

Size/Duplication

Total Lines	73
Duplicated Lines	9.59 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	7	14	2
A	getAccessRoles()	0	4	1
A	collectData()	0	10	1
A	collect()	0	8	2
A	getTemplateData()	0	4	1
A	getName()	0	4	1
A	isEnabled()	0	4	1
A	reset()	0	4	1

<?php

namespace Kunstmaan\AdminBundle\Toolbar;

use Doctrine\Common\Cache\Cache;
use Kunstmaan\AdminBundle\Helper\Toolbar\AbstractDataCollector;
use Kunstmaan\AdminBundle\Helper\VersionCheck\VersionChecker;
use Monolog\Logger;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

class BundleVersionDataCollector extends AbstractDataCollector
{
    /** @var VersionChecker */
    private $versionChecker;

    /** @var Cache */
    private $cache;

    public function __construct(VersionChecker $versionChecker, /*Logger $logger,*/ /* Cache */ $cache)
    {
        $this->versionChecker = $versionChecker;

        if (func_num_args() > 2) {

This code seems to be duplicated across your project.

            @trigger_error(sprintf('Passing the "logger" service as the second argument in "%s" is deprecated in KunstmaanAdminBundle 5.1 and will be removed in KunstmaanAdminBundle 6.0. Remove the "logger" argument from your service definition.', __METHOD__), E_USER_DEPRECATED);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            $this->cache = func_get_arg(2);

            return;
        }

        $this->cache = $cache;
    }

    public function getAccessRoles()
    {
        return ['ROLE_SUPER_ADMIN'];
    }

    public function collectData()
    {
        $this->versionChecker->periodicallyCheck();

        $data = $this->cache->fetch('version_check');

        return [
            'data' => $data
        ];
    }

    public function collect(Request $request, Response $response, \Exception $exception = null)
    {
        if (!$this->isEnabled()) {
            $this->data = [];
        } else {
            $this->data = $this->collectData();
        }
    }

    /**
     * Gets the data for template
     *
     * @return array The request events
     */
    public function getTemplateData()
    {
        return $this->data;
    }

    public function getName()
    {
        return 'kuma_bundle_versions';
    }

    public function isEnabled()
    {
        return $this->versionChecker->isEnabled();
    }

    public function reset()
    {
        $this->data = [];
    }
}