URLChooserFormSubscriber::postSetData() - Code Metrics - Inspection of "Merge branch '5.2'" - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4c839e...4fda94 )

by Ruud

created 2019-04-10 10:11 UTC

URLChooserFormSubscriber::postSetData() A

↳ Parent: URLChooserFormSubscriber

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	2
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	2

<?php

namespace Kunstmaan\NodeBundle\Form\EventListener;

use Kunstmaan\NodeBundle\Form\Type\URLChooserType;
use Kunstmaan\NodeBundle\Validation\URLValidator;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Symfony\Component\Form\Extension\Core\Type\TextType;
use Symfony\Component\Form\FormEvent;
use Symfony\Component\Form\FormEvents;
use Symfony\Component\Validator\Constraints\Email;
use Symfony\Component\Validator\Constraints\Url;

class URLChooserFormSubscriber implements EventSubscriberInterface
{
    use URLValidator;

    public static function getSubscribedEvents()
    {
        return [
            FormEvents::POST_SET_DATA => 'postSetData',
            FormEvents::PRE_SUBMIT => 'preSubmit',
        ];
    }

    /**
     * When opening the form for the first time, check the type of URL and set the according fields.
     *
     * @param FormEvent $event
     */
    public function postSetData(FormEvent $event)
    {
        $this->formModifier($event);
    }

    public function preSubmit(FormEvent $event)
    {
        $this->formModifier($event);
    }

    private function formModifier(FormEvent $event)
    {
        $form = $event->getForm();
        $data = $form->getData();

        $constraints = [];
        $attributes['class'] = 'js-change-urlchooser';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        if (!empty($data) && $form->has('link_type')) {
            // Check if e-mail address
            if ($this->isEmailAddress($data)) {
                $form->get('link_type')->setData(URLChooserType::EMAIL);
                $constraints[] = new Email();
            } // Check if internal link
            elseif ($this->isInternalLink($data) || $this->isInternalMediaLink($data)) {
                $form->get('link_type')->setData(URLChooserType::INTERNAL);
                $attributes['choose_url'] = true;
            } // Else, it's an external link
            else {
                $form->get('link_type')->setData(URLChooserType::EXTERNAL);
                $constraints[] = new Url();
            }
        } else {
            $choices = $form->get('link_type')->getConfig()->getOption('choices');
            $firstOption = array_shift($choices);

            switch ($firstOption) {

                case URLChooserType::INTERNAL:
                    $attributes['choose_url'] = true;

                    break;
                case URLChooserType::EXTERNAL:
                    $attributes['placeholder'] = 'https://';
                    $constraints[] = new Url();

                    break;
                case URLChooserType::EMAIL:
                    $constraints[] = new Email();

                    break;
            }

            $form->get('link_type')->setData($firstOption);
        }

        $form->add(
            'link_url',
            TextType::class,
            [
                'label' => 'URL',
                'required' => true,
                'attr' => $attributes,
                'constraints' => $constraints,
                'error_bubbling' => true,
            ]
        );
    }
}


1		<?php
2
3		namespace Kunstmaan\NodeBundle\Form\EventListener;
4
5		use Kunstmaan\NodeBundle\Form\Type\URLChooserType;
6		use Kunstmaan\NodeBundle\Validation\URLValidator;
7		use Symfony\Component\EventDispatcher\EventSubscriberInterface;
8		use Symfony\Component\Form\Extension\Core\Type\TextType;
9		use Symfony\Component\Form\FormEvent;
10		use Symfony\Component\Form\FormEvents;
11		use Symfony\Component\Validator\Constraints\Email;
12		use Symfony\Component\Validator\Constraints\Url;
13
14		class URLChooserFormSubscriber implements EventSubscriberInterface
15		{
16		use URLValidator;
17
18		public static function getSubscribedEvents()
19		{
20		return [
21		FormEvents::POST_SET_DATA => 'postSetData',
22		FormEvents::PRE_SUBMIT => 'preSubmit',
23		];
24		}
25
26		/**
27		* When opening the form for the first time, check the type of URL and set the according fields.
28		*
29		* @param FormEvent $event
30		*/
31		public function postSetData(FormEvent $event)
32		{
33		$this->formModifier($event);
34		}
35
36		public function preSubmit(FormEvent $event)
37		{
38		$this->formModifier($event);
39		}
40
41		private function formModifier(FormEvent $event)
42		{
43		$form = $event->getForm();
44		$data = $form->getData();
45
46		$constraints = [];
47		$attributes['class'] = 'js-change-urlchooser';
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report `$attributes` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$attributes = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
48
49		if (!empty($data) && $form->has('link_type')) {
50		// Check if e-mail address
51		if ($this->isEmailAddress($data)) {
52		$form->get('link_type')->setData(URLChooserType::EMAIL);
53		$constraints[] = new Email();
54		} // Check if internal link
55		elseif ($this->isInternalLink($data) \|\| $this->isInternalMediaLink($data)) {
56		$form->get('link_type')->setData(URLChooserType::INTERNAL);
57		$attributes['choose_url'] = true;
58		} // Else, it's an external link
59		else {
60		$form->get('link_type')->setData(URLChooserType::EXTERNAL);
61		$constraints[] = new Url();
62		}
63		} else {
64		$choices = $form->get('link_type')->getConfig()->getOption('choices');
65		$firstOption = array_shift($choices);
66
67	View Code Duplication	switch ($firstOption) {
		0 ignored issues – show Duplication introduced 2018-04-18 14:49 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
68		case URLChooserType::INTERNAL:
69		$attributes['choose_url'] = true;
70
71		break;
72		case URLChooserType::EXTERNAL:
73		$attributes['placeholder'] = 'https://';
74		$constraints[] = new Url();
75
76		break;
77		case URLChooserType::EMAIL:
78		$constraints[] = new Email();
79
80		break;
81		}
82
83		$form->get('link_type')->setData($firstOption);
84		}
85
86		$form->add(
87		'link_url',
88		TextType::class,
89		[
90		'label' => 'URL',
91		'required' => true,
92		'attr' => $attributes,
93		'constraints' => $constraints,
94		'error_bubbling' => true,
95		]
96		);
97		}
98		}
99

Kunstmaan / KunstmaanBundlesCMS

Push — master ( 4c839e...4fda94 )

URLChooserFormSubscriber::postSetData() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like