Kunstmaan\NodeBundle\Form\EventListener\URLChooserLinkTypeSubscriber

Complexity

Total Complexity

6

Size/Duplication

Total Lines	58
Duplicated Lines	25.86 %

Coupling/Cohesion

Components	0
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getSubscribedEvents()	0	6	1
B	postSubmit()	15	39	5

<?php

namespace Kunstmaan\NodeBundle\Form\EventListener;

use Kunstmaan\NodeBundle\Form\Type\URLChooserType;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Symfony\Component\Form\Extension\Core\Type\TextType;
use Symfony\Component\Form\FormEvent;
use Symfony\Component\Form\FormEvents;
use Symfony\Component\Validator\Constraints\Email;
use Symfony\Component\Validator\Constraints\Url;

/**
 * Class URLChooserLinkTypeSubscriber
 */
class URLChooserLinkTypeSubscriber implements EventSubscriberInterface
{
    /**
     * @return array

Consider making the return type a bit more specific; maybe use array<*,string>.

     */
    public static function getSubscribedEvents()
    {
        return array(
            FormEvents::POST_SUBMIT => 'postSubmit',
        );
    }

    /**
     * When changing the link type, the form get's submitted with an ajax callback in the url_chooser.js;
     * We add the URL field only as an URL Chooser if it's an external link.
     *
     * @param FormEvent $event
     */
    public function postSubmit(FormEvent $event)
    {
        // Suppress validation
        $event->stopPropagation();

        $constraints = [];
        $attributes['class'] = 'js-change-urlchooser';

$attributes was never initialized. Although not strictly required by PHP, it is generally a good practice to add $attributes = array(); before regardless.

        $form = $event->getForm()->getParent();
        $linkType = $event->getData();

        if ($linkType) {
            $form->remove('link_url');

            switch ($linkType) {

This code seems to be duplicated across your project.

                case URLChooserType::INTERNAL:
                    $attributes['choose_url'] = true;

                    break;
                case URLChooserType::EXTERNAL:
                    $attributes['placeholder'] = 'https://';
                    $constraints[] = new Url();

                    break;
                case URLChooserType::EMAIL:
                    $constraints[] = new Email();

                    break;
            }

            $form->add('link_url', TextType::class, array(
                'label' => 'URL',
                'required' => true,
                'attr' => $attributes,
                'constraints' => $constraints,
                'error_bubbling' => true,
            ));
        }
    }
}