ConsoleCompilerPass::process() - Code Metrics - Inspection of "[NodeBundle] Add missing upgrade note for PR #2073..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — l10n_master ( ff9163...a02a58 )

by Ruud

created 2018-08-28 12:00 UTC

ConsoleCompilerPass::process() A

↳ Parent: ConsoleCompilerPass

Complexity

Conditions	5
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
nc	3
nop	1
dl	0
loc	28
rs	9.1608
c	0
b	0
f	0

<?php

namespace Kunstmaan\AdminBundle\DependencyInjection\Compiler;

use Kunstmaan\AdminBundle\EventListener\ConsoleExceptionListener;
use Kunstmaan\AdminBundle\EventListener\ConsoleExceptionSubscriber;
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;

/**
 * Class ConsoleCompilerPass.
 */
final class ConsoleCompilerPass implements CompilerPassInterface
{
    /**
     * @param ContainerBuilder $container
     */
    public function process(ContainerBuilder $container)
    {
        // if the old listener is no longer in use
        if (!$container->hasDefinition('kunstmaan_admin.consolelogger.listener')) {
            return;
        }

        $definition = $container->getDefinition('kunstmaan_admin.consolelogger.listener');

        // if the default setup is in use, the subscriber / listener take care of correctly handling the errors
        if (
            $container->hasParameter('kunstmaan_admin.consoleexception.class') &&
            ConsoleExceptionListener::class === $container->getParameter('kunstmaan_admin.consoleexception.class') &&
            '%kunstmaan_admin.consoleexception.class%' === $definition->getClass()
        ) {
            return;
        }

        // if the listener has been overwritten in any way, a deprecation warning is needed
        @trigger_error(
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            sprintf(
                'The "%s" is deprecated and replaced by "%s" since KunstmaanAdminBundle 5.1 and will be removed in KunstmaanAdminBundle 6.0.',
                ConsoleExceptionListener::class,
                ConsoleExceptionSubscriber::class
            ),
            E_USER_DEPRECATED
        );
    }
}


1			<?php
2
3			namespace Kunstmaan\AdminBundle\DependencyInjection\Compiler;
4
5			use Kunstmaan\AdminBundle\EventListener\ConsoleExceptionListener;
6			use Kunstmaan\AdminBundle\EventListener\ConsoleExceptionSubscriber;
7			use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
8			use Symfony\Component\DependencyInjection\ContainerBuilder;
9
10			/**
11			* Class ConsoleCompilerPass.
12			*/
13			final class ConsoleCompilerPass implements CompilerPassInterface
14			{
15			/**
16			* @param ContainerBuilder $container
17			*/
18			public function process(ContainerBuilder $container)
19			{
20			// if the old listener is no longer in use
21			if (!$container->hasDefinition('kunstmaan_admin.consolelogger.listener')) {
22			return;
23			}
24
25			$definition = $container->getDefinition('kunstmaan_admin.consolelogger.listener');
26
27			// if the default setup is in use, the subscriber / listener take care of correctly handling the errors
28			if (
29			$container->hasParameter('kunstmaan_admin.consoleexception.class') &&
30			ConsoleExceptionListener::class === $container->getParameter('kunstmaan_admin.consoleexception.class') &&
31			'%kunstmaan_admin.consoleexception.class%' === $definition->getClass()
32			) {
33			return;
34			}
35
36			// if the listener has been overwritten in any way, a deprecation warning is needed
37			@trigger_error(
			0 ignored issues – show Security Best Practice introduced 2018-06-15 08:15 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
38			sprintf(
39			'The "%s" is deprecated and replaced by "%s" since KunstmaanAdminBundle 5.1 and will be removed in KunstmaanAdminBundle 6.0.',
40			ConsoleExceptionListener::class,
41			ConsoleExceptionSubscriber::class
42			),
43			E_USER_DEPRECATED
44			);
45			}
46			}
47

Kunstmaan / KunstmaanBundlesCMS

Push — l10n_master ( ff9163...a02a58 )

ConsoleCompilerPass::process() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like