AclVoterTest - Code Metrics - Inspection of "Merge pull request #2817 from OskarStark/refactor-..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 5.6 ( c5fe0b...561087 )

by Jeroen

created 2020-11-05 17:54 UTC

AclVoterTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	12
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

Metric	Value
wmc	1
lcom	0
cbo	2
dl	0
loc	12
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	testCanConstruct()	0	9	1

<?php

namespace Kunstmaan\AdminBundle\Tests\Helper\Security\Acl\Voter;

use Kunstmaan\AdminBundle\Helper\Security\Acl\Permission\PermissionMapInterface;
use Kunstmaan\AdminBundle\Helper\Security\Acl\Voter\AclVoter;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Security\Acl\Model\AclProviderInterface;
use Symfony\Component\Security\Acl\Model\ObjectIdentityRetrievalStrategyInterface;
use Symfony\Component\Security\Acl\Model\SecurityIdentityRetrievalStrategyInterface;

class AclVoterTest extends TestCase
{
    public function testCanConstruct()
    {
        $provider = $this->createMock(AclProviderInterface::class);
        $oid = $this->createMock(ObjectIdentityRetrievalStrategyInterface::class);
        $sid = $this->createMock(SecurityIdentityRetrievalStrategyInterface::class);
        $map = $this->createMock(PermissionMapInterface::class);
        $acl = new AclVoter($provider, $oid, $sid, $map);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertInstanceOf(AclVoter::class, $acl);
    }
}


1			<?php
2
3			namespace Kunstmaan\AdminBundle\Tests\Helper\Security\Acl\Voter;
4
5			use Kunstmaan\AdminBundle\Helper\Security\Acl\Permission\PermissionMapInterface;
6			use Kunstmaan\AdminBundle\Helper\Security\Acl\Voter\AclVoter;
7			use PHPUnit\Framework\TestCase;
8			use Symfony\Component\Security\Acl\Model\AclProviderInterface;
9			use Symfony\Component\Security\Acl\Model\ObjectIdentityRetrievalStrategyInterface;
10			use Symfony\Component\Security\Acl\Model\SecurityIdentityRetrievalStrategyInterface;
11
12			class AclVoterTest extends TestCase
13			{
14			public function testCanConstruct()
15			{
16			$provider = $this->createMock(AclProviderInterface::class);
17			$oid = $this->createMock(ObjectIdentityRetrievalStrategyInterface::class);
18			$sid = $this->createMock(SecurityIdentityRetrievalStrategyInterface::class);
19			$map = $this->createMock(PermissionMapInterface::class);
20			$acl = new AclVoter($provider, $oid, $sid, $map);
			0 ignored issues – show Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report `$provider` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...l\AclProviderInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report `$oid` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...ievalStrategyInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report `$sid` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...ievalStrategyInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report `$map` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...PermissionMapInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
21			$this->assertInstanceOf(AclVoter::class, $acl);
22			}
23			}
24

Kunstmaan / KunstmaanBundlesCMS

Push — 5.6 ( c5fe0b...561087 )

AclVoterTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like