Issues in DataCollectorTranslator.php - All Issues - Inspection of "[MediaBundle] Code improvement found by static cod..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aba493...5356ed )

by Ruud

created 2019-06-11 15:20 UTC

Toolbar/DataCollectorTranslator.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Kodeus 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\TranslatorBundle\Toolbar;

use Symfony\Component\Translation\TranslatorInterface;
use Symfony\Component\Translation\DataCollectorTranslator as BaseDataCollectorTranslator;

/**
 * Class DataCollectorTranslator
 */
class DataCollectorTranslator extends BaseDataCollectorTranslator
{
    /**
     * @param TranslatorInterface $translator The translator must implement TranslatorBagInterface
     */
    public function __construct(TranslatorInterface $translator)
    {
        parent::__construct($translator);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1		<?php
2
3		namespace Kunstmaan\TranslatorBundle\Toolbar;
4
5		use Symfony\Component\Translation\TranslatorInterface;
6		use Symfony\Component\Translation\DataCollectorTranslator as BaseDataCollectorTranslator;
7
8		/**
9		* Class DataCollectorTranslator
10		*/
11		class DataCollectorTranslator extends BaseDataCollectorTranslator
12		{
13		/**
14		* @param TranslatorInterface $translator The translator must implement TranslatorBagInterface
15		*/
16	3	public function __construct(TranslatorInterface $translator)
17		{
18	3	parent::__construct($translator);
		0 ignored issues – show Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$translator` is of type `object<Symfony\Component...on\TranslatorInterface>`, but the function expects a `object<Symfony\Contracts...on\TranslatorInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
19	3	}
20		}
21

Kunstmaan / KunstmaanBundlesCMS

Push — master ( aba493...5356ed )

Toolbar/DataCollectorTranslator.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like