Issues in PagePartConfigurationParserTest.php - All Issues - Inspection of "[MediaBundle] Code improvement found by static cod..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aba493...5356ed )

by Ruud

created 2019-06-11 15:20 UTC

PagePartConfigurationParserTest.php (5 issues)

Labels

Documentation 5

Severity

Minor 5

Peter Zentjens 5

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\PagePartBundle\Tests\PagePartConfigurationReader;

use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminConfiguratorInterface;
use Kunstmaan\PagePartBundle\PagePartConfigurationReader\PagePartConfigurationParser;
use PHPUnit\Framework\TestCase;
use Symfony\Component\HttpKernel\KernelInterface;

class PagePartConfigurationParserTest extends TestCase
{
    public function testParseSf4Flow()
    {
        $kernel = $this->createMock(KernelInterface::class);
        $pagePartConfigurationParser = new PagePartConfigurationParser($kernel, [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'main' => [
                'name' => 'Main content',
                'context' => 'main',
                'types' => [
                    ['name' => 'FooBar', 'class' => 'Foo\BarPagePart'],
                    ['name' => 'Foo', 'class' => 'FooPagePart'],
                    ['name' => 'Bar', 'class' => 'BarPagePart'],
                ],
            ],
        ]);

        $result = $pagePartConfigurationParser->parse('main');
        $this->assertInstanceOf(PagePartAdminConfiguratorInterface::class, $result);
        $this->assertEquals('Main content', $result->getName());
    }

    public function testParseSf3Flow()
    {
        $kernel = $this->createMock(KernelInterface::class);
        $kernel->method('locateResource')->willReturn(__DIR__ . '/Resources/config/pageparts/main.yml');

        $pagePartConfigurationParser = new PagePartConfigurationParser($kernel, []);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $result = $pagePartConfigurationParser->parse('MyWebsiteBundle:main');
        $this->assertInstanceOf(PagePartAdminConfiguratorInterface::class, $result);
        $this->assertEquals('Main content', $result->getName());
    }

    public function testPresetExtendsBundle()
    {
        $kernel = $this->createMock(KernelInterface::class);
        $pagePartConfigurationParser = new PagePartConfigurationParser($kernel, [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'foo' => [
                'name' => 'Foo content',
                'context' => 'foo',
                'extends' => 'main',
                'types' => [
                    ['name' => 'FooBar', 'class' => 'Foo\BarPagePart'],
                    ['name' => 'Foo', 'class' => 'FooPagePart'],
                    ['name' => 'Bar', 'class' => 'BarPagePart'],
                ],
            ],
            'main' => [
                'name' => 'Main content',
                'context' => 'main',
                'types' => [
                    ['name' => 'Header', 'class' => 'HeaderPagePart'],
                ],
            ],
        ]
        );

        $value = $pagePartConfigurationParser->parse('foo');

        $this->assertCount(4, $value->getPossiblePagePartTypes());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @expectedException \RuntimeException
     */
    public function testCircularReferenceIsDetected()
    {
        $kernel = $this->createMock(KernelInterface::class);

        $parser = new PagePartConfigurationParser($kernel, [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'foo' => [
                'name' => 'Foo preset',
                'extends' => 'bar',
            ],
            'bar' => [
                'name' => 'Bar preset',
                'extends' => 'baz',
            ],
            'baz' => [
                'name' => 'Baz preset',
                'extends' => 'foo',
            ],
        ]);

        $parser->parse('foo');
    }
}


1		<?php
2
3		namespace Kunstmaan\PagePartBundle\Tests\PagePartConfigurationReader;
4
5		use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminConfiguratorInterface;
6		use Kunstmaan\PagePartBundle\PagePartConfigurationReader\PagePartConfigurationParser;
7		use PHPUnit\Framework\TestCase;
8		use Symfony\Component\HttpKernel\KernelInterface;
9
10		class PagePartConfigurationParserTest extends TestCase
11		{
12		public function testParseSf4Flow()
13		{
14		$kernel = $this->createMock(KernelInterface::class);
15		$pagePartConfigurationParser = new PagePartConfigurationParser($kernel, [
		0 ignored issues – show Documentation introduced 2019-03-03 18:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$kernel` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...Kernel\KernelInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
16		'main' => [
17		'name' => 'Main content',
18		'context' => 'main',
19		'types' => [
20		['name' => 'FooBar', 'class' => 'Foo\BarPagePart'],
21		['name' => 'Foo', 'class' => 'FooPagePart'],
22		['name' => 'Bar', 'class' => 'BarPagePart'],
23		],
24		],
25		]);
26
27		$result = $pagePartConfigurationParser->parse('main');
28		$this->assertInstanceOf(PagePartAdminConfiguratorInterface::class, $result);
29		$this->assertEquals('Main content', $result->getName());
30		}
31
32	View Code Duplication	public function testParseSf3Flow()
33		{
34		$kernel = $this->createMock(KernelInterface::class);
35		$kernel->method('locateResource')->willReturn(__DIR__ . '/Resources/config/pageparts/main.yml');
36
37		$pagePartConfigurationParser = new PagePartConfigurationParser($kernel, []);
		0 ignored issues – show Documentation introduced 2019-03-03 18:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$kernel` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...Kernel\KernelInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
38
39		$result = $pagePartConfigurationParser->parse('MyWebsiteBundle:main');
40		$this->assertInstanceOf(PagePartAdminConfiguratorInterface::class, $result);
41		$this->assertEquals('Main content', $result->getName());
42		}
43
44		public function testPresetExtendsBundle()
45		{
46		$kernel = $this->createMock(KernelInterface::class);
47		$pagePartConfigurationParser = new PagePartConfigurationParser($kernel, [
		0 ignored issues – show Documentation introduced 2019-03-03 18:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$kernel` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...Kernel\KernelInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
48		'foo' => [
49		'name' => 'Foo content',
50		'context' => 'foo',
51		'extends' => 'main',
52		'types' => [
53		['name' => 'FooBar', 'class' => 'Foo\BarPagePart'],
54		['name' => 'Foo', 'class' => 'FooPagePart'],
55		['name' => 'Bar', 'class' => 'BarPagePart'],
56		],
57		],
58		'main' => [
59		'name' => 'Main content',
60		'context' => 'main',
61		'types' => [
62		['name' => 'Header', 'class' => 'HeaderPagePart'],
63		],
64		],
65		]
66		);
67
68		$value = $pagePartConfigurationParser->parse('foo');
69
70		$this->assertCount(4, $value->getPossiblePagePartTypes());
		0 ignored issues – show Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$value->getPossiblePagePartTypes()` is of type `array`, but the function expects a `object<Countable>\|object...nit\Framework\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
71		}
72
73		/**
74		* @expectedException \RuntimeException
75		*/
76		public function testCircularReferenceIsDetected()
77		{
78		$kernel = $this->createMock(KernelInterface::class);
79
80		$parser = new PagePartConfigurationParser($kernel, [
		0 ignored issues – show Documentation introduced 2019-03-03 18:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$kernel` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...Kernel\KernelInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
81		'foo' => [
82		'name' => 'Foo preset',
83		'extends' => 'bar',
84		],
85		'bar' => [
86		'name' => 'Bar preset',
87		'extends' => 'baz',
88		],
89		'baz' => [
90		'name' => 'Baz preset',
91		'extends' => 'foo',
92		],
93		]);
94
95		$parser->parse('foo');
96		}
97		}
98

Kunstmaan / KunstmaanBundlesCMS

Push — master ( aba493...5356ed )

PagePartConfigurationParserTest.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like