Issues in CloneListenerTest.php - All Issues - Inspection of "[MediaBundle] Code improvement found by static cod..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aba493...5356ed )

by Ruud

created 2019-06-11 15:20 UTC

Tests/unit/EventListener/CloneListenerTest.php (3 issues)

Labels

Severity

Minor 3

Maciej Łebkowski 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\PagePartBundle\Tests\EventListener;

use Kunstmaan\AdminBundle\Event\DeepCloneAndSaveEvent;
use Kunstmaan\PagePartBundle\Entity\PageTemplateConfiguration;
use Kunstmaan\PagePartBundle\EventListener\CloneListener;
use Kunstmaan\PagePartBundle\Helper\HasPagePartsInterface;
use Kunstmaan\PagePartBundle\Helper\HasPageTemplateInterface;
use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminConfigurator;
use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminConfiguratorInterface;
use Kunstmaan\PagePartBundle\PagePartConfigurationReader\PagePartConfigurationReaderInterface;
use Kunstmaan\PagePartBundle\PageTemplate\PageTemplateConfigurationService;
use Kunstmaan\PagePartBundle\Repository\PagePartRefRepository;
use PHPUnit\Framework\TestCase;

/**
 * Class CloneListenerTest
 */
class CloneListenerTest extends TestCase
{
    /**
     * @var \Doctrine\ORM\EntityManager|\PHPUnit_Framework_MockObject_MockObject
     */
    private $em;

    /**
     * @var PagePartAdminConfiguratorInterface
     */
    private $configurator;

    /**
     * @var \Doctrine\ORM\EntityRepository|\PHPUnit_Framework_MockObject_MockObject
     */
    private $repo;

    /**
     * @var CloneListener
     */
    private $object;

    /**
     * @var PagePartConfigurationReaderInterface|\PHPUnit_Framework_MockObject_MockObject
     */
    private $reader;

    /**
     * @var PageTemplateConfigurationService|\PHPUnit_Framework_MockObject_MockObject
     */
    private $templateService;

    protected function setUp()
    {
        $this->em = $this->getMockBuilder('Doctrine\ORM\EntityManager')
            ->disableOriginalConstructor()
            ->getMock();

        $this->repo = $this->getMockBuilder(PagePartRefRepository::class)
            ->disableOriginalConstructor()
            ->getMock();

        $this->em->expects($this->any())
            ->method('getRepository')
            ->with($this->equalTo('KunstmaanPagePartBundle:PagePartRef'))
            ->willReturn($this->repo);

        $this->configurator = new PagePartAdminConfigurator();
        $this->configurator->setContext('main');

        $this->reader = $this->createMock(PagePartConfigurationReaderInterface::class);
        $this->reader
            ->expects($this->any())
            ->method('getPagePartAdminConfigurators')
            ->willReturn([$this->configurator]);

        $this->reader
            ->expects($this->any())
            ->method('getPagePartContexts')
            ->willReturn([$this->configurator->getContext()]);

        $this->templateService = $this->getMockBuilder(PageTemplateConfigurationService::class)->disableOriginalConstructor()->getMock();

        $this->object = new CloneListener($this->em, $this->reader, $this->templateService);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testClonePagePart()
    {
        $entity = $this->createMock(HasPagePartsInterface::class);

        $clone = clone $entity;

        $this->repo->expects($this->once())
            ->method('copyPageParts')
            ->with($this->em, $entity, $clone, 'main');

        $event = new DeepCloneAndSaveEvent($entity, $clone);
        $this->object->postDeepCloneAndSave($event);
    }

    public function testClonePageTemplate()
    {
        $entity = $this->createMock(HasPageTemplateInterface::class);

        /** @var HasPageTemplateInterface|\PHPUnit_Framework_MockObject_MockObject $clone */
        $clone = clone $entity;

        $entity->expects($this->any())
            ->method('getId')
            ->willReturn(1);

        $clone->expects($this->any())
            ->method('getId')
            ->willReturn(2);

        $this->repo->expects($this->once())
            ->method('copyPageParts')
            ->with($this->em, $entity, $clone, 'main');

        $configuration = new PageTemplateConfiguration();
        $configuration->setId(1);
        $configuration->setPageId(1);

        $this->templateService->expects($this->once())
            ->method('findOrCreateFor')
            ->with($this->identicalTo($entity))
            ->willReturn($configuration);

        $newConfiguration = clone $configuration;
        $newConfiguration->setId(null);
        $newConfiguration->setPageId($clone->getId());

        $this->em->expects($this->once())
            ->method('persist')
            ->with($newConfiguration);

        $event = new DeepCloneAndSaveEvent($entity, $clone);
        $this->object->postDeepCloneAndSave($event);
    }
}


1		<?php
2
3		namespace Kunstmaan\PagePartBundle\Tests\EventListener;
4
5		use Kunstmaan\AdminBundle\Event\DeepCloneAndSaveEvent;
6		use Kunstmaan\PagePartBundle\Entity\PageTemplateConfiguration;
7		use Kunstmaan\PagePartBundle\EventListener\CloneListener;
8		use Kunstmaan\PagePartBundle\Helper\HasPagePartsInterface;
9		use Kunstmaan\PagePartBundle\Helper\HasPageTemplateInterface;
10		use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminConfigurator;
11		use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminConfiguratorInterface;
12		use Kunstmaan\PagePartBundle\PagePartConfigurationReader\PagePartConfigurationReaderInterface;
13		use Kunstmaan\PagePartBundle\PageTemplate\PageTemplateConfigurationService;
14		use Kunstmaan\PagePartBundle\Repository\PagePartRefRepository;
15		use PHPUnit\Framework\TestCase;
16
17		/**
18		* Class CloneListenerTest
19		*/
20		class CloneListenerTest extends TestCase
21		{
22		/**
23		* @var \Doctrine\ORM\EntityManager\|\PHPUnit_Framework_MockObject_MockObject
24		*/
25		private $em;
26
27		/**
28		* @var PagePartAdminConfiguratorInterface
29		*/
30		private $configurator;
31
32		/**
33		* @var \Doctrine\ORM\EntityRepository\|\PHPUnit_Framework_MockObject_MockObject
34		*/
35		private $repo;
36
37		/**
38		* @var CloneListener
39		*/
40		private $object;
41
42		/**
43		* @var PagePartConfigurationReaderInterface\|\PHPUnit_Framework_MockObject_MockObject
44		*/
45		private $reader;
46
47		/**
48		* @var PageTemplateConfigurationService\|\PHPUnit_Framework_MockObject_MockObject
49		*/
50		private $templateService;
51
52		protected function setUp()
53		{
54		$this->em = $this->getMockBuilder('Doctrine\ORM\EntityManager')
55		->disableOriginalConstructor()
56		->getMock();
57
58		$this->repo = $this->getMockBuilder(PagePartRefRepository::class)
59		->disableOriginalConstructor()
60		->getMock();
61
62		$this->em->expects($this->any())
63		->method('getRepository')
64		->with($this->equalTo('KunstmaanPagePartBundle:PagePartRef'))
65		->willReturn($this->repo);
66
67		$this->configurator = new PagePartAdminConfigurator();
68		$this->configurator->setContext('main');
69
70		$this->reader = $this->createMock(PagePartConfigurationReaderInterface::class);
71		$this->reader
72		->expects($this->any())
73		->method('getPagePartAdminConfigurators')
74		->willReturn([$this->configurator]);
75
76		$this->reader
77		->expects($this->any())
78		->method('getPagePartContexts')
79		->willReturn([$this->configurator->getContext()]);
80
81		$this->templateService = $this->getMockBuilder(PageTemplateConfigurationService::class)->disableOriginalConstructor()->getMock();
82
83		$this->object = new CloneListener($this->em, $this->reader, $this->templateService);
		0 ignored issues – show Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->em` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Doctrine\ORM\EntityManagerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->reader` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Kunstmaan\PagePar...urationReaderInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->templateService` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Kunstmaan\PagePar...teConfigurationService>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
84		}
85
86	View Code Duplication	public function testClonePagePart()
87		{
88		$entity = $this->createMock(HasPagePartsInterface::class);
89
90		$clone = clone $entity;
91
92		$this->repo->expects($this->once())
93		->method('copyPageParts')
94		->with($this->em, $entity, $clone, 'main');
95
96		$event = new DeepCloneAndSaveEvent($entity, $clone);
97		$this->object->postDeepCloneAndSave($event);
98		}
99
100		public function testClonePageTemplate()
101		{
102		$entity = $this->createMock(HasPageTemplateInterface::class);
103
104		/** @var HasPageTemplateInterface\|\PHPUnit_Framework_MockObject_MockObject $clone */
105		$clone = clone $entity;
106
107		$entity->expects($this->any())
108		->method('getId')
109		->willReturn(1);
110
111		$clone->expects($this->any())
112		->method('getId')
113		->willReturn(2);
114
115		$this->repo->expects($this->once())
116		->method('copyPageParts')
117		->with($this->em, $entity, $clone, 'main');
118
119		$configuration = new PageTemplateConfiguration();
120		$configuration->setId(1);
121		$configuration->setPageId(1);
122
123		$this->templateService->expects($this->once())
124		->method('findOrCreateFor')
125		->with($this->identicalTo($entity))
126		->willReturn($configuration);
127
128		$newConfiguration = clone $configuration;
129		$newConfiguration->setId(null);
130		$newConfiguration->setPageId($clone->getId());
131
132		$this->em->expects($this->once())
133		->method('persist')
134		->with($newConfiguration);
135
136		$event = new DeepCloneAndSaveEvent($entity, $clone);
137		$this->object->postDeepCloneAndSave($event);
138		}
139		}
140

Kunstmaan / KunstmaanBundlesCMS

Push — master ( aba493...5356ed )

Tests/unit/EventListener/CloneListenerTest.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like