Kunstmaan / KunstmaanBundlesCMS

src/Kunstmaan/NodeBundle/Toolbar/NodeDataCollector.php

<?php

namespace Kunstmaan\NodeBundle\Toolbar;

use Kunstmaan\AdminBundle\Helper\Toolbar\AbstractDataCollector;
use Kunstmaan\NodeBundle\Helper\NodeMenu;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;

class NodeDataCollector extends AbstractDataCollector
{
    /**
     * @var NodeMenu
     */
    private $nodeMenu;

    /**
     * @var UrlGeneratorInterface
     */
    private $urlGenerator;

    /**
     * NodeDataCollector constructor.
     *
     * @param NodeMenu              $nodeMenu
     * @param UrlGeneratorInterface $urlGenerator
     */
    public function __construct(NodeMenu $nodeMenu, UrlGeneratorInterface $urlGenerator)
    {
        $this->nodeMenu = $nodeMenu;
        $this->urlGenerator = $urlGenerator;
    }

    /**
     * @return array

Consider making the return type a bit more specific; maybe use string[].

     */
    public function getAccessRoles()
    {
        return ['ROLE_ADMIN'];
    }

    /**
     * @return array|null
     */
    public function collectData()
    {
        $current = $this->nodeMenu->getCurrent();

        if ($current) {
            $id = $current->getNode()->getId();

            $route = $this->urlGenerator->generate('KunstmaanNodeBundle_nodes_edit', ['id' => $id]);

            $data = [
                'route' => $route,
                'nt' => $current->getNodeTranslation(),
            ];

            return ['data' => $data];
        }

        return [];
    }

    /**
     * @param Request         $request
     * @param Response        $response
     * @param \Exception|null $exception
     */
    public function collect(Request $request, Response $response, \Exception $exception = null)

This method seems to be duplicated in your project.

    {
        if (!$this->showDataCollection($request, $response) || !$this->isEnabled()) {
            $this->data = false;

It seems like false of type false is incompatible with the declared type array of property $data.

        } else {
            $this->data = $this->collectData();

It seems like $this->collectData() can be null. However, the property $data is declared as array. Maybe change the type of the property to array|null or add a type check?

        }
    }

    /**
     * Gets the data for template
     *
     * @return array The request events
     */
    public function getTemplateData()
    {
        return $this->data;
    }

    /**
     * @return string
     */
    public function getName()
    {
        return 'kuma_node';
    }

    /**
     * @return bool
     */
    public function isEnabled()
    {
        return true;
    }

    public function reset()
    {
        $this->data = [];
    }
}