Issues in KunstmaanFormExtension.php - All Issues - Inspection of "[MediaBundle] Code improvement found by static cod..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aba493...5356ed )

by Ruud

created 2019-06-11 15:20 UTC

DependencyInjection/KunstmaanFormExtension.php (1 issue)

Labels

Severity

Informational 1

Joeri Verdeyen 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\FormBundle\DependencyInjection;

use Symfony\Component\Config\FileLocator;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Extension\PrependExtensionInterface;
use Symfony\Component\DependencyInjection\Loader;
use Symfony\Component\HttpKernel\DependencyInjection\Extension;

/**
 * This is the class that loads and manages your bundle configuration
 *
 * To learn more see {@link http://symfony.com/doc/current/cookbook/bundles/extension.html}
 */
class KunstmaanFormExtension extends Extension implements PrependExtensionInterface
{
    /**
     * {@inheritdoc}
     */
    public function load(array $configs, ContainerBuilder $container)
    {
        $configuration = new Configuration();
        $config = $this->processConfiguration($configuration, $configs);

        $container->setParameter('kunstmaan_form.deletable_formsubmissions', $config['deletable_formsubmissions']);

        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
        $loader->load('services.yml');
    }

    public function prepend(ContainerBuilder $container)
    {
        if (!$container->hasParameter('form_submission_rootdir')) {
            $container->setParameter('form_submission_rootdir',
                sprintf('%s/../web/uploads/formsubmissions', $container->getParameter('kernel.root_dir')));
        }

        if (!$container->hasParameter('form_submission_webdir')) {
            $container->setParameter('form_submission_webdir', '/uploads/formsubmissions/');
        }

        $twigConfig['globals']['form_submission_webdir'] = $container->getParameter('form_submission_webdir');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $container->prependExtensionConfig('twig', $twigConfig);
        $configs = $container->getExtensionConfig($this->getAlias());
        $this->processConfiguration(new Configuration(), $configs);
    }
}


1			<?php
2
3			namespace Kunstmaan\FormBundle\DependencyInjection;
4
5			use Symfony\Component\Config\FileLocator;
6			use Symfony\Component\DependencyInjection\ContainerBuilder;
7			use Symfony\Component\DependencyInjection\Extension\PrependExtensionInterface;
8			use Symfony\Component\DependencyInjection\Loader;
9			use Symfony\Component\HttpKernel\DependencyInjection\Extension;
10
11			/**
12			* This is the class that loads and manages your bundle configuration
13			*
14			* To learn more see {@link http://symfony.com/doc/current/cookbook/bundles/extension.html}
15			*/
16			class KunstmaanFormExtension extends Extension implements PrependExtensionInterface
17			{
18			/**
19			* {@inheritdoc}
20			*/
21	1	View Code Duplication	public function load(array $configs, ContainerBuilder $container)
22			{
23	1		$configuration = new Configuration();
24	1		$config = $this->processConfiguration($configuration, $configs);
25
26	1		$container->setParameter('kunstmaan_form.deletable_formsubmissions', $config['deletable_formsubmissions']);
27
28	1		$loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
29	1		$loader->load('services.yml');
30	1		}
31
32	1		public function prepend(ContainerBuilder $container)
33			{
34	1		if (!$container->hasParameter('form_submission_rootdir')) {
35	1		$container->setParameter('form_submission_rootdir',
36	1		sprintf('%s/../web/uploads/formsubmissions', $container->getParameter('kernel.root_dir')));
37			}
38
39	1		if (!$container->hasParameter('form_submission_webdir')) {
40	1		$container->setParameter('form_submission_webdir', '/uploads/formsubmissions/');
41			}
42
43	1		$twigConfig['globals']['form_submission_webdir'] = $container->getParameter('form_submission_webdir');
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$twigConfig` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$twigConfig = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
44	1		$container->prependExtensionConfig('twig', $twigConfig);
45	1		$configs = $container->getExtensionConfig($this->getAlias());
46	1		$this->processConfiguration(new Configuration(), $configs);
47	1		}
48			}
49

Kunstmaan / KunstmaanBundlesCMS

Push — master ( aba493...5356ed )

DependencyInjection/KunstmaanFormExtension.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like