Issues in AdminLocaleListenerTest.php - All Issues - Inspection of "[MediaBundle] Code improvement found by static cod..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aba493...5356ed )

by Ruud

created 2019-06-11 15:20 UTC

unit/EventListener/AdminLocaleListenerTest.php (6 issues)

Labels

Documentation 6

Severity

Minor 6

Ruud Denivel 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\AdminBundle\Tests\EventListener;

use Kunstmaan\AdminBundle\Entity\User;
use Kunstmaan\AdminBundle\EventListener\AdminLocaleListener;
use Kunstmaan\AdminBundle\Helper\AdminRouteHelper;
use PHPUnit\Framework\TestCase;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Event\GetResponseEvent;
use Symfony\Component\HttpKernel\KernelEvents;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
use Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken;
use Symfony\Component\Translation\TranslatorInterface;

class AdminLocaleListenerTest extends TestCase
{
    public function testListener()
    {
        $request = new Request([], [], [], [], [], ['REQUEST_URI' => '/en/admin/']);
        $storage = $this->createMock(TokenStorageInterface::class);
        $trans = $this->createMock(TranslatorInterface::class);
        $adminRouteHelper = $this->createMock(AdminRouteHelper::class);
        $event = $this->createMock(GetResponseEvent::class);
        $token = $this->createMock(UsernamePasswordToken::class);
        $user = $this->createMock(User::class);

        $storage->expects($this->exactly(3))->method('getToken')->willReturn($token);
        $token->expects($this->exactly(3))->method('getProviderKey')->willReturn('main');
        $token->expects($this->once())->method('getUser')->willReturn($user);
        $event->expects($this->any())->method('getRequest')->willReturn($request);
        $user->expects($this->once())->method('getAdminLocale')->willReturn(null);
        $trans->expects($this->once())->method('setLocale')->willReturn(null);
        $adminRouteHelper->method('isAdminRoute')->will($this->returnValueMap([['/en/admin/', true], ['/en/whatever/', false], ['/en/admin/preview/', false]]));

        $listener = new AdminLocaleListener($storage, $trans, $adminRouteHelper, 'en');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $events = AdminLocaleListener::getSubscribedEvents();
        $this->assertArrayHasKey(KernelEvents::REQUEST, $events);

        $listener->onKernelRequest($event);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $request = $request->duplicate([], [], [], [], [], ['REQUEST_URI' => '/en/whatever/']);
        $event = $this->createMock(GetResponseEvent::class);
        $event->expects($this->any())->method('getRequest')->willReturn($request);

        $listener->onKernelRequest($event);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $request = $request->duplicate([], [], [], [], [], ['REQUEST_URI' => '/en/admin/preview/']);
        $event = $this->createMock(GetResponseEvent::class);
        $event->expects($this->any())->method('getRequest')->willReturn($request);

        $listener->onKernelRequest($event);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			namespace Kunstmaan\AdminBundle\Tests\EventListener;
4
5			use Kunstmaan\AdminBundle\Entity\User;
6			use Kunstmaan\AdminBundle\EventListener\AdminLocaleListener;
7			use Kunstmaan\AdminBundle\Helper\AdminRouteHelper;
8			use PHPUnit\Framework\TestCase;
9			use Symfony\Component\HttpFoundation\Request;
10			use Symfony\Component\HttpKernel\Event\GetResponseEvent;
11			use Symfony\Component\HttpKernel\KernelEvents;
12			use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
13			use Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken;
14			use Symfony\Component\Translation\TranslatorInterface;
15
16			class AdminLocaleListenerTest extends TestCase
17			{
18			public function testListener()
19			{
20			$request = new Request([], [], [], [], [], ['REQUEST_URI' => '/en/admin/']);
21			$storage = $this->createMock(TokenStorageInterface::class);
22			$trans = $this->createMock(TranslatorInterface::class);
23			$adminRouteHelper = $this->createMock(AdminRouteHelper::class);
24			$event = $this->createMock(GetResponseEvent::class);
25			$token = $this->createMock(UsernamePasswordToken::class);
26			$user = $this->createMock(User::class);
27
28			$storage->expects($this->exactly(3))->method('getToken')->willReturn($token);
29			$token->expects($this->exactly(3))->method('getProviderKey')->willReturn('main');
30			$token->expects($this->once())->method('getUser')->willReturn($user);
31			$event->expects($this->any())->method('getRequest')->willReturn($request);
32			$user->expects($this->once())->method('getAdminLocale')->willReturn(null);
33			$trans->expects($this->once())->method('setLocale')->willReturn(null);
34			$adminRouteHelper->method('isAdminRoute')->will($this->returnValueMap([['/en/admin/', true], ['/en/whatever/', false], ['/en/admin/preview/', false]]));
35
36			$listener = new AdminLocaleListener($storage, $trans, $adminRouteHelper, 'en');
			0 ignored issues – show Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$storage` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...\TokenStorageInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$trans` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...on\TranslatorInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$adminRouteHelper` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Kunstmaan\AdminBu...elper\AdminRouteHelper>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
37
38			$events = AdminLocaleListener::getSubscribedEvents();
39			$this->assertArrayHasKey(KernelEvents::REQUEST, $events);
40
41			$listener->onKernelRequest($event);
			0 ignored issues – show Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$event` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...Event\GetResponseEvent>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
42
43			$request = $request->duplicate([], [], [], [], [], ['REQUEST_URI' => '/en/whatever/']);
44			$event = $this->createMock(GetResponseEvent::class);
45			$event->expects($this->any())->method('getRequest')->willReturn($request);
46
47			$listener->onKernelRequest($event);
			0 ignored issues – show Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$event` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...Event\GetResponseEvent>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
48
49			$request = $request->duplicate([], [], [], [], [], ['REQUEST_URI' => '/en/admin/preview/']);
50			$event = $this->createMock(GetResponseEvent::class);
51			$event->expects($this->any())->method('getRequest')->willReturn($request);
52
53			$listener->onKernelRequest($event);
			0 ignored issues – show Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$event` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...Event\GetResponseEvent>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
54			}
55			}
56

Kunstmaan / KunstmaanBundlesCMS

Push — master ( aba493...5356ed )

unit/EventListener/AdminLocaleListenerTest.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like