Issues in AclWalker.php - All Issues - Inspection of "[MediaBundle] Code improvement found by static cod..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aba493...5356ed )

by Ruud

created 2019-06-11 15:20 UTC

AdminBundle/Helper/Security/Acl/AclWalker.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Wim Vandersmissen 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\AdminBundle\Helper\Security\Acl;

use Doctrine\ORM\Query;
use Doctrine\ORM\Query\SqlWalker;

/**
 * AclWalker
 */
class AclWalker extends SqlWalker
{
    /**
     * Walks down a FromClause AST node, thereby generating the appropriate SQL.
     *
     * @param string $fromClause
     *
     * @return string the SQL
     */
    public function walkFromClause($fromClause)
    {
        $sql = parent::walkFromClause($fromClause);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $name = $this->getQuery()->getHint('acl.entityRootTableName');
        $alias = $this->getQuery()->getHint('acl.entityRootTableDqlAlias');
        $tableAlias = $this->getSQLTableAlias($name, $alias);
        $extraQuery = $this->getQuery()->getHint('acl.extra.query');

        $tempAclView = <<<tempAclView
JOIN ({$extraQuery}) ta_ ON {$tableAlias}.id = ta_.id
tempAclView;

        return $sql . ' ' . $tempAclView;
    }
}


1		<?php
2
3		namespace Kunstmaan\AdminBundle\Helper\Security\Acl;
4
5		use Doctrine\ORM\Query;
6		use Doctrine\ORM\Query\SqlWalker;
7
8		/**
9		* AclWalker
10		*/
11		class AclWalker extends SqlWalker
12		{
13		/**
14		* Walks down a FromClause AST node, thereby generating the appropriate SQL.
15		*
16		* @param string $fromClause
17		*
18		* @return string the SQL
19		*/
20	1	public function walkFromClause($fromClause)
21		{
22	1	$sql = parent::walkFromClause($fromClause);
		0 ignored issues – show Documentation introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$fromClause` is of type `string`, but the function expects a `object<Doctrine\ORM\Query\AST\FromClause>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
23	1	$name = $this->getQuery()->getHint('acl.entityRootTableName');
24	1	$alias = $this->getQuery()->getHint('acl.entityRootTableDqlAlias');
25	1	$tableAlias = $this->getSQLTableAlias($name, $alias);
26	1	$extraQuery = $this->getQuery()->getHint('acl.extra.query');
27
28		$tempAclView = <<<tempAclView
29	1	JOIN ({$extraQuery}) ta_ ON {$tableAlias}.id = ta_.id
30		tempAclView;
31
32	1	return $sql . ' ' . $tempAclView;
33		}
34		}
35

Kunstmaan / KunstmaanBundlesCMS

Push — master ( aba493...5356ed )

AdminBundle/Helper/Security/Acl/AclWalker.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like