Kunstmaan / KunstmaanBundlesCMS

src/Kunstmaan/AdminBundle/Composer/ScriptHandler.php

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 15 and the first side effect is on line 10.

namespace Kunstmaan\AdminBundle\Composer;

use Composer\Script\Event;
use Symfony\Component\Filesystem\Exception\IOException;
use Symfony\Component\Filesystem\Filesystem;
use Symfony\Component\Yaml\Parser;

@trigger_error(sprintf('The composer script class "%s" is deprecated in KunstmaanAdminBundle 5.4 and will be removed in KunstmaanAdminBundle 6.0. If you use this script handler, remove it from your composer.json scripts section.', __CLASS__), E_USER_DEPRECATED);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

/**
 * NEXT_MAJOR remove the symfony/filesystem and symfony/yaml as direct dependency of the admin-bundle (if unused in other classes)
 */
class ScriptHandler
{
    protected static $options = array(
        'symfony-app-dir' => 'app',
        'multi-language-option' => 'multilanguage',
    );

    /**
     * @param Event $event
     */
    public static function checkMultiLangConfigs(Event $event)
    {
        $options = static::getOptions($event);
        $appDir = getcwd() . '/' . $options['symfony-app-dir'];
        $configDir = $appDir . '/config';
        $parametersFile = $configDir . '/parameters.yml';
        $routingFile = $configDir . '/routing.yml';
        $securityFile = $configDir . '/security.yml';
        $singleLangRoutingFile = $configDir . '/routing.singlelang.yml';
        $singleLangSecurityFile = $configDir . '/security.singlelang.yml';
        $multiLangRoutingFile = $configDir . '/routing.multilang.yml';
        $multiLangSecurityFile = $configDir . '/security.multilang.yml';

        if (is_file($parametersFile)) {
            $parameters = self::getConfigParameters($parametersFile);

            if (isset($parameters[$options['multi-language-option']])) {
                $multiLanguage = $parameters[$options['multi-language-option']];
                if (!$multiLanguage) {
                    $fs = new Filesystem();

                    // move routing
                    if (is_file($singleLangRoutingFile) && !is_file($multiLangRoutingFile)) {

This code seems to be duplicated across your project.

                        try {
                            $fs->rename($routingFile, $multiLangRoutingFile);
                            $fs->rename($singleLangRoutingFile, $routingFile);
                            $event->getIO()->write(sprintf('Replaced routing config with single language config'));
                        } catch (IOException $ioE) {
                            $event->getIO()->write(sprintf('Exception while moving routing file to singlelang routing file: <error>%s</error>', $ioE->getMessage()));
                        }
                    }
                    // move security
                    if (is_file($singleLangSecurityFile) && !is_file($multiLangSecurityFile)) {

This code seems to be duplicated across your project.

                        try {
                            $fs->rename($securityFile, $multiLangSecurityFile);
                            $fs->rename($singleLangSecurityFile, $securityFile);
                            $event->getIO()->write(sprintf('Replaced security config with single language config'));
                        } catch (IOException $ioE) {
                            $event->getIO()->write(sprintf('Exception while moving routing file to singlelang routing file: <error>%s</error>', $ioE->getMessage()));
                        }
                    }
                }
            }
        }
    }

    /**
     * @param Event $event
     *
     * @return array
     */
    protected static function getOptions(Event $event)
    {
        return array_merge(static::$options, $event->getComposer()->getPackage()->getExtra());
    }

    /**
     * @param string $parametersFile
     *
     * @return array
     */
    protected static function getConfigParameters($parametersFile)
    {
        $ymlParser = new Parser();
        $config = $ymlParser->parse(file_get_contents($parametersFile));

        return isset($config['parameters']) ? $config['parameters'] : array();
    }
}