Completed
Push — master ( 1de9b7...830752 )
by Kristof
38:46 queued 24:09
created

AbstractArticleTagAdminListConfigurator.php (1 issue)

mismatching argument types.

Documentation Minor

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
3
namespace Kunstmaan\ArticleBundle\AdminList;
4
5
use Doctrine\ORM\EntityManagerInterface;
6
use Doctrine\ORM\QueryBuilder;
7
use Kunstmaan\AdminBundle\Helper\Security\Acl\AclHelper;
8
use Kunstmaan\AdminListBundle\AdminList\Configurator\AbstractDoctrineORMAdminListConfigurator;
9
use Kunstmaan\AdminListBundle\AdminList\FilterType\ORM\StringFilterType;
10
11
/**
12
 * The AdminList configurator for the AbstractArticleAuthor
13
 */
14 View Code Duplication
class AbstractArticleTagAdminListConfigurator extends AbstractDoctrineORMAdminListConfigurator
15
{
16
    /**
17
     * @param EntityManagerInterface $em        The entity manager
18
     * @param AclHelper              $aclHelper The ACL helper
19
     */
20
    public function __construct(EntityManagerInterface $em, AclHelper $aclHelper)
21
    {
22
        parent::__construct($em, $aclHelper);
23
    }
24
25
    /**
26
     * Return current bundle name.
27
     *
28
     * @return string
29
     */
30
    public function getBundleName()
31
    {
32
        return 'KunstmaanArticleBundle';
33
    }
34
35
    /**
36
     * Return current entity name.
37
     *
38
     * @return string
39
     */
40
    public function getEntityName()
41
    {
42
        return 'AbstractArticleTag';
43
    }
44
45
    /**
46
     * Configure filters
47
     */
48
    public function buildFilters()
49
    {
50
        $this->addFilter('name', new StringFilterType('name'), 'article.tag.list.filter.name');
51
    }
52
53
    /**
54
     * Configure the visible columns
55
     */
56
    public function buildFields()
57
    {
58
        $this->addField('name', 'article.tag.list.header.name', true);
0 ignored issues
show
true is of type boolean, but the function expects a string.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
59
    }
60
61
    /**
62
     * @param QueryBuilder $queryBuilder
63
     */
64
    public function adaptQueryBuilder(QueryBuilder $queryBuilder)
65
    {
66
        $queryBuilder->orderBy('b.name', 'ASC');
67
    }
68
69
    /**
70
     * Overwrite the parent function. By adding the TranslationWalker, we can order by the translated fields.
71
     *
72
     * @return \Doctrine\ORM\Query|null
73
     */
74
    public function getQuery()
75
    {
76
        $query = parent::getQuery();
77
78
        if (!is_null($query)) {
79
            $query->setHint(
80
                \Doctrine\ORM\Query::HINT_CUSTOM_OUTPUT_WALKER,
81
                'Gedmo\\Translatable\\Query\\TreeWalker\\TranslationWalker'
82
            );
83
            $query->useQueryCache(false);
84
        }
85
86
        return $query;
87
    }
88
}
89