Issues in AbstractDoctrineORMAdminListConfiguratorTest.php - All Issues - Inspection of "Merge pull request #2335 from acrobat/fixed-remain..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1de9b7...830752 )

by Kristof

created 2019-02-06 14:09 UTC

AbstractDoctrineORMAdminListConfiguratorTest.php (1 issue)

Labels

Severity

Minor 1

Peter Zentjens 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\AdminListBundle\Tests\AdminList\Configurator;

use ArrayIterator;
use Codeception\Stub;
use Doctrine\Common\Persistence\Mapping\ClassMetadata;
use Doctrine\DBAL\Connection;
use Doctrine\DBAL\Platforms\MySQL57Platform;
use Doctrine\ORM\AbstractQuery;
use Doctrine\ORM\Cache\CacheConfiguration;
use Doctrine\ORM\Configuration;
use Doctrine\ORM\EntityManager;
use Doctrine\ORM\Query;
use Doctrine\ORM\QueryBuilder;
use Kunstmaan\AdminBundle\Helper\Security\Acl\AclHelper;
use Kunstmaan\AdminBundle\Helper\Security\Acl\Permission\PermissionDefinition;
use Kunstmaan\AdminListBundle\AdminList\Configurator\AbstractDoctrineORMAdminListConfigurator;
use Kunstmaan\AdminListBundle\AdminList\Filter;
use Kunstmaan\AdminListBundle\AdminList\FilterBuilder;
use Kunstmaan\AdminListBundle\AdminList\FilterType\ORM\StringFilterType;
use Kunstmaan\AdminListBundle\AdminList\SortableInterface;
use Pagerfanta\Pagerfanta;
use PHPUnit\Framework\TestCase;
use ReflectionClass;
use Kunstmaan\LeadGenerationBundle\Tests\unit\Entity\Popup\Popup;

class ORM extends AbstractDoctrineORMAdminListConfigurator implements SortableInterface
{
    /**
     * @return mixed
     */
    public function getBundleName()
    {
        return 'SomeBundle';
    }

    /**
     * @return mixed
     */
    public function getEntityName()
    {
        return 'SomeEntity';
    }

    /**
     * @return mixed
     */
    public function buildFields()
    {
        return true;
    }

    /**
     * @return string
     */
    public function getSortableField()
    {
        return 'sortfield';
    }
}

class AbstractDoctrineORMAdminListConfiguratorTest extends TestCase

{
    /** @var ORM $config */
    private $config;

    /** @var \PHPUnit_Framework_MockObject_MockObject $em */
    private $em;

    /**
     * @throws \ReflectionException
     */
    public function setUp()
    {
        $em = $this->createMock(EntityManager::class);
        $this->em = $em;
        $this->config = new ORM($em);

        $mirror = new ReflectionClass(AbstractDoctrineORMAdminListConfigurator::class);
        $property = $mirror->getProperty('orderBy');
        $property->setAccessible(true);
        $property->setValue($this->config, 'somefield');
    }

    public function testGetSetEntityManager()
    {
        $config = $this->config;
        $em = $this->createMock(EntityManager::class);
        $config->setEntityManager($em);
        $this->assertInstanceOf(EntityManager::class, $config->getEntityManager());
    }

    public function testGetSetPermissionDefinition()
    {
        $config = $this->config;
        $this->assertNull($config->getPermissionDefinition());
        $config->setPermissionDefinition(new PermissionDefinition(['something']));
        $this->assertInstanceOf(PermissionDefinition::class, $config->getPermissionDefinition());
    }

    public function testGetQuery()
    {
        $config = $this->config;
        $em = $this->em;
        $filterBuilder = $this->createMock(FilterBuilder::class);
        $filterBuilder->expects($this->once())->method('getCurrentFilters')->willReturn([new Filter('whatever', ['type' => new StringFilterType('whatever')], uniqid())]);
        $config->setFilterBuilder($filterBuilder);
        $cacheConfig = $this->createMock(CacheConfiguration::class);
        $cacheConfig->expects($this->any())->method('getCacheLogger')->willReturn('whatever');
        $fakeConfig = $this->createMock(Configuration::class);
        $fakeConfig->expects($this->any())->method('getDefaultQueryHints')->willReturn($fakeConfig);
        $fakeConfig->expects($this->any())->method('isSecondLevelCacheEnabled')->willReturn($fakeConfig);
        $fakeConfig->expects($this->any())->method('getSecondLevelCacheConfiguration')->willReturn($cacheConfig);
        $fakeClassMetaData = Stub::makeEmpty(ClassMetadata::class, ['hasAssociation' => false]);
        $qb = $this->createMock(QueryBuilder::class);
        $qb->expects($this->any())->method('setParameters')->willReturn($qb);
        $qb->expects($this->any())->method('setMaxResults')->willReturn($qb);
        $em->expects($this->any())->method('createQuery')->willReturn($qb);
        $em->expects($this->any())->method('getRepository')->willReturn($em);
        $em->expects($this->any())->method('createQueryBuilder')->willReturn($qb);
        $em->expects($this->any())->method('getConfiguration')->willReturn($fakeConfig);
        $em->expects($this->any())->method('getClassMetadata')->willReturn($fakeClassMetaData);
        $query = new Query($em);
        $qb->expects($this->any())->method('getQuery')->willReturn($query);
        $query = $config->getQuery();
        $this->assertInstanceOf(Query::class, $query);
    }

    public function testEditUrlFor()
    {
        $config = $this->config;
        $item = new Popup();
        $item->setId(666);
        $url = $config->getEditUrlFor($item);
        $this->assertCount(2, $url);
        $this->assertArrayHasKey('path', $url);
        $this->assertArrayHasKey('params', $url);
        $this->assertArrayHasKey('id', $url['params']);
        $this->assertEquals('somebundle_admin_someentity_edit', $url['path']);
        $this->assertCount(1, $url['params']);
        $this->assertEquals(666, $url['params']['id']);
    }

    public function testDeleteUrlFor()
    {
        $config = $this->config;
        $item = new Popup();
        $item->setId(666);
        $url = $config->getDeleteUrlFor($item);
        $this->assertCount(2, $url);
        $this->assertArrayHasKey('path', $url);
        $this->assertArrayHasKey('params', $url);
        $this->assertArrayHasKey('id', $url['params']);
        $this->assertEquals('somebundle_admin_someentity_delete', $url['path']);
        $this->assertCount(1, $url['params']);
        $this->assertEquals(666, $url['params']['id']);
    }

    /**
     * @throws \ReflectionException
     */
    public function testGetPagerFanta()
    {
        $config = $this->config;
        $em = $this->em;

        $cacheConfig = $this->createMock(CacheConfiguration::class);
        $cacheConfig->expects($this->any())->method('getCacheLogger')->willReturn('whatever');

        $fakeConfig = $this->createMock(Configuration::class);
        $fakeConfig->expects($this->any())->method('getDefaultQueryHints')->willReturn(['doctrine_paginator.distinct' => 'blah']);
        $fakeConfig->expects($this->any())->method('isSecondLevelCacheEnabled')->willReturn($fakeConfig);
        $fakeConfig->expects($this->any())->method('getSecondLevelCacheConfiguration')->willReturn($cacheConfig);

        $platform = $this->createMock(MySQL57Platform::class);
        $platform->expects($this->any())->method('getSQLResultCasing')->willReturn('string');

        $fakeClassMetaData = Stub::makeEmpty(ClassMetadata::class, ['hasAssociation' => false]);
        $connection = $this->createMock(Connection::class);
        $connection->expects($this->any())->method('getDatabasePlatform')->willReturn($platform);

        $qb = $this->createMock(QueryBuilder::class);
        $qb->expects($this->any())->method('setParameters')->willReturn($qb);
        $qb->expects($this->any())->method('setMaxResults')->willReturn($qb);
        $em->expects($this->any())->method('createQuery')->willReturn($qb);
        $em->expects($this->any())->method('getRepository')->willReturn($em);
        $em->expects($this->any())->method('createQueryBuilder')->willReturn($qb);
        $em->expects($this->any())->method('getConfiguration')->willReturn($fakeConfig);
        $em->expects($this->any())->method('getConnection')->willReturn($connection);
        $em->expects($this->any())->method('getClassMetadata')->willReturn($fakeClassMetaData);
        $qb->expects($this->any())->method('getQuery')->willReturn(new Query($em));

        $pager = $config->getPagerfanta();
        $this->assertInstanceOf(Pagerfanta::class, $pager);

        $pager = $this->createMock(Pagerfanta::class);
        $pager->expects($this->once())->method('getNbResults')->willReturn(5);
        $pager->expects($this->once())->method('getCurrentPageResults')->willReturn([1, 2, 3, 4, 5]);

        $mirror = new ReflectionClass(AbstractDoctrineORMAdminListConfigurator::class);
        $property = $mirror->getProperty('pagerfanta');
        $property->setAccessible(true);
        $property->setValue($config, $pager);

        $count = $config->getCount();
        $this->assertEquals(5, $count);

        $items = $config->getItems();
        $this->assertCount(5, $items);
    }

    /**
     * @throws \ReflectionException
     */
    public function testGetIterator()
    {
        $config = $this->config;
        $query = $this->createMock(AbstractQuery::class);
        $query->expects($this->once())->method('iterate')->willReturn(new ArrayIterator());

        $mirror = new ReflectionClass(AbstractDoctrineORMAdminListConfigurator::class);
        $property = $mirror->getProperty('query');
        $property->setAccessible(true);
        $property->setValue($config, $query);

        $it = $config->getIterator();
        $this->assertInstanceOf(ArrayIterator::class, $it);
    }

    /**
     * @throws \ReflectionException
     * @throws \Exception
     */
    public function testGetQueryWithAclEnabled()
    {
        $config = $this->config;
        $em = $this->em;

        $cacheConfig = $this->createMock(CacheConfiguration::class);
        $cacheConfig->expects($this->any())->method('getCacheLogger')->willReturn('whatever');
        $fakeConfig = $this->createMock(Configuration::class);
        $fakeConfig->expects($this->any())->method('getDefaultQueryHints')->willReturn($fakeConfig);
        $fakeConfig->expects($this->any())->method('isSecondLevelCacheEnabled')->willReturn($fakeConfig);
        $fakeConfig->expects($this->any())->method('getSecondLevelCacheConfiguration')->willReturn($cacheConfig);
        $qb = $this->createMock(QueryBuilder::class);
        $fakeClassMetaData = Stub::makeEmpty(ClassMetadata::class, ['hasAssociation' => false]);
        $qb->expects($this->any())->method('setParameters')->willReturn($qb);
        $qb->expects($this->any())->method('setMaxResults')->willReturn($qb);
        $em->expects($this->any())->method('createQuery')->willReturn($qb);
        $em->expects($this->any())->method('getRepository')->willReturn($em);
        $em->expects($this->any())->method('createQueryBuilder')->willReturn($qb);
        $em->expects($this->any())->method('getConfiguration')->willReturn($fakeConfig);
        $em->expects($this->any())->method('getClassMetadata')->willReturn($fakeClassMetaData);

        $query = new Query($em);
        $aclHelper = $this->createMock(AclHelper::class);
        $aclHelper->expects($this->once())->method('apply')->willReturn($query);
        $mirror = new ReflectionClass(AbstractDoctrineORMAdminListConfigurator::class);
        $property = $mirror->getProperty('aclHelper');
        $property->setAccessible(true);
        $property->setValue($config, $aclHelper);
        $property = $mirror->getProperty('permissionDef');
        $property->setAccessible(true);
        $property->setValue($config, new PermissionDefinition(['admin']));

        $qb->expects($this->any())->method('getQuery')->willReturn($query);
        $query = $config->getQuery();
        $this->assertInstanceOf(Query::class, $query);
    }
}


1		<?php
2
3		namespace Kunstmaan\AdminListBundle\Tests\AdminList\Configurator;
4
5		use ArrayIterator;
6		use Codeception\Stub;
7		use Doctrine\Common\Persistence\Mapping\ClassMetadata;
8		use Doctrine\DBAL\Connection;
9		use Doctrine\DBAL\Platforms\MySQL57Platform;
10		use Doctrine\ORM\AbstractQuery;
11		use Doctrine\ORM\Cache\CacheConfiguration;
12		use Doctrine\ORM\Configuration;
13		use Doctrine\ORM\EntityManager;
14		use Doctrine\ORM\Query;
15		use Doctrine\ORM\QueryBuilder;
16		use Kunstmaan\AdminBundle\Helper\Security\Acl\AclHelper;
17		use Kunstmaan\AdminBundle\Helper\Security\Acl\Permission\PermissionDefinition;
18		use Kunstmaan\AdminListBundle\AdminList\Configurator\AbstractDoctrineORMAdminListConfigurator;
19		use Kunstmaan\AdminListBundle\AdminList\Filter;
20		use Kunstmaan\AdminListBundle\AdminList\FilterBuilder;
21		use Kunstmaan\AdminListBundle\AdminList\FilterType\ORM\StringFilterType;
22		use Kunstmaan\AdminListBundle\AdminList\SortableInterface;
23		use Pagerfanta\Pagerfanta;
24		use PHPUnit\Framework\TestCase;
25		use ReflectionClass;
26		use Kunstmaan\LeadGenerationBundle\Tests\unit\Entity\Popup\Popup;
27
28		class ORM extends AbstractDoctrineORMAdminListConfigurator implements SortableInterface
29		{
30		/**
31		* @return mixed
32		*/
33		public function getBundleName()
34		{
35		return 'SomeBundle';
36		}
37
38		/**
39		* @return mixed
40		*/
41		public function getEntityName()
42		{
43		return 'SomeEntity';
44		}
45
46		/**
47		* @return mixed
48		*/
49		public function buildFields()
50		{
51		return true;
52		}
53
54		/**
55		* @return string
56		*/
57		public function getSortableField()
58		{
59		return 'sortfield';
60		}
61		}
62
63		class AbstractDoctrineORMAdminListConfiguratorTest extends TestCase
		0 ignored issues – show Coding Style Compatibility introduced 2019-01-31 09:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history...
64		{
65		/** @var ORM $config */
66		private $config;
67
68		/** @var \PHPUnit_Framework_MockObject_MockObject $em */
69		private $em;
70
71		/**
72		* @throws \ReflectionException
73		*/
74		public function setUp()
75		{
76		$em = $this->createMock(EntityManager::class);
77		$this->em = $em;
78		$this->config = new ORM($em);
79
80		$mirror = new ReflectionClass(AbstractDoctrineORMAdminListConfigurator::class);
81		$property = $mirror->getProperty('orderBy');
82		$property->setAccessible(true);
83		$property->setValue($this->config, 'somefield');
84		}
85
86		public function testGetSetEntityManager()
87		{
88		$config = $this->config;
89		$em = $this->createMock(EntityManager::class);
90		$config->setEntityManager($em);
91		$this->assertInstanceOf(EntityManager::class, $config->getEntityManager());
92		}
93
94		public function testGetSetPermissionDefinition()
95		{
96		$config = $this->config;
97		$this->assertNull($config->getPermissionDefinition());
98		$config->setPermissionDefinition(new PermissionDefinition(['something']));
99		$this->assertInstanceOf(PermissionDefinition::class, $config->getPermissionDefinition());
100		}
101
102		public function testGetQuery()
103		{
104		$config = $this->config;
105		$em = $this->em;
106		$filterBuilder = $this->createMock(FilterBuilder::class);
107		$filterBuilder->expects($this->once())->method('getCurrentFilters')->willReturn([new Filter('whatever', ['type' => new StringFilterType('whatever')], uniqid())]);
108		$config->setFilterBuilder($filterBuilder);
109		$cacheConfig = $this->createMock(CacheConfiguration::class);
110		$cacheConfig->expects($this->any())->method('getCacheLogger')->willReturn('whatever');
111		$fakeConfig = $this->createMock(Configuration::class);
112		$fakeConfig->expects($this->any())->method('getDefaultQueryHints')->willReturn($fakeConfig);
113		$fakeConfig->expects($this->any())->method('isSecondLevelCacheEnabled')->willReturn($fakeConfig);
114		$fakeConfig->expects($this->any())->method('getSecondLevelCacheConfiguration')->willReturn($cacheConfig);
115		$fakeClassMetaData = Stub::makeEmpty(ClassMetadata::class, ['hasAssociation' => false]);
116		$qb = $this->createMock(QueryBuilder::class);
117		$qb->expects($this->any())->method('setParameters')->willReturn($qb);
118		$qb->expects($this->any())->method('setMaxResults')->willReturn($qb);
119		$em->expects($this->any())->method('createQuery')->willReturn($qb);
120		$em->expects($this->any())->method('getRepository')->willReturn($em);
121		$em->expects($this->any())->method('createQueryBuilder')->willReturn($qb);
122		$em->expects($this->any())->method('getConfiguration')->willReturn($fakeConfig);
123		$em->expects($this->any())->method('getClassMetadata')->willReturn($fakeClassMetaData);
124		$query = new Query($em);
125		$qb->expects($this->any())->method('getQuery')->willReturn($query);
126		$query = $config->getQuery();
127		$this->assertInstanceOf(Query::class, $query);
128		}
129
130	View Code Duplication	public function testEditUrlFor()
131		{
132		$config = $this->config;
133		$item = new Popup();
134		$item->setId(666);
135		$url = $config->getEditUrlFor($item);
136		$this->assertCount(2, $url);
137		$this->assertArrayHasKey('path', $url);
138		$this->assertArrayHasKey('params', $url);
139		$this->assertArrayHasKey('id', $url['params']);
140		$this->assertEquals('somebundle_admin_someentity_edit', $url['path']);
141		$this->assertCount(1, $url['params']);
142		$this->assertEquals(666, $url['params']['id']);
143		}
144
145	View Code Duplication	public function testDeleteUrlFor()
146		{
147		$config = $this->config;
148		$item = new Popup();
149		$item->setId(666);
150		$url = $config->getDeleteUrlFor($item);
151		$this->assertCount(2, $url);
152		$this->assertArrayHasKey('path', $url);
153		$this->assertArrayHasKey('params', $url);
154		$this->assertArrayHasKey('id', $url['params']);
155		$this->assertEquals('somebundle_admin_someentity_delete', $url['path']);
156		$this->assertCount(1, $url['params']);
157		$this->assertEquals(666, $url['params']['id']);
158		}
159
160		/**
161		* @throws \ReflectionException
162		*/
163		public function testGetPagerFanta()
164		{
165		$config = $this->config;
166		$em = $this->em;
167
168		$cacheConfig = $this->createMock(CacheConfiguration::class);
169		$cacheConfig->expects($this->any())->method('getCacheLogger')->willReturn('whatever');
170
171		$fakeConfig = $this->createMock(Configuration::class);
172		$fakeConfig->expects($this->any())->method('getDefaultQueryHints')->willReturn(['doctrine_paginator.distinct' => 'blah']);
173		$fakeConfig->expects($this->any())->method('isSecondLevelCacheEnabled')->willReturn($fakeConfig);
174		$fakeConfig->expects($this->any())->method('getSecondLevelCacheConfiguration')->willReturn($cacheConfig);
175
176		$platform = $this->createMock(MySQL57Platform::class);
177		$platform->expects($this->any())->method('getSQLResultCasing')->willReturn('string');
178
179		$fakeClassMetaData = Stub::makeEmpty(ClassMetadata::class, ['hasAssociation' => false]);
180		$connection = $this->createMock(Connection::class);
181		$connection->expects($this->any())->method('getDatabasePlatform')->willReturn($platform);
182
183		$qb = $this->createMock(QueryBuilder::class);
184		$qb->expects($this->any())->method('setParameters')->willReturn($qb);
185		$qb->expects($this->any())->method('setMaxResults')->willReturn($qb);
186		$em->expects($this->any())->method('createQuery')->willReturn($qb);
187		$em->expects($this->any())->method('getRepository')->willReturn($em);
188		$em->expects($this->any())->method('createQueryBuilder')->willReturn($qb);
189		$em->expects($this->any())->method('getConfiguration')->willReturn($fakeConfig);
190		$em->expects($this->any())->method('getConnection')->willReturn($connection);
191		$em->expects($this->any())->method('getClassMetadata')->willReturn($fakeClassMetaData);
192		$qb->expects($this->any())->method('getQuery')->willReturn(new Query($em));
193
194		$pager = $config->getPagerfanta();
195		$this->assertInstanceOf(Pagerfanta::class, $pager);
196
197		$pager = $this->createMock(Pagerfanta::class);
198		$pager->expects($this->once())->method('getNbResults')->willReturn(5);
199		$pager->expects($this->once())->method('getCurrentPageResults')->willReturn([1, 2, 3, 4, 5]);
200
201		$mirror = new ReflectionClass(AbstractDoctrineORMAdminListConfigurator::class);
202		$property = $mirror->getProperty('pagerfanta');
203		$property->setAccessible(true);
204		$property->setValue($config, $pager);
205
206		$count = $config->getCount();
207		$this->assertEquals(5, $count);
208
209		$items = $config->getItems();
210		$this->assertCount(5, $items);
211		}
212
213		/**
214		* @throws \ReflectionException
215		*/
216	View Code Duplication	public function testGetIterator()
217		{
218		$config = $this->config;
219		$query = $this->createMock(AbstractQuery::class);
220		$query->expects($this->once())->method('iterate')->willReturn(new ArrayIterator());
221
222		$mirror = new ReflectionClass(AbstractDoctrineORMAdminListConfigurator::class);
223		$property = $mirror->getProperty('query');
224		$property->setAccessible(true);
225		$property->setValue($config, $query);
226
227		$it = $config->getIterator();
228		$this->assertInstanceOf(ArrayIterator::class, $it);
229		}
230
231		/**
232		* @throws \ReflectionException
233		* @throws \Exception
234		*/
235		public function testGetQueryWithAclEnabled()
236		{
237		$config = $this->config;
238		$em = $this->em;
239
240		$cacheConfig = $this->createMock(CacheConfiguration::class);
241		$cacheConfig->expects($this->any())->method('getCacheLogger')->willReturn('whatever');
242		$fakeConfig = $this->createMock(Configuration::class);
243		$fakeConfig->expects($this->any())->method('getDefaultQueryHints')->willReturn($fakeConfig);
244		$fakeConfig->expects($this->any())->method('isSecondLevelCacheEnabled')->willReturn($fakeConfig);
245		$fakeConfig->expects($this->any())->method('getSecondLevelCacheConfiguration')->willReturn($cacheConfig);
246		$qb = $this->createMock(QueryBuilder::class);
247		$fakeClassMetaData = Stub::makeEmpty(ClassMetadata::class, ['hasAssociation' => false]);
248		$qb->expects($this->any())->method('setParameters')->willReturn($qb);
249		$qb->expects($this->any())->method('setMaxResults')->willReturn($qb);
250		$em->expects($this->any())->method('createQuery')->willReturn($qb);
251		$em->expects($this->any())->method('getRepository')->willReturn($em);
252		$em->expects($this->any())->method('createQueryBuilder')->willReturn($qb);
253		$em->expects($this->any())->method('getConfiguration')->willReturn($fakeConfig);
254		$em->expects($this->any())->method('getClassMetadata')->willReturn($fakeClassMetaData);
255
256		$query = new Query($em);
257		$aclHelper = $this->createMock(AclHelper::class);
258		$aclHelper->expects($this->once())->method('apply')->willReturn($query);
259		$mirror = new ReflectionClass(AbstractDoctrineORMAdminListConfigurator::class);
260		$property = $mirror->getProperty('aclHelper');
261		$property->setAccessible(true);
262		$property->setValue($config, $aclHelper);
263		$property = $mirror->getProperty('permissionDef');
264		$property->setAccessible(true);
265		$property->setValue($config, new PermissionDefinition(['admin']));
266
267		$qb->expects($this->any())->method('getQuery')->willReturn($query);
268		$query = $config->getQuery();
269		$this->assertInstanceOf(Query::class, $query);
270		}
271		}
272

Kunstmaan / KunstmaanBundlesCMS

Push — master ( 1de9b7...830752 )

AbstractDoctrineORMAdminListConfiguratorTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like