Completed
Push — master ( 1de9b7...830752 )
by Kristof
38:46 queued 24:09
created

AdminBundle/Helper/Menu/MenuAdaptorInterface.php (2 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
3
namespace Kunstmaan\AdminBundle\Helper\Menu;
4
5
use Symfony\Component\HttpFoundation\Request;
6
7
/**
8
 * The menu adaptor can be used to configure the main menu, to do this you need to implement this interface and tag
9
 * your interface with 'kunstmaan_admin.menu.adaptor'
10
 */
11
interface MenuAdaptorInterface
12
{
13
    /**
14
     * In this method you can add children for a specific parent, but also remove and change the already created children
15
     *
16
     * @param MenuBuilder   $menu      The MenuBuilder
17
     * @param MenuItem[]    &$children The current children
18
     * @param MenuItem|null $parent    The parent Menu item
19
     * @param Request       $request   The Request
0 ignored issues
show
Should the type for parameter $request not be null|Request?

This check looks for @param annotations where the type inferred by our type inference engine differs from the declared type.

It makes a suggestion as to what type it considers more descriptive.

Most often this is a case of a parameter that can be null in addition to its declared types.

Loading history...
20
     */
21
    public function adaptChildren(MenuBuilder $menu, array &$children, MenuItem $parent = null, Request $request = null);
0 ignored issues
show
For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a @return doc comment to communicate to implementors of these methods what they are expected to return.

Loading history...
22
}
23