ModulesMenuAdaptor::adaptChildren() - Code Metrics - Inspection of "Merge pull request #2335 from acrobat/fixed-remain..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1de9b7...830752 )

by Kristof

created 2019-02-06 14:09 UTC

ModulesMenuAdaptor::adaptChildren() A

↳ Parent: ModulesMenuAdaptor

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	12
Ratio	80 %

Importance

Changes

Metric	Value
dl	12
loc	15
rs	9.7666
c	0
b	0
f	0
cc	3
nc	3
nop	4

<?php

namespace Kunstmaan\AdminBundle\Helper\Menu;

use Symfony\Component\HttpFoundation\Request;

/**
 * MenuAdaptor to add the Modules MenuItem to the top menu
 */
class ModulesMenuAdaptor implements MenuAdaptorInterface
{
    /**
     * In this method you can add children for a specific parent, but also remove and change the already created children
     *
     * @param MenuBuilder $menu      The MenuBuilder
     * @param MenuItem[]  &$children The current children
     * @param MenuItem    $parent    The parent Menu item

     * @param Request     $request   The Request

     */
    public function adaptChildren(MenuBuilder $menu, array &$children, MenuItem $parent = null, Request $request = null)
    {
        if (is_null($parent)) {

            $menuItem = new TopMenuItem($menu);
            $menuItem
                ->setRoute('KunstmaanAdminBundle_modules')
                ->setLabel('modules.title')
                ->setUniqueId('modules')
                ->setParent($parent);
            if (stripos($request->attributes->get('_route'), $menuItem->getRoute()) === 0) {
                $menuItem->setActive(true);
            }
            $children[] = $menuItem;
        }
    }
}


1		<?php
2
3		namespace Kunstmaan\AdminBundle\Helper\Menu;
4
5		use Symfony\Component\HttpFoundation\Request;
6
7		/**
8		* MenuAdaptor to add the Modules MenuItem to the top menu
9		*/
10		class ModulesMenuAdaptor implements MenuAdaptorInterface
11		{
12		/**
13		* In this method you can add children for a specific parent, but also remove and change the already created children
14		*
15		* @param MenuBuilder $menu The MenuBuilder
16		* @param MenuItem[] &$children The current children
17		* @param MenuItem $parent The parent Menu item
		0 ignored issues – show Documentation introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Should the type for parameter `$parent` not be `null\|MenuItem`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
18		* @param Request $request The Request
		0 ignored issues – show Documentation introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Should the type for parameter `$request` not be `null\|Request`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
19		*/
20		public function adaptChildren(MenuBuilder $menu, array &$children, MenuItem $parent = null, Request $request = null)
21		{
22	View Code Duplication	if (is_null($parent)) {
		0 ignored issues – show Duplication introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		$menuItem = new TopMenuItem($menu);
24		$menuItem
25		->setRoute('KunstmaanAdminBundle_modules')
26		->setLabel('modules.title')
27		->setUniqueId('modules')
28		->setParent($parent);
29		if (stripos($request->attributes->get('_route'), $menuItem->getRoute()) === 0) {
30		$menuItem->setActive(true);
31		}
32		$children[] = $menuItem;
33		}
34		}
35		}
36

Kunstmaan / KunstmaanBundlesCMS

Push — master ( 1de9b7...830752 )

ModulesMenuAdaptor::adaptChildren() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like