Kunstmaan\TranslatorBundle\Command\ImportTranslationsFromFileCommand

Complexity

Total Complexity

4

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	5

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	configure()	0	8	1
A	execute()	0	13	2

<?php

namespace Kunstmaan\TranslatorBundle\Command;

use Kunstmaan\TranslatorBundle\Service\Command\Importer\Importer;
use Kunstmaan\TranslatorBundle\Service\Translator\Translator;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Exception\LogicException;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Translation\TranslatorInterface;

/**
 * Class ImportTranslationsFromFileCommand
 */
final class ImportTranslationsFromFileCommand extends Command
{
    /** @var Importer */
    private $importer;

    /** @var TranslatorInterface */
    private $translator;

    /** @var array */
    private $locales;

    /**
     * ImportTranslationsFromFileCommand constructor.
     *
     * @param Importer   $importer
     * @param Translator $translator

Should the type for parameter $translator not be TranslatorInterface?

     * @param            $locales
     */
    public function __construct(Importer $importer, TranslatorInterface $translator, $locales)
    {
        parent::__construct();
        $this->importer = $importer;
        $this->translator = $translator;
        $this->locales = $locales;
    }

    /**
     * Configures this command
     */
    protected function configure()
    {
        $this
            ->setName('kuma:translator:import-file')
            ->setDescription('Import file with translations, supported formats are xlsx, ods, csv')
            ->addArgument('file', InputArgument::REQUIRED, 'The full path of the file')
            ->addOption('force', 'f', InputOption::VALUE_NONE, 'Force import, overwrite all existing database entries');
    }

    /**
     * @throws LogicException
     *
     * @param InputInterface  $input
     * @param OutputInterface $output
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $file = $input->getArgument('file');
        $force = $input->getOption('force');

        $this->importer->importFromSpreadsheet($file, $this->locales, $force);

It seems like $file defined by $input->getArgument('file') on line 64 can also be of type array<integer,string> or null; however, Kunstmaan\TranslatorBundle\Service\Command\Importer\Importer::importFromSpreadsheet() does only seem to accept string, maybe add an additional type check?

        if ($force) {
            $confirmation = $this->translator->trans('kuma_translator.command.import.flash.force_success');
        } else {
            $confirmation = $this->translator->trans('kuma_translator.command.import.flash.success');
        }
        $output->writeln($confirmation);
    }
}