Kunstmaan\AdminBundle\EventListener\ExceptionSubscriber::onKernelException()

Complexity

Conditions	10
Paths	13

Size

Total Lines

40

Duplication

Lines	3
Ratio	7.5 %

Code Coverage

Tests	0
CRAP Score	110

Importance

Changes

0

<?php
    public function onKernelException($event)
    {
        if (!$event instanceof GetResponseForExceptionEvent && !$event instanceof ExceptionEvent) {

This code seems to be duplicated across your project.

            throw new \InvalidArgumentException(\sprintf('Expected instance of type %s, %s given', \class_exists(ExceptionEvent::class) ? ExceptionEvent::class : GetResponseForExceptionEvent::class, \is_object($event) ? \get_class($event) : \gettype($event)));
        }

        $request = $event->getRequest();
        $exception = \method_exists($event, 'getThrowable') ? $event->getThrowable() : $event->getException();

The method Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent::getException() has been deprecated with message: since Symfony 4.4, use getThrowable instead

        if ($exception instanceof HttpExceptionInterface) {
            $uri = $request->getUri();

            if (count($this->excludes) > 0) {
                $excludes = array_filter($this->excludes, function ($pattern) use ($uri) {
                    return preg_match($pattern, $uri);
                });

                if (count($excludes) > 0) {
                    return;
                }
            }

            $hash = md5(
                $exception->getStatusCode().$uri.$request->headers->get('referer')
            );

            if ($model = $this->em->getRepository(Exception::class)->findOneBy(['hash' => $hash])) {
                $model->increaseEvents();
                $model->setResolved(false);
            } else {
                $model = new Exception();
                $model->setCode($exception->getStatusCode());
                $model->setUrl($uri);
                $model->setUrlReferer($request->headers->get('referer'));

It seems like $request->headers->get('referer') targeting Symfony\Component\HttpFoundation\HeaderBag::get() can also be of type array or null; however, Kunstmaan\AdminBundle\Entity\Exception::setUrlReferer() does only seem to accept string, maybe add an additional type check?

                $model->setHash($hash);
            }
            $this->em->persist($model);
            $this->em->flush();
        }
    }
}