Issues in MigrationsDiffCommand.php - All Issues - Inspection of "Bump minimum php version to 7.1 (#2090)" - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1b817e...6c15b7 )

by Jeroen

created 2018-11-30 09:17 UTC

TranslatorBundle/Command/MigrationsDiffCommand.php (2 issues)

Labels

Severity

Minor 2

Joeri Verdeyen 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\TranslatorBundle\Command;

use Doctrine\Bundle\DoctrineBundle\Command\Proxy\DoctrineCommandHelper;
use Doctrine\Bundle\MigrationsBundle\Command\DoctrineCommand;
use Kunstmaan\TranslatorBundle\Service\Command\DiffCommand;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Command for generate migration classes by checking the translation flag value
 *
 * @final since 5.1
 */
class MigrationsDiffCommand extends DiffCommand
{
    protected function configure()
    {
        parent::configure();

        $this
            ->setName('kuma:translator:migrations:diff')
            ->addOption('em', null, InputOption::VALUE_OPTIONAL, 'The entity manager to use for this command.')
        ;
    }

    public function execute(InputInterface $input, OutputInterface $output)
    {
        DoctrineCommandHelper::setApplicationEntityManager($this->getApplication(), $input->getOption('em'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $configuration = $this->getMigrationConfiguration($input, $output);
        DoctrineCommand::configureMigrations($this->getApplication()->getKernel()->getContainer(), $configuration);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        parent::execute($input, $output);
    }
}


Push — master ( 1b817e...6c15b7 )

TranslatorBundle/Command/MigrationsDiffCommand.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

1			<?php
2
3			namespace Kunstmaan\TranslatorBundle\Command;
4
5			use Doctrine\Bundle\DoctrineBundle\Command\Proxy\DoctrineCommandHelper;
6			use Doctrine\Bundle\MigrationsBundle\Command\DoctrineCommand;
7			use Kunstmaan\TranslatorBundle\Service\Command\DiffCommand;
8			use Symfony\Component\Console\Input\InputInterface;
9			use Symfony\Component\Console\Input\InputOption;
10			use Symfony\Component\Console\Output\OutputInterface;
11
12			/**
13			* Command for generate migration classes by checking the translation flag value
14			*
15			* @final since 5.1
16			*/
17			class MigrationsDiffCommand extends DiffCommand
18			{
19			protected function configure()
20			{
21			parent::configure();
22
23			$this
24			->setName('kuma:translator:migrations:diff')
25			->addOption('em', null, InputOption::VALUE_OPTIONAL, 'The entity manager to use for this command.')
26			;
27			}
28
29			public function execute(InputInterface $input, OutputInterface $output)
30			{
31			DoctrineCommandHelper::setApplicationEntityManager($this->getApplication(), $input->getOption('em'));
			0 ignored issues – show Documentation introduced 2018-04-18 14:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->getApplication()` is of type `object<Symfony\Component...nsole\Application>\|null`, but the function expects a `object<Symfony\Bundle\Fr...le\Console\Application>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32
33			$configuration = $this->getMigrationConfiguration($input, $output);
34			DoctrineCommand::configureMigrations($this->getApplication()->getKernel()->getContainer(), $configuration);
			0 ignored issues – show Bug introduced 2018-04-18 14:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a specific sub-type and not the parent class `Symfony\Component\Console\Application` as the method `getKernel()` does only exist in the following sub-classes of `Symfony\Component\Console\Application`: `Symfony\Bundle\FrameworkBundle\Console\Application`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
35
36			parent::execute($input, $output);
37			}
38			}
39

Kunstmaan / KunstmaanBundlesCMS

Push — master ( 1b817e...6c15b7 )

TranslatorBundle/Command/MigrationsDiffCommand.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like