Issues in Configuration.php - All Issues - Inspection of "Merge branch '5.3'" - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 770316...74fc07 )

by Jeroen

created 2019-10-18 13:07 UTC

DependencyInjection/Configuration.php (1 issue)

Labels

Deprecated Code 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\TranslatorBundle\DependencyInjection;

use Symfony\Component\Config\Definition\Builder\TreeBuilder;
use Symfony\Component\Config\Definition\ConfigurationInterface;

/**
 * This is the class that validates and merges configuration from your app/config files
 *
 * To learn more see {@link http://symfony.com/doc/current/cookbook/bundles/extension.html#cookbook-bundles-extension-config-class}
 */
class Configuration implements ConfigurationInterface
{
    /**
     * {@inheritdoc}
     */
    public function getConfigTreeBuilder()
    {
        $treeBuilder = new TreeBuilder('kuma_translator');
        if (method_exists($treeBuilder, 'getRootNode')) {
            $rootNode = $treeBuilder->getRootNode();
        } else {
            // BC layer for symfony/config 4.1 and older
            $rootNode = $treeBuilder->root('kuma_translator');

        }

        $availableStorageEngines = ['orm'];
        $defaultFileFormats = ['yml', 'yaml', 'xliff'];

        $rootNode
            ->children()
                ->booleanNode('enabled')
                    ->defaultTrue()
                ->end()

                ->scalarNode('default_bundle')
                    ->cannotBeEmpty()
                    ->defaultValue('own')
                ->end()

                ->arrayNode('bundles')
                    ->defaultValue(array())
                    ->prototype('scalar')->end()
                ->end()

                ->scalarNode('cache_dir')
                    ->cannotBeEmpty()
                    ->defaultValue('%kernel.cache_dir%/translations')
                ->end()

                ->booleanNode('debug')
                    ->defaultValue(null)
                ->end()

                ->arrayNode('managed_locales')
                    ->defaultValue(array())
                    ->prototype('scalar')->end()
                ->end()

                ->arrayNode('file_formats')
                    ->defaultValue($defaultFileFormats)
                    ->prototype('scalar')->end()
                ->end()

                ->arrayNode('storage_engine')
                    ->addDefaultsIfNotSet()
                    ->children()
                        ->scalarNode('type')
                            ->cannotBeEmpty()
                            ->defaultValue('orm')
                            ->validate()
                                ->ifNotInArray($availableStorageEngines)
                                ->thenInvalid('Storage engine should be one of the following: '.implode(', ', $availableStorageEngines))
                            ->end()
                        ->end()
                    ->end()
                ->end()
            ->end()
        ;

        return $treeBuilder;
    }
}


1		<?php
2
3		namespace Kunstmaan\TranslatorBundle\DependencyInjection;
4
5		use Symfony\Component\Config\Definition\Builder\TreeBuilder;
6		use Symfony\Component\Config\Definition\ConfigurationInterface;
7
8		/**
9		* This is the class that validates and merges configuration from your app/config files
10		*
11		* To learn more see {@link http://symfony.com/doc/current/cookbook/bundles/extension.html#cookbook-bundles-extension-config-class}
12		*/
13		class Configuration implements ConfigurationInterface
14		{
15		/**
16		* {@inheritdoc}
17		*/
18	5	public function getConfigTreeBuilder()
19		{
20	5	$treeBuilder = new TreeBuilder('kuma_translator');
21	5	if (method_exists($treeBuilder, 'getRootNode')) {
22	5	$rootNode = $treeBuilder->getRootNode();
23		} else {
24		// BC layer for symfony/config 4.1 and older
25		$rootNode = $treeBuilder->root('kuma_translator');
		0 ignored issues – show Deprecated Code introduced 2019-07-02 09:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `Symfony\Component\Config...der\TreeBuilder::root()` has been deprecated with message: since Symfony 4.3, pass the root name to the constructor instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
26		}
27
28	5	$availableStorageEngines = ['orm'];
29	5	$defaultFileFormats = ['yml', 'yaml', 'xliff'];
30
31		$rootNode
32	5	->children()
33	5	->booleanNode('enabled')
34	5	->defaultTrue()
35	5	->end()
36
37	5	->scalarNode('default_bundle')
38	5	->cannotBeEmpty()
39	5	->defaultValue('own')
40	5	->end()
41
42	5	->arrayNode('bundles')
43	5	->defaultValue(array())
44	5	->prototype('scalar')->end()
45	5	->end()
46
47	5	->scalarNode('cache_dir')
48	5	->cannotBeEmpty()
49	5	->defaultValue('%kernel.cache_dir%/translations')
50	5	->end()
51
52	5	->booleanNode('debug')
53	5	->defaultValue(null)
54	5	->end()
55
56	5	->arrayNode('managed_locales')
57	5	->defaultValue(array())
58	5	->prototype('scalar')->end()
59	5	->end()
60
61	5	->arrayNode('file_formats')
62	5	->defaultValue($defaultFileFormats)
63	5	->prototype('scalar')->end()
64	5	->end()
65
66	5	->arrayNode('storage_engine')
67	5	->addDefaultsIfNotSet()
68	5	->children()
69	5	->scalarNode('type')
70	5	->cannotBeEmpty()
71	5	->defaultValue('orm')
72	5	->validate()
73	5	->ifNotInArray($availableStorageEngines)
74	5	->thenInvalid('Storage engine should be one of the following: '.implode(', ', $availableStorageEngines))
75	5	->end()
76	5	->end()
77	5	->end()
78	5	->end()
79	5	->end()
80		;
81
82	5	return $treeBuilder;
83		}
84		}
85

Kunstmaan / KunstmaanBundlesCMS

Push — master ( 770316...74fc07 )

DependencyInjection/Configuration.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like