Kunstmaan / KunstmaanBundlesCMS

src/Kunstmaan/AdminListBundle/Controller/EntityLockCheckController.php

<?php

namespace Kunstmaan\AdminListBundle\Controller;

use Kunstmaan\AdminListBundle\Service\EntityVersionLockService;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;

/**
 * EntityLockCheckController
 */
class EntityLockCheckController extends Controller

The class Symfony\Bundle\FrameworkBundle\Controller\Controller has been deprecated with message: since Symfony 4.2, use "Symfony\Bundle\FrameworkBundle\Controller\AbstractController" instead.

{
    /**
     * You can override this method to return the correct entity manager when using multiple databases ...
     *
     * @return \Doctrine\Common\Persistence\ObjectManager|object

Consider making the return type a bit more specific; maybe use \Doctrine\Common\Persistence\ObjectManager.

     */
    protected function getEntityManager()
    {
        return $this->getDoctrine()->getManager();
    }

    /**
     * @Route(
     *      "check/{id}/{repository}",
     *      requirements={"id" = "\d+"},
     *      name="KunstmaanAdminListBundle_entity_lock_check"
     * )
     *
     * @param Request $request
     * @param $id
     * @param $repository
     *
     * @return JsonResponse
     */
    public function checkAction(Request $request, $id, $repository)
    {
        $entityIsLocked = false;
        $message = '';

        /** @var LockableEntityInterface $entity */
        $entity = $this->getEntityManager()->getRepository($repository)->find($id);

        try {
            /** @var EntityVersionLockService $entityVersionLockservice */
            $entityVersionLockService = $this->get('kunstmaan_entity.admin_entity.entity_version_lock_service');

            $entityIsLocked = $entityVersionLockService->isEntityLocked($this->getUser(), $entity);

            if ($entityIsLocked) {
                $user = $entityVersionLockService->getUsersWithEntityVersionLock($entity, $this->getUser());
                $message = $this->get('translator')->trans('kuma_admin_list.edit.flash.locked', array('%user%' => implode(', ', $user)));
            }
        } catch (AccessDeniedException $ade) {

Consider adding a comment why this CATCH block is empty.

        }

        return new JsonResponse(['lock' => $entityIsLocked, 'message' => $message]);
    }
}