Issues in SessionSecurityListenerTest.php - All Issues - Inspection of "Merge branch '5.3'" - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 770316...74fc07 )

by Jeroen

created 2019-10-18 13:07 UTC

unit/EventListener/SessionSecurityListenerTest.php (2 issues)

Labels

Severity

Informational 2

Ruud Denivel 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\AdminBundle\Tests\EventListener;

use Kunstmaan\AdminBundle\EventListener\SessionSecurityListener;
use PHPUnit\Framework\TestCase;
use Psr\Log\LoggerInterface;
use Symfony\Component\HttpFoundation\HeaderBag;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\ServerBag;
use Symfony\Component\HttpFoundation\Session\Session;
use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
use Symfony\Component\HttpKernel\Event\GetResponseEvent;
use Symfony\Component\HttpKernel\HttpKernelInterface;

class SessionSecurityListenerTest extends TestCase
{
    public function testOnKernelRequest()

    {
        $logger = $this->createMock(LoggerInterface::class);
        $request = $this->createMock(Request::class);
        $request->server = $this->createMock(ServerBag::class);
        $request->headers = $this->createMock(HeaderBag::class);

        $event = $this->createMock(GetResponseEvent::class);
        $session = $this->createMock(Session::class);

        $event->expects($this->any())->method('getRequestType')->willReturn(HttpKernelInterface::MASTER_REQUEST);
        $event->expects($this->any())->method('getRequest')->willReturn($request);
        $request->expects($this->once())->method('hasSession')->willReturn(true);
        $request->expects($this->exactly(2))->method('getSession')->willReturn($session);
        $request->server->expects($this->any())->method('get')->will($this->onConsecutiveCalls('Session ip', 'kuma_ua'));
        $request->headers->expects($this->any())->method('get')->willReturn('kuma_ua');
        $session->expects($this->once())->method('isStarted')->willReturn(true);
        $session->expects($this->any())->method('has')->willReturn(true);

        $listener = new SessionSecurityListener(true, true, $logger);
        $listener->onKernelRequest($event);

        $event = $this->createMock(GetResponseEvent::class);
        $listener->onKernelRequest($event);
    }

    public function testOnKernelResponse()

    {
        $logger = $this->createMock(LoggerInterface::class);
        $request = $this->createMock(Request::class);
        $request->server = $this->createMock(ServerBag::class);
        $request->headers = $this->createMock(HeaderBag::class);

        $event = $this->createMock(FilterResponseEvent::class);
        $session = $this->createMock(Session::class);

        $event->expects($this->any())->method('getRequestType')->willReturn(HttpKernelInterface::MASTER_REQUEST);
        $event->expects($this->any())->method('getRequest')->willReturn($request);
        $request->expects($this->once())->method('hasSession')->willReturn(true);
        $request->expects($this->exactly(2))->method('getSession')->willReturn($session);
        $request->server->expects($this->any())->method('get')->will($this->onConsecutiveCalls('Session ip', 'kuma_ua'));
        $request->headers->expects($this->any())->method('get')->willReturn('kuma_ua');
        $session->expects($this->once())->method('isStarted')->willReturn(true);
        $session->expects($this->exactly(2))->method('has')->willReturn(false);

        $listener = new SessionSecurityListener(true, true, $logger);
        $listener->onKernelResponse($event);

        $event = $this->createMock(FilterResponseEvent::class);
        $listener->onKernelResponse($event);
    }

    public function testInvalidateSessionWithNoIpSet()
    {
        $logger = $this->createMock(LoggerInterface::class);
        $request = $this->createMock(Request::class);
        $request->server = $this->createMock(ServerBag::class);
        $request->headers = $this->createMock(HeaderBag::class);

        $event = $this->createMock(FilterResponseEvent::class);
        $session = $this->createMock(Session::class);

        $event->expects($this->any())->method('getRequestType')->willReturn(HttpKernelInterface::MASTER_REQUEST);
        $event->expects($this->any())->method('getRequest')->willReturn($request);
        $request->expects($this->once())->method('hasSession')->willReturn(true);
        $request->expects($this->exactly(2))->method('getSession')->willReturn($session);
        $request->expects($this->once())->method('getClientIp')->willReturn('95.154.243.5');
        $request->server->expects($this->any())->method('get')->willReturn('');
        $request->headers->expects($this->any())->method('get')->willReturn('kuma_ua');
        $session->expects($this->once())->method('isStarted')->willReturn(true);
        $session->expects($this->exactly(2))->method('has')->willReturn(false);

        $listener = new SessionSecurityListener(true, true, $logger);
        $listener->onKernelResponse($event);
    }
}


1		<?php
2
3		namespace Kunstmaan\AdminBundle\Tests\EventListener;
4
5		use Kunstmaan\AdminBundle\EventListener\SessionSecurityListener;
6		use PHPUnit\Framework\TestCase;
7		use Psr\Log\LoggerInterface;
8		use Symfony\Component\HttpFoundation\HeaderBag;
9		use Symfony\Component\HttpFoundation\Request;
10		use Symfony\Component\HttpFoundation\ServerBag;
11		use Symfony\Component\HttpFoundation\Session\Session;
12		use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
13		use Symfony\Component\HttpKernel\Event\GetResponseEvent;
14		use Symfony\Component\HttpKernel\HttpKernelInterface;
15
16		class SessionSecurityListenerTest extends TestCase
17		{
18	View Code Duplication	public function testOnKernelRequest()
		0 ignored issues – show Duplication introduced 2018-04-18 14:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19		{
20		$logger = $this->createMock(LoggerInterface::class);
21		$request = $this->createMock(Request::class);
22		$request->server = $this->createMock(ServerBag::class);
23		$request->headers = $this->createMock(HeaderBag::class);
24
25		$event = $this->createMock(GetResponseEvent::class);
26		$session = $this->createMock(Session::class);
27
28		$event->expects($this->any())->method('getRequestType')->willReturn(HttpKernelInterface::MASTER_REQUEST);
29		$event->expects($this->any())->method('getRequest')->willReturn($request);
30		$request->expects($this->once())->method('hasSession')->willReturn(true);
31		$request->expects($this->exactly(2))->method('getSession')->willReturn($session);
32		$request->server->expects($this->any())->method('get')->will($this->onConsecutiveCalls('Session ip', 'kuma_ua'));
33		$request->headers->expects($this->any())->method('get')->willReturn('kuma_ua');
34		$session->expects($this->once())->method('isStarted')->willReturn(true);
35		$session->expects($this->any())->method('has')->willReturn(true);
36
37		$listener = new SessionSecurityListener(true, true, $logger);
38		$listener->onKernelRequest($event);
39
40		$event = $this->createMock(GetResponseEvent::class);
41		$listener->onKernelRequest($event);
42		}
43
44	View Code Duplication	public function testOnKernelResponse()
		0 ignored issues – show Duplication introduced 2018-04-18 14:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45		{
46		$logger = $this->createMock(LoggerInterface::class);
47		$request = $this->createMock(Request::class);
48		$request->server = $this->createMock(ServerBag::class);
49		$request->headers = $this->createMock(HeaderBag::class);
50
51		$event = $this->createMock(FilterResponseEvent::class);
52		$session = $this->createMock(Session::class);
53
54		$event->expects($this->any())->method('getRequestType')->willReturn(HttpKernelInterface::MASTER_REQUEST);
55		$event->expects($this->any())->method('getRequest')->willReturn($request);
56		$request->expects($this->once())->method('hasSession')->willReturn(true);
57		$request->expects($this->exactly(2))->method('getSession')->willReturn($session);
58		$request->server->expects($this->any())->method('get')->will($this->onConsecutiveCalls('Session ip', 'kuma_ua'));
59		$request->headers->expects($this->any())->method('get')->willReturn('kuma_ua');
60		$session->expects($this->once())->method('isStarted')->willReturn(true);
61		$session->expects($this->exactly(2))->method('has')->willReturn(false);
62
63		$listener = new SessionSecurityListener(true, true, $logger);
64		$listener->onKernelResponse($event);
65
66		$event = $this->createMock(FilterResponseEvent::class);
67		$listener->onKernelResponse($event);
68		}
69
70		public function testInvalidateSessionWithNoIpSet()
71		{
72		$logger = $this->createMock(LoggerInterface::class);
73		$request = $this->createMock(Request::class);
74		$request->server = $this->createMock(ServerBag::class);
75		$request->headers = $this->createMock(HeaderBag::class);
76
77		$event = $this->createMock(FilterResponseEvent::class);
78		$session = $this->createMock(Session::class);
79
80		$event->expects($this->any())->method('getRequestType')->willReturn(HttpKernelInterface::MASTER_REQUEST);
81		$event->expects($this->any())->method('getRequest')->willReturn($request);
82		$request->expects($this->once())->method('hasSession')->willReturn(true);
83		$request->expects($this->exactly(2))->method('getSession')->willReturn($session);
84		$request->expects($this->once())->method('getClientIp')->willReturn('95.154.243.5');
85		$request->server->expects($this->any())->method('get')->willReturn('');
86		$request->headers->expects($this->any())->method('get')->willReturn('kuma_ua');
87		$session->expects($this->once())->method('isStarted')->willReturn(true);
88		$session->expects($this->exactly(2))->method('has')->willReturn(false);
89
90		$listener = new SessionSecurityListener(true, true, $logger);
91		$listener->onKernelResponse($event);
92		}
93		}
94

Kunstmaan / KunstmaanBundlesCMS

Push — master ( 770316...74fc07 )

unit/EventListener/SessionSecurityListenerTest.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like