Issues in DomainConfiguration.php - All Issues - Inspection of "Merge branch '5.3'" - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 770316...74fc07 )

by Jeroen

created 2019-10-18 13:07 UTC

AdminBundle/Helper/DomainConfiguration.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\AdminBundle\Helper;

use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\HttpFoundation\RequestStack;

/**
 * Class DomainConfiguration
 *
 * Default (single domain) configuration handling
 */
class DomainConfiguration implements DomainConfigurationInterface
{
    /** @var ContainerInterface */
    protected $container;

    /** @var RequestStack */
    private $requestStack;

    /** @var bool */
    protected $multiLanguage;

    /** @var array */
    protected $requiredLocales;

    /** @var string */
    protected $defaultLocale;

    /**
     * @param ContainerInterface|string $multilanguage
     */
    public function __construct(/*ContainerInterface|RequestStack*/ $requestStack, $multilanguage = null, $defaultLocale = null, $requiredLocales = null)
    {
        if ($requestStack instanceof ContainerInterface) {
            @trigger_error('Container injection and the usage of the container is deprecated in KunstmaanNodeBundle 5.1 and will be removed in KunstmaanNodeBundle 6.0.', E_USER_DEPRECATED);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

            $this->container = $requestStack;
            $this->multiLanguage = $this->container->getParameter('kunstmaan_admin.multi_language');
            $this->defaultLocale = $this->container->getParameter('kunstmaan_admin.default_locale');
            $this->requiredLocales = explode('|', $this->container->getParameter('kunstmaan_admin.required_locales'));
            $this->requestStack = $this->container->get('request_stack');

            return;
        }

        $this->requestStack = $requestStack;
        $this->multiLanguage = $multilanguage;
        $this->defaultLocale = $defaultLocale;

        $this->requiredLocales = explode('|', $requiredLocales);
    }

    /**
     * @return string
     */
    public function getHost()
    {
        $request = $this->getMasterRequest();
        $host = is_null($request) ? '' : $request->getHost();

        return $host;
    }

    /**
     * @return array
     */
    public function getHosts()
    {
        return array($this->getHost());
    }

    /**
     * @return string
     */
    public function getDefaultLocale()
    {
        return $this->defaultLocale;
    }

    /**
     * @param string|null $host
     *
     * @return bool
     */
    public function isMultiLanguage($host = null)
    {
        return $this->multiLanguage;
    }

    /**
     * @param string|null $host
     *
     * @return array
     */
    public function getFrontendLocales($host = null)
    {
        return $this->requiredLocales;
    }

    /**
     * @param string|null $host
     *
     * @return array
     */
    public function getBackendLocales($host = null)
    {
        return $this->requiredLocales;
    }

    /**
     * @return bool
     */
    public function isMultiDomainHost()
    {
        return false;
    }

    /**
     * @param string|null $host
     */
    public function getRootNode($host = null)
    {
        return null;
    }

    /**
     * @return array
     */
    public function getExtraData()
    {
        return array();
    }

    /**
     * @return array
     */
    public function getLocalesExtraData()
    {
        return array();
    }

    /**
     * @return null|\Symfony\Component\HttpFoundation\Request
     */
    protected function getMasterRequest()
    {
        return $this->requestStack->getMasterRequest();
    }

    /**
     * @return array
     */
    public function getFullHostConfig()
    {
        return array();
    }

    /**
     * @param string|null $host
     */
    public function getFullHost($host = null)
    {
        return null;
    }

    /**
     * @param int $id
     */
    public function getFullHostById($id)
    {
        return null;
    }

    public function getHostSwitched()
    {
        return null;
    }

    /**
     * @param string|null $host
     */
    public function getHostBaseUrl($host = null)
    {
        return null;
    }
}


1			<?php
2
3			namespace Kunstmaan\AdminBundle\Helper;
4
5			use Symfony\Component\DependencyInjection\ContainerInterface;
6			use Symfony\Component\HttpFoundation\RequestStack;
7
8			/**
9			* Class DomainConfiguration
10			*
11			* Default (single domain) configuration handling
12			*/
13			class DomainConfiguration implements DomainConfigurationInterface
14			{
15			/** @var ContainerInterface */
16			protected $container;
17
18			/** @var RequestStack */
19			private $requestStack;
20
21			/** @var bool */
22			protected $multiLanguage;
23
24			/** @var array */
25			protected $requiredLocales;
26
27			/** @var string */
28			protected $defaultLocale;
29
30			/**
31			* @param ContainerInterface\|string $multilanguage
32			*/
33	43	View Code Duplication	public function __construct(/ContainerInterface\|RequestStack/ $requestStack, $multilanguage = null, $defaultLocale = null, $requiredLocales = null)
34			{
35	43		if ($requestStack instanceof ContainerInterface) {
36	43		@trigger_error('Container injection and the usage of the container is deprecated in KunstmaanNodeBundle 5.1 and will be removed in KunstmaanNodeBundle 6.0.', E_USER_DEPRECATED);
			0 ignored issues – show Security Best Practice introduced 2018-05-29 15:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
37
38	43		$this->container = $requestStack;
39	43		$this->multiLanguage = $this->container->getParameter('kunstmaan_admin.multi_language');
40	43		$this->defaultLocale = $this->container->getParameter('kunstmaan_admin.default_locale');
41	43		$this->requiredLocales = explode('\|', $this->container->getParameter('kunstmaan_admin.required_locales'));
42	43		$this->requestStack = $this->container->get('request_stack');
43
44	43		return;
45			}
46
47			$this->requestStack = $requestStack;
48			$this->multiLanguage = $multilanguage;
49			$this->defaultLocale = $defaultLocale;
50
51			$this->requiredLocales = explode('\|', $requiredLocales);
52			}
53
54			/**
55			* @return string
56			*/
57	24		public function getHost()
58			{
59	24		$request = $this->getMasterRequest();
60	24		$host = is_null($request) ? '' : $request->getHost();
61
62	24		return $host;
63			}
64
65			/**
66			* @return array
67			*/
68	1		public function getHosts()
69			{
70	1		return array($this->getHost());
71			}
72
73			/**
74			* @return string
75			*/
76	2		public function getDefaultLocale()
77			{
78	2		return $this->defaultLocale;
79			}
80
81			/**
82			* @param string\|null $host
83			*
84			* @return bool
85			*/
86	3		public function isMultiLanguage($host = null)
87			{
88	3		return $this->multiLanguage;
89			}
90
91			/**
92			* @param string\|null $host
93			*
94			* @return array
95			*/
96	2		public function getFrontendLocales($host = null)
97			{
98	2		return $this->requiredLocales;
99			}
100
101			/**
102			* @param string\|null $host
103			*
104			* @return array
105			*/
106	4		public function getBackendLocales($host = null)
107			{
108	4		return $this->requiredLocales;
109			}
110
111			/**
112			* @return bool
113			*/
114	1		public function isMultiDomainHost()
115			{
116	1		return false;
117			}
118
119			/**
120			* @param string\|null $host
121			*/
122	2		public function getRootNode($host = null)
123			{
124	2		return null;
125			}
126
127			/**
128			* @return array
129			*/
130	2		public function getExtraData()
131			{
132	2		return array();
133			}
134
135			/**
136			* @return array
137			*/
138	2		public function getLocalesExtraData()
139			{
140	2		return array();
141			}
142
143			/**
144			* @return null\|\Symfony\Component\HttpFoundation\Request
145			*/
146	29		protected function getMasterRequest()
147			{
148	29		return $this->requestStack->getMasterRequest();
149			}
150
151			/**
152			* @return array
153			*/
154	1		public function getFullHostConfig()
155			{
156	1		return array();
157			}
158
159			/**
160			* @param string\|null $host
161			*/
162	1		public function getFullHost($host = null)
163			{
164	1		return null;
165			}
166
167			/**
168			* @param int $id
169			*/
170	1		public function getFullHostById($id)
171			{
172	1		return null;
173			}
174
175	1		public function getHostSwitched()
176			{
177	1		return null;
178			}
179
180			/**
181			* @param string\|null $host
182			*/
183	1		public function getHostBaseUrl($host = null)
184			{
185	1		return null;
186			}
187			}
188

Kunstmaan / KunstmaanBundlesCMS

Push — master ( 770316...74fc07 )

AdminBundle/Helper/DomainConfiguration.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like