These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
2 | |||
3 | namespace Kunstmaan\TaggingBundle\EventListener; |
||
4 | |||
5 | use Doctrine\ORM\EntityManager; |
||
6 | use DoctrineExtensions\Taggable\Taggable; |
||
7 | use Kunstmaan\AdminBundle\Event\DeepCloneAndSaveEvent; |
||
8 | |||
9 | /** |
||
10 | * This listener will make sure the tags are copied as well |
||
11 | */ |
||
12 | class CloneListener |
||
13 | { |
||
14 | protected $em; |
||
15 | |||
16 | public function __construct(EntityManager $em) |
||
17 | { |
||
18 | $this->em = $em; |
||
19 | } |
||
20 | |||
21 | /** |
||
22 | * @param DeepCloneAndSaveEvent $event |
||
23 | */ |
||
24 | public function postDeepCloneAndSave(DeepCloneAndSaveEvent $event) |
||
25 | { |
||
26 | $originalEntity = $event->getEntity(); |
||
27 | |||
28 | if ($originalEntity instanceof Taggable) { |
||
29 | $targetEntity = $event->getClonedEntity(); |
||
30 | $this->em->getRepository('KunstmaanTaggingBundle:Tag')->copyTags($originalEntity, $targetEntity); |
||
0 ignored issues
–
show
|
|||
31 | } |
||
32 | } |
||
33 | } |
||
34 |
Let’s take a look at an example:
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.
Available Fixes
Change the type-hint for the parameter:
Add an additional type-check:
Add the method to the interface: