Issues in CloneListenerTest.php - All Issues - Inspection of "[NodeBundle] Allow duplicate with children (#2686..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 06c1ce...67d37c )

by Jeroen

created 2020-06-12 09:11 UTC

Tests/unit/EventListener/CloneListenerTest.php (6 issues)

Labels

Severity

Joakim Löfgren 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\PagePartBundle\Tests\EventListener;

use Kunstmaan\AdminBundle\Event\DeepCloneAndSaveEvent;
use Kunstmaan\PagePartBundle\Entity\PageTemplateConfiguration;
use Kunstmaan\PagePartBundle\EventListener\CloneListener;
use Kunstmaan\PagePartBundle\Helper\HasPagePartsInterface;
use Kunstmaan\PagePartBundle\Helper\HasPageTemplateInterface;
use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminConfigurator;
use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminConfiguratorInterface;
use Kunstmaan\PagePartBundle\PagePartConfigurationReader\PagePartConfigurationReaderInterface;
use Kunstmaan\PagePartBundle\PageTemplate\PageTemplateConfigurationService;
use Kunstmaan\PagePartBundle\Repository\PagePartRefRepository;
use PHPUnit\Framework\TestCase;

/**
 * Class CloneListenerTest
 */
class CloneListenerTest extends TestCase
{
    /**
     * @var \Doctrine\ORM\EntityManager|\PHPUnit_Framework_MockObject_MockObject
     */
    private $em;

    /**
     * @var PagePartAdminConfiguratorInterface
     */
    private $configurator;

    /**
     * @var \Doctrine\ORM\EntityRepository|\PHPUnit_Framework_MockObject_MockObject
     */
    private $repo;

    /**
     * @var CloneListener
     */
    private $object;

    /**
     * @var PagePartConfigurationReaderInterface|\PHPUnit_Framework_MockObject_MockObject
     */
    private $reader;

    /**
     * @var PageTemplateConfigurationService|\PHPUnit_Framework_MockObject_MockObject
     */
    private $templateService;

    protected function setUp()
    {
        $this->em = $this->getMockBuilder('Doctrine\ORM\EntityManager')
            ->disableOriginalConstructor()
            ->getMock();

        $this->repo = $this->getMockBuilder(PagePartRefRepository::class)
            ->disableOriginalConstructor()
            ->getMock();

        $this->em->expects($this->any())
            ->method('getRepository')
            ->with($this->equalTo('KunstmaanPagePartBundle:PagePartRef'))
            ->willReturn($this->repo);

        $this->configurator = new PagePartAdminConfigurator();
        $this->configurator->setContext('main');

        $this->reader = $this->createMock(PagePartConfigurationReaderInterface::class);
        $this->reader
            ->expects($this->any())
            ->method('getPagePartAdminConfigurators')
            ->willReturn([$this->configurator]);

        $this->reader
            ->expects($this->any())
            ->method('getPagePartContexts')
            ->willReturn([$this->configurator->getContext()]);

        $this->templateService = $this->getMockBuilder(PageTemplateConfigurationService::class)->disableOriginalConstructor()->getMock();

        $this->object = new CloneListener($this->em, $this->reader, $this->templateService);
    }

    public function testClonePagePart()

    {
        $entity = $this->createMock(HasPagePartsInterface::class);

        $clone = clone $entity;

        $this->repo->expects($this->once())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('copyPageParts')
            ->with($this->em, $entity, $clone, 'main');

        $event = new DeepCloneAndSaveEvent($entity, $clone);
        $this->object->postDeepCloneAndSave($event);
    }

    public function testClonePageTemplate()
    {
        $entity = $this->createMock(HasPageTemplateInterface::class);

        /** @var HasPageTemplateInterface|\PHPUnit_Framework_MockObject_MockObject $clone */
        $clone = clone $entity;

        $entity->expects($this->any())
            ->method('getId')
            ->willReturn(1);

        $clone->expects($this->any())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('getId')
            ->willReturn(2);

        $this->repo->expects($this->once())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('copyPageParts')
            ->with($this->em, $entity, $clone, 'main');

        $configuration = new PageTemplateConfiguration();
        $configuration->setId(1);
        $configuration->setPageId(1);

        $this->templateService->expects($this->once())
            ->method('findOrCreateFor')
            ->with($this->identicalTo($entity))
            ->willReturn($configuration);

        $newConfiguration = clone $configuration;
        $newConfiguration->setId(null);
        $newConfiguration->setPageId($clone->getId());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $this->em->expects($this->once())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('persist')
            ->with($newConfiguration);

        $event = new DeepCloneAndSaveEvent($entity, $clone);
        $this->object->postDeepCloneAndSave($event);
    }
}


1		<?php
2
3		namespace Kunstmaan\PagePartBundle\Tests\EventListener;
4
5		use Kunstmaan\AdminBundle\Event\DeepCloneAndSaveEvent;
6		use Kunstmaan\PagePartBundle\Entity\PageTemplateConfiguration;
7		use Kunstmaan\PagePartBundle\EventListener\CloneListener;
8		use Kunstmaan\PagePartBundle\Helper\HasPagePartsInterface;
9		use Kunstmaan\PagePartBundle\Helper\HasPageTemplateInterface;
10		use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminConfigurator;
11		use Kunstmaan\PagePartBundle\PagePartAdmin\PagePartAdminConfiguratorInterface;
12		use Kunstmaan\PagePartBundle\PagePartConfigurationReader\PagePartConfigurationReaderInterface;
13		use Kunstmaan\PagePartBundle\PageTemplate\PageTemplateConfigurationService;
14		use Kunstmaan\PagePartBundle\Repository\PagePartRefRepository;
15		use PHPUnit\Framework\TestCase;
16
17		/**
18		* Class CloneListenerTest
19		*/
20		class CloneListenerTest extends TestCase
21		{
22		/**
23		* @var \Doctrine\ORM\EntityManager\|\PHPUnit_Framework_MockObject_MockObject
24		*/
25		private $em;
26
27		/**
28		* @var PagePartAdminConfiguratorInterface
29		*/
30		private $configurator;
31
32		/**
33		* @var \Doctrine\ORM\EntityRepository\|\PHPUnit_Framework_MockObject_MockObject
34		*/
35		private $repo;
36
37		/**
38		* @var CloneListener
39		*/
40		private $object;
41
42		/**
43		* @var PagePartConfigurationReaderInterface\|\PHPUnit_Framework_MockObject_MockObject
44		*/
45		private $reader;
46
47		/**
48		* @var PageTemplateConfigurationService\|\PHPUnit_Framework_MockObject_MockObject
49		*/
50		private $templateService;
51
52		protected function setUp()
53		{
54		$this->em = $this->getMockBuilder('Doctrine\ORM\EntityManager')
55		->disableOriginalConstructor()
56		->getMock();
57
58		$this->repo = $this->getMockBuilder(PagePartRefRepository::class)
59		->disableOriginalConstructor()
60		->getMock();
61
62		$this->em->expects($this->any())
63		->method('getRepository')
64		->with($this->equalTo('KunstmaanPagePartBundle:PagePartRef'))
65		->willReturn($this->repo);
66
67		$this->configurator = new PagePartAdminConfigurator();
68		$this->configurator->setContext('main');
69
70		$this->reader = $this->createMock(PagePartConfigurationReaderInterface::class);
71		$this->reader
72		->expects($this->any())
73		->method('getPagePartAdminConfigurators')
74		->willReturn([$this->configurator]);
75
76		$this->reader
77		->expects($this->any())
78		->method('getPagePartContexts')
79		->willReturn([$this->configurator->getContext()]);
80
81		$this->templateService = $this->getMockBuilder(PageTemplateConfigurationService::class)->disableOriginalConstructor()->getMock();
82
83		$this->object = new CloneListener($this->em, $this->reader, $this->templateService);
84		}
85
86	View Code Duplication	public function testClonePagePart()
		0 ignored issues – show Duplication introduced 2018-04-18 14:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
87		{
88		$entity = $this->createMock(HasPagePartsInterface::class);
89
90		$clone = clone $entity;
91
92		$this->repo->expects($this->once())
		0 ignored issues – show Bug introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Doctrine\ORM\EntityRepository`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
93		->method('copyPageParts')
94		->with($this->em, $entity, $clone, 'main');
95
96		$event = new DeepCloneAndSaveEvent($entity, $clone);
97		$this->object->postDeepCloneAndSave($event);
98		}
99
100		public function testClonePageTemplate()
101		{
102		$entity = $this->createMock(HasPageTemplateInterface::class);
103
104		/** @var HasPageTemplateInterface\|\PHPUnit_Framework_MockObject_MockObject $clone */
105		$clone = clone $entity;
106
107		$entity->expects($this->any())
108		->method('getId')
109		->willReturn(1);
110
111		$clone->expects($this->any())
		0 ignored issues – show Bug introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Kunstmaan\PagePartBundle...asPageTemplateInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
112		->method('getId')
113		->willReturn(2);
114
115		$this->repo->expects($this->once())
		0 ignored issues – show Bug introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Doctrine\ORM\EntityRepository`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
116		->method('copyPageParts')
117		->with($this->em, $entity, $clone, 'main');
118
119		$configuration = new PageTemplateConfiguration();
120		$configuration->setId(1);
121		$configuration->setPageId(1);
122
123		$this->templateService->expects($this->once())
124		->method('findOrCreateFor')
125		->with($this->identicalTo($entity))
126		->willReturn($configuration);
127
128		$newConfiguration = clone $configuration;
129		$newConfiguration->setId(null);
130		$newConfiguration->setPageId($clone->getId());
		0 ignored issues – show Bug introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getId` does only exist in `Kunstmaan\PagePartBundle...asPageTemplateInterface`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
131
132		$this->em->expects($this->once())
		0 ignored issues – show Bug introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Doctrine\ORM\EntityManager`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
133		->method('persist')
134		->with($newConfiguration);
135
136		$event = new DeepCloneAndSaveEvent($entity, $clone);
137		$this->object->postDeepCloneAndSave($event);
138		}
139		}
140

Kunstmaan / KunstmaanBundlesCMS

Push — master ( 06c1ce...67d37c )

Tests/unit/EventListener/CloneListenerTest.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like