Issues in ConsoleExceptionSubscriberTest.php - All Issues - Inspection of "[NodeBundle] Allow duplicate with children (#2686..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 06c1ce...67d37c )

by Jeroen

created 2020-06-12 09:11 UTC

EventListener/ConsoleExceptionSubscriberTest.php (1 issue)

Showing only issues like (Show All)

mismatching argument types.

Documentation Minor

Ruud Denivel 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\AdminBundle\Tests\EventListener;

use Kunstmaan\AdminBundle\EventListener\ConsoleExceptionSubscriber;
use PHPUnit\Framework\TestCase;
use Psr\Log\LoggerInterface;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Event\ConsoleErrorEvent;
use Symfony\Component\Console\Input\ArgvInput;
use Symfony\Component\Console\Output\OutputInterface;

class ConsoleExceptionSubscriberTest extends TestCase
{
    public function testListener()
    {
        // Remove when sf3.4 support is removed
        if (!class_exists(ConsoleErrorEvent::class)) {
            // Nothing to test
            return;
        }

        $error = new \TypeError('An error occurred');
        $output = $this->createMock(OutputInterface::class);
        $logger = $this->createMock(LoggerInterface::class);
        $logger->expects($this->once())->method('critical');

        $subscriber = new ConsoleExceptionSubscriber($logger);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $subscriber->onConsoleError(new ConsoleErrorEvent(new ArgvInput(['console.php', 'test:run', '--foo=baz', 'buzz']), $output, $error, new Command('test:run')));
    }
}


1			<?php
2
3			namespace Kunstmaan\AdminBundle\Tests\EventListener;
4
5			use Kunstmaan\AdminBundle\EventListener\ConsoleExceptionSubscriber;
6			use PHPUnit\Framework\TestCase;
7			use Psr\Log\LoggerInterface;
8			use Symfony\Component\Console\Command\Command;
9			use Symfony\Component\Console\Event\ConsoleErrorEvent;
10			use Symfony\Component\Console\Input\ArgvInput;
11			use Symfony\Component\Console\Output\OutputInterface;
12
13			class ConsoleExceptionSubscriberTest extends TestCase
14			{
15			public function testListener()
16			{
17			// Remove when sf3.4 support is removed
18			if (!class_exists(ConsoleErrorEvent::class)) {
19			// Nothing to test
20			return;
21			}
22
23			$error = new \TypeError('An error occurred');
24			$output = $this->createMock(OutputInterface::class);
25			$logger = $this->createMock(LoggerInterface::class);
26			$logger->expects($this->once())->method('critical');
27
28			$subscriber = new ConsoleExceptionSubscriber($logger);
			0 ignored issues – show Documentation introduced 2019-02-01 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$logger` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Psr\Log\LoggerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
29			$subscriber->onConsoleError(new ConsoleErrorEvent(new ArgvInput(['console.php', 'test:run', '--foo=baz', 'buzz']), $output, $error, new Command('test:run')));
30			}
31			}
32

Kunstmaan / KunstmaanBundlesCMS

Push — master ( 06c1ce...67d37c )

EventListener/ConsoleExceptionSubscriberTest.php (1 issue)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like