RulesAdminListController::deleteAction() - Code Metrics - Inspection of "[NodeBundle] Allow duplicate with children (#2686..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 06c1ce...67d37c )

by Jeroen

created 2020-06-12 09:11 UTC

RulesAdminListController::deleteAction() A

↳ Parent: RulesAdminListController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	4
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	3
crap	2

<?php

namespace Kunstmaan\LeadGenerationBundle\Controller;

use Kunstmaan\AdminListBundle\AdminList\Configurator\AdminListConfiguratorInterface;
use Kunstmaan\AdminListBundle\Controller\AdminListController;
use Kunstmaan\LeadGenerationBundle\AdminList\RulesAdminListConfigurator;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\HttpFoundation\Request;

class RulesAdminListController extends AdminListController
{
    /**
     * @var RulesAdminListConfigurator
     */
    private $configurator;

    /**
     * @return AdminListConfiguratorInterface
     */
    public function getAdminListConfigurator($id)
    {
        if (!isset($this->configurator)) {
            $this->configurator = new RulesAdminListConfigurator($this->getEntityManager(), null, $id);

        }

        return $this->configurator;
    }

    /**
     * The detail action
     *
     * @Route("/{popup}/rules", requirements={"popup" = "\d+"}, name="kunstmaanleadgenerationbundle_admin_rule_abstractrule_detail")
     */
    public function detailAction(Request $request, $popup)
    {
        return parent::doIndexAction($this->getAdminListConfigurator($popup), $request);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * The add action
     *
     * @Route("/{popup}/add", requirements={"popup" = "\d+"}, name="kunstmaanleadgenerationbundle_admin_rule_abstractrule_add", methods={"GET", "POST"})
     *
     * @return array

     */
    public function addAction(Request $request, $popup)
    {
        $type = $request->get('type');

        return parent::doAddAction($this->getAdminListConfigurator($popup), $type, $request);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * The edit action
     *
     * @param int $id
     *
     * @Route("/{popup}/rules/{id}/edit", requirements={"popup" = "\d+", "rule" = "\d+"}, name="kunstmaanleadgenerationbundle_admin_rule_abstractrule_edit", methods={"GET", "POST"})
     *
     * @return array

     */
    public function editAction(Request $request, $id, $popup)
    {
        return parent::doEditAction($this->getAdminListConfigurator($popup), $id, $request);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * The delete action
     *
     * @param int $id
     *
     * @Route("/{popup}/rules/{id}/delete", requirements={"popup" = "\d+"}, name="kunstmaanleadgenerationbundle_admin_rule_abstractrule_delete", methods={"GET", "POST"})
     *
     * @return array

     */
    public function deleteAction(Request $request, $id, $popup)
    {
        return parent::doDeleteAction($this->getAdminListConfigurator($popup), $id, $request);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }
}


1			<?php
2
3			namespace Kunstmaan\LeadGenerationBundle\Controller;
4
5			use Kunstmaan\AdminListBundle\AdminList\Configurator\AdminListConfiguratorInterface;
6			use Kunstmaan\AdminListBundle\Controller\AdminListController;
7			use Kunstmaan\LeadGenerationBundle\AdminList\RulesAdminListConfigurator;
8			use Symfony\Component\Routing\Annotation\Route;
9			use Symfony\Component\HttpFoundation\Request;
10
11			class RulesAdminListController extends AdminListController
12			{
13			/**
14			* @var RulesAdminListConfigurator
15			*/
16			private $configurator;
17
18			/**
19			* @return AdminListConfiguratorInterface
20			*/
21			public function getAdminListConfigurator($id)
22			{
23			if (!isset($this->configurator)) {
24			$this->configurator = new RulesAdminListConfigurator($this->getEntityManager(), null, $id);
			0 ignored issues – show Compatibility introduced 2020-01-09 14:19 UTC by Report Bug Copy Issue Report `$this->getEntityManager()` of type `object<Doctrine\Persistence\ObjectManager>` is not a sub-type of `object<Doctrine\ORM\EntityManager>`. It seems like you assume a concrete implementation of the interface `Doctrine\Persistence\ObjectManager` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
25			}
26
27			return $this->configurator;
28			}
29
30			/**
31			* The detail action
32			*
33			* @Route("/{popup}/rules", requirements={"popup" = "\d+"}, name="kunstmaanleadgenerationbundle_admin_rule_abstractrule_detail")
34			*/
35			public function detailAction(Request $request, $popup)
36			{
37			return parent::doIndexAction($this->getAdminListConfigurator($popup), $request);
			0 ignored issues – show Compatibility introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report `$this->getAdminListConfigurator($popup)` of type `object<Kunstmaan\AdminLi...tConfiguratorInterface>` is not a sub-type of `object<Kunstmaan\AdminLi...tAdminListConfigurator>`. It seems like you assume a concrete implementation of the interface `Kunstmaan\AdminListBundl...stConfiguratorInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history... Comprehensibility Bug introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`doIndexAction()` instead of `detailAction()`). Are you sure this is correct? If so, you might want to change this to `$this->doIndexAction()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
38			}
39
40			/**
41			* The add action
42			*
43			* @Route("/{popup}/add", requirements={"popup" = "\d+"}, name="kunstmaanleadgenerationbundle_admin_rule_abstractrule_add", methods={"GET", "POST"})
44			*
45			* @return array
			0 ignored issues – show Documentation introduced 2018-12-03 12:39 UTC by Report Bug Copy Issue Report Should the return type not be `\Symfony\Component\HttpFoundation\Response`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
46			*/
47			public function addAction(Request $request, $popup)
48			{
49			$type = $request->get('type');
50
51			return parent::doAddAction($this->getAdminListConfigurator($popup), $type, $request);
			0 ignored issues – show Compatibility introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report `$this->getAdminListConfigurator($popup)` of type `object<Kunstmaan\AdminLi...tConfiguratorInterface>` is not a sub-type of `object<Kunstmaan\AdminLi...tAdminListConfigurator>`. It seems like you assume a concrete implementation of the interface `Kunstmaan\AdminListBundl...stConfiguratorInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history... Comprehensibility Bug introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`doAddAction()` instead of `addAction()`). Are you sure this is correct? If so, you might want to change this to `$this->doAddAction()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
52			}
53
54			/**
55			* The edit action
56			*
57			* @param int $id
58			*
59			* @Route("/{popup}/rules/{id}/edit", requirements={"popup" = "\d+", "rule" = "\d+"}, name="kunstmaanleadgenerationbundle_admin_rule_abstractrule_edit", methods={"GET", "POST"})
60			*
61			* @return array
			0 ignored issues – show Documentation introduced 2018-12-03 12:39 UTC by Report Bug Copy Issue Report Should the return type not be `\Symfony\Component\HttpFoundation\Response`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
62			*/
63			public function editAction(Request $request, $id, $popup)
64			{
65			return parent::doEditAction($this->getAdminListConfigurator($popup), $id, $request);
			0 ignored issues – show Compatibility introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report `$this->getAdminListConfigurator($popup)` of type `object<Kunstmaan\AdminLi...tConfiguratorInterface>` is not a sub-type of `object<Kunstmaan\AdminLi...tAdminListConfigurator>`. It seems like you assume a concrete implementation of the interface `Kunstmaan\AdminListBundl...stConfiguratorInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history... Comprehensibility Bug introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`doEditAction()` instead of `editAction()`). Are you sure this is correct? If so, you might want to change this to `$this->doEditAction()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
66			}
67
68			/**
69			* The delete action
70			*
71			* @param int $id
72			*
73			* @Route("/{popup}/rules/{id}/delete", requirements={"popup" = "\d+"}, name="kunstmaanleadgenerationbundle_admin_rule_abstractrule_delete", methods={"GET", "POST"})
74			*
75			* @return array
			0 ignored issues – show Documentation introduced 2018-12-03 12:39 UTC by Report Bug Copy Issue Report Should the return type not be `\Symfony\Component\HttpFoundation\Response`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
76			*/
77			public function deleteAction(Request $request, $id, $popup)
78			{
79			return parent::doDeleteAction($this->getAdminListConfigurator($popup), $id, $request);
			0 ignored issues – show Compatibility introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report `$this->getAdminListConfigurator($popup)` of type `object<Kunstmaan\AdminLi...tConfiguratorInterface>` is not a sub-type of `object<Kunstmaan\AdminLi...tAdminListConfigurator>`. It seems like you assume a concrete implementation of the interface `Kunstmaan\AdminListBundl...stConfiguratorInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history... Comprehensibility Bug introduced 2017-11-21 06:15 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`doDeleteAction()` instead of `deleteAction()`). Are you sure this is correct? If so, you might want to change this to `$this->doDeleteAction()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
80			}
81			}
82

Kunstmaan / KunstmaanBundlesCMS

Push — master ( 06c1ce...67d37c )

RulesAdminListController::deleteAction() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like