Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | View Code Duplication | class VarnishMenuAdaptor implements MenuAdaptorInterface |
|
|
|||
11 | { |
||
12 | /** |
||
13 | * In this method you can add children for a specific parent, but also remove and change the already created children |
||
14 | * |
||
15 | * @param MenuBuilder $menu The MenuBuilder |
||
16 | * @param MenuItem[] &$children The current children |
||
17 | * @param MenuItem $parent The parent Menu item |
||
18 | * @param Request $request The Request |
||
19 | */ |
||
20 | public function adaptChildren(MenuBuilder $menu, array &$children, MenuItem $parent = null, Request $request = null) |
||
37 | } |
||
38 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.