RelicValueObject::getBonusLists() - Code Metrics - Inspection of "Adding Items Call from Character Profile Api" - Kubinashi/BattlenetApiClient - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 86b291...5e082c )

by Willy

created 2017-08-23 22:22 UTC

RelicValueObject::getBonusLists() A

↳ Parent: RelicValueObject

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
ccs	0
cts	4
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php

namespace Kubinashi\BattlenetApi\WorldOfWarcraft\CharacterProfileApi\Model\Item;

/**
 * @author  Willy Reiche
 * @since   2017-08-23
 * @version 1.0
 */
class RelicValueObject
{
    /**
     * @var int
     */
    private $socket;
    /**
     * @var int
     */
    private $itemId;
    /**
     * @var int
     */
    private $context;
    /**
     * @var int[]
     */
    private $bonusLists;

    /**
     * RelicValueObject constructor.
     * @param int   $socket
     * @param int   $itemId
     * @param int   $context
     * @param int[] $bonusLists
     */
    public function __construct(

        $socket,
        $itemId,
        $context,
        $bonusLists
    ) {
        $this->socket = $socket;
        $this->itemId = $itemId;
        $this->context = $context;
        $this->bonusLists = $bonusLists;
    }

    /**
     * @return int
     */
    public function getSocket()
    {
        return $this->socket;
    }

    /**
     * @return int
     */
    public function getItemId()
    {
        return $this->itemId;
    }

    /**
     * @return int
     */
    public function getContext()
    {
        return $this->context;
    }

    /**
     * @return int[]
     */
    public function getBonusLists()
    {
        return $this->bonusLists;
    }
}


1		<?php
2
3		namespace Kubinashi\BattlenetApi\WorldOfWarcraft\CharacterProfileApi\Model\Item;
4
5		/**
6		* @author Willy Reiche
7		* @since 2017-08-23
8		* @version 1.0
9		*/
10		class RelicValueObject
11		{
12		/**
13		* @var int
14		*/
15		private $socket;
16		/**
17		* @var int
18		*/
19		private $itemId;
20		/**
21		* @var int
22		*/
23		private $context;
24		/**
25		* @var int[]
26		*/
27		private $bonusLists;
28
29		/**
30		* RelicValueObject constructor.
31		* @param int $socket
32		* @param int $itemId
33		* @param int $context
34		* @param int[] $bonusLists
35		*/
36	View Code Duplication	public function __construct(
		0 ignored issues – show Duplication introduced 2017-08-23 22:24 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37		$socket,
38		$itemId,
39		$context,
40		$bonusLists
41		) {
42		$this->socket = $socket;
43		$this->itemId = $itemId;
44		$this->context = $context;
45		$this->bonusLists = $bonusLists;
46		}
47
48		/**
49		* @return int
50		*/
51		public function getSocket()
52		{
53		return $this->socket;
54		}
55
56		/**
57		* @return int
58		*/
59		public function getItemId()
60		{
61		return $this->itemId;
62		}
63
64		/**
65		* @return int
66		*/
67		public function getContext()
68		{
69		return $this->context;
70		}
71
72		/**
73		* @return int[]
74		*/
75		public function getBonusLists()
76		{
77		return $this->bonusLists;
78		}
79		}
80

Kubinashi / BattlenetApiClient

Push — master ( 86b291...5e082c )

RelicValueObject::getBonusLists() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like