CharacterProfileValueObject::__construct() - Code Metrics - Inspection of "Big overhaul - New Structure and bugfixes as well..." - Kubinashi/BattlenetApiClient - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 52dd57...a4c9fa )

by Willy

created 2017-08-28 06:31 UTC

CharacterProfileValueObject::__construct() B

↳ Parent: CharacterProfileValueObject

Complexity

Conditions	1
Paths	1

Size

Total Lines	29
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	15
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	29
ccs	15
cts	15
cp	1
rs	8.8571
cc	1
eloc	27
nc	1
nop	13
crap	1

How to fix Many Parameters

<?php

namespace Kubinashi\BattlenetApi\WorldOfWarcraft\CharacterProfileApi\CharacterProfile\Model;

/**
 * @author  Willy Reiche
 * @since   2017-07-22
 * @version 1.0
 */
class CharacterProfileValueObject
{
    /**
     * @var string
     */
    private $lastModified;

    /**
     * @var string
     */
    private $name;

    /**
     * @var string
     */
    private $realm;

    /**
     * @var string
     */
    private $battleGroup;

    /**
     * @var string
     */
    private $class;

    /**
     * @var string
     */
    private $race;

    /**
     * @var string
     */
    private $gender;

    /**
     * @var string
     */
    private $level;

    /**
     * @var string
     */
    private $achievementPoints;

    /**
     * @var string
     */
    private $thumbnail;

    /**
     * @var string
     */
    private $calcClass;

    /**
     * @var string
     */
    private $faction;

    /**
     * @var string
     */
    private $totalHonorableKills;

    /**
     * CharacterProfileValueObject constructor.
     * @param string $lastModified
     * @param string $name
     * @param string $realm
     * @param string $battleGroup
     * @param string $class
     * @param string $race
     * @param string $gender
     * @param string $level
     * @param string $achievementPoints
     * @param string $thumbnail
     * @param string $calcClass
     * @param string $faction
     * @param string $totalHonorableKills
     */
    public function __construct(
        $lastModified,
        $name,
        $realm,
        $battleGroup,
        $class,
        $race,
        $gender,
        $level,
        $achievementPoints,
        $thumbnail,
        $calcClass,
        $faction,
        $totalHonorableKills
    ) {
        $this->lastModified = $lastModified;
        $this->name = $name;
        $this->realm = $realm;
        $this->battleGroup = $battleGroup;
        $this->class = $class;
        $this->race = $race;
        $this->gender = $gender;
        $this->level = $level;
        $this->achievementPoints = $achievementPoints;
        $this->thumbnail = $thumbnail;
        $this->calcClass = $calcClass;
        $this->faction = $faction;
        $this->totalHonorableKills = $totalHonorableKills;
    }

    /**
     * @return string
     */
    public function getLastModified()
    {
        return $this->lastModified;
    }

    /**
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * @return string
     */
    public function getRealm()
    {
        return $this->realm;
    }

    /**
     * @return string
     */
    public function getBattleGroup()
    {
        return $this->battleGroup;
    }

    /**
     * @return string
     */
    public function getClass()
    {
        return $this->class;
    }

    /**
     * @return string
     */
    public function getRace()
    {
        return $this->race;
    }

    /**
     * @return string
     */
    public function getGender()
    {
        return $this->gender;
    }

    /**
     * @return string
     */
    public function getLevel()
    {
        return $this->level;
    }

    /**
     * @return string
     */
    public function getAchievementPoints()
    {
        return $this->achievementPoints;
    }

    /**
     * @return string
     */
    public function getThumbnail()
    {
        return $this->thumbnail;
    }

    /**
     * @return string
     */
    public function getCalcClass()
    {
        return $this->calcClass;
    }

    /**
     * @return string
     */
    public function getFaction()
    {
        return $this->faction;
    }

    /**
     * @return string
     */
    public function getTotalHonorableKills()
    {
        return $this->totalHonorableKills;
    }
}


1		<?php
2
3		namespace Kubinashi\BattlenetApi\WorldOfWarcraft\CharacterProfileApi\CharacterProfile\Model;
4
5		/**
6		* @author Willy Reiche
7		* @since 2017-07-22
8		* @version 1.0
9		*/
10		class CharacterProfileValueObject
11		{
12		/**
13		* @var string
14		*/
15		private $lastModified;
16
17		/**
18		* @var string
19		*/
20		private $name;
21
22		/**
23		* @var string
24		*/
25		private $realm;
26
27		/**
28		* @var string
29		*/
30		private $battleGroup;
31
32		/**
33		* @var string
34		*/
35		private $class;
36
37		/**
38		* @var string
39		*/
40		private $race;
41
42		/**
43		* @var string
44		*/
45		private $gender;
46
47		/**
48		* @var string
49		*/
50		private $level;
51
52		/**
53		* @var string
54		*/
55		private $achievementPoints;
56
57		/**
58		* @var string
59		*/
60		private $thumbnail;
61
62		/**
63		* @var string
64		*/
65		private $calcClass;
66
67		/**
68		* @var string
69		*/
70		private $faction;
71
72		/**
73		* @var string
74		*/
75		private $totalHonorableKills;
76
77		/**
78		* CharacterProfileValueObject constructor.
79		* @param string $lastModified
80		* @param string $name
81		* @param string $realm
82		* @param string $battleGroup
83		* @param string $class
84		* @param string $race
85		* @param string $gender
86		* @param string $level
87		* @param string $achievementPoints
88		* @param string $thumbnail
89		* @param string $calcClass
90		* @param string $faction
91		* @param string $totalHonorableKills
92		*/
93	14	public function __construct(
94		$lastModified,
95		$name,
96		$realm,
97		$battleGroup,
98		$class,
99		$race,
100		$gender,
101		$level,
102		$achievementPoints,
103		$thumbnail,
104		$calcClass,
105		$faction,
106		$totalHonorableKills
107		) {
108	14	$this->lastModified = $lastModified;
109	14	$this->name = $name;
110	14	$this->realm = $realm;
111	14	$this->battleGroup = $battleGroup;
112	14	$this->class = $class;
113	14	$this->race = $race;
114	14	$this->gender = $gender;
115	14	$this->level = $level;
116	14	$this->achievementPoints = $achievementPoints;
117	14	$this->thumbnail = $thumbnail;
118	14	$this->calcClass = $calcClass;
119	14	$this->faction = $faction;
120	14	$this->totalHonorableKills = $totalHonorableKills;
121	14	}
122
123		/**
124		* @return string
125		*/
126	1	public function getLastModified()
127		{
128	1	return $this->lastModified;
129		}
130
131		/**
132		* @return string
133		*/
134	1	public function getName()
135		{
136	1	return $this->name;
137		}
138
139		/**
140		* @return string
141		*/
142	1	public function getRealm()
143		{
144	1	return $this->realm;
145		}
146
147		/**
148		* @return string
149		*/
150	1	public function getBattleGroup()
151		{
152	1	return $this->battleGroup;
153		}
154
155		/**
156		* @return string
157		*/
158	1	public function getClass()
159		{
160	1	return $this->class;
161		}
162
163		/**
164		* @return string
165		*/
166	1	public function getRace()
167		{
168	1	return $this->race;
169		}
170
171		/**
172		* @return string
173		*/
174	1	public function getGender()
175		{
176	1	return $this->gender;
177		}
178
179		/**
180		* @return string
181		*/
182	1	public function getLevel()
183		{
184	1	return $this->level;
185		}
186
187		/**
188		* @return string
189		*/
190	1	public function getAchievementPoints()
191		{
192	1	return $this->achievementPoints;
193		}
194
195		/**
196		* @return string
197		*/
198	1	public function getThumbnail()
199		{
200	1	return $this->thumbnail;
201		}
202
203		/**
204		* @return string
205		*/
206	1	public function getCalcClass()
207		{
208	1	return $this->calcClass;
209		}
210
211		/**
212		* @return string
213		*/
214	1	public function getFaction()
215		{
216	1	return $this->faction;
217		}
218
219		/**
220		* @return string
221		*/
222	1	public function getTotalHonorableKills()
223		{
224	1	return $this->totalHonorableKills;
225		}
226		}
227

Kubinashi / BattlenetApiClient

Push — master ( 52dd57...a4c9fa )

CharacterProfileValueObject::__construct() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like