Test Failed
Push — master ( 67ec1c...f465f8 )
by Willy
06:35
created

EmblemValueObject::__construct()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 19

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 2

Importance

Changes 0
Metric Value
dl 0
loc 19
ccs 0
cts 19
cp 0
rs 9.6333
c 0
b 0
f 0
cc 1
nc 1
nop 8
crap 2

How to fix   Many Parameters   

Many Parameters

Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.

There are several approaches to avoid long parameter lists:

1
<?php
2
3
namespace Kubinashi\BattlenetApi\WorldOfWarcraft\CharacterProfileApi\Guild\Model;
4
5
/**
6
 * @author  Willy Reiche
7
 * @since   2017-07-22
8
 * @version 1.0
9
 */
10
class EmblemValueObject
11
{
12
    /**
13
     * @var string
14
     */
15
    private $icon;
16
17
    /**
18
     * @var string
19
     */
20
    private $iconColor;
21
22
    /**
23
     * @var string
24
     */
25
    private $iconColorId;
26
27
    /**
28
     * @var string
29
     */
30
    private $border;
31
32
    /**
33
     * @var string
34
     */
35
    private $borderColor;
36
37
    /**
38
     * @var string
39
     */
40
    private $borderColorId;
41
42
    /**
43
     * @var string
44
     */
45
    private $backgroundColor;
46
47
    /**
48
     * @var string
49
     */
50
    private $backgroundColorId;
51
52
    /**
53
     * EmblemValueObject constructor.
54
     * @param string $icon
55
     * @param string $iconColor
56
     * @param string $iconColorId
57
     * @param string $border
58
     * @param string $borderColor
59
     * @param string $borderColorId
60
     * @param string $backgroundColor
61
     * @param string $backgroundColorId
62
     */
63
    public function __construct(
64
        $icon,
65
        $iconColor,
66
        $iconColorId,
67
        $border,
68
        $borderColor,
69
        $borderColorId,
70
        $backgroundColor,
71
        $backgroundColorId
72
    ) {
73
        $this->icon = $icon;
74
        $this->iconColor = $iconColor;
75
        $this->iconColorId = $iconColorId;
76
        $this->border = $border;
77
        $this->borderColor = $borderColor;
78
        $this->borderColorId = $borderColorId;
79
        $this->backgroundColor = $backgroundColor;
80
        $this->backgroundColorId = $backgroundColorId;
81
    }
82
83
    /**
84
     * @return string
85
     */
86
    public function getIcon()
87
    {
88
        return $this->icon;
89
    }
90
91
    /**
92
     * @return string
93
     */
94
    public function getIconColor()
95
    {
96
        return $this->iconColor;
97
    }
98
99
    /**
100
     * @return string
101
     */
102
    public function getIconColorId()
103
    {
104
        return $this->iconColorId;
105
    }
106
107
    /**
108
     * @return string
109
     */
110
    public function getBorder()
111
    {
112
        return $this->border;
113
    }
114
115
    /**
116
     * @return string
117
     */
118
    public function getBorderColor()
119
    {
120
        return $this->borderColor;
121
    }
122
123
    /**
124
     * @return string
125
     */
126
    public function getBorderColorId()
127
    {
128
        return $this->borderColorId;
129
    }
130
131
    /**
132
     * @return string
133
     */
134
    public function getBackgroundColor()
135
    {
136
        return $this->backgroundColor;
137
    }
138
139
    /**
140
     * @return string
141
     */
142
    public function getBackgroundColorId()
143
    {
144
        return $this->backgroundColorId;
145
    }
146
}
147