Core - Code Metrics - Inspection of "travis" - KroneMultimedia/plugin-timeshift - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — beta ( 3df37a...9fb6de )

by Helmut

created 2018-04-13 08:13 UTC

Core B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	235
Duplicated Lines	3.4 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

73.38%

Importance

Changes

Metric	Value
dl	8
loc	235
ccs	102
cts	139
cp	0.7338
rs	8.2608
c	0
b	0
f	0
wmc	40
lcom	1
cbo	0

14 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	1
A	timeshiftVisible()	0	6	1
A	add_metabox()	0	13	4
A	add_filters()	0	8	1
A	add_actions()	0	13	3
A	create_snapshot()	0	4	1
A	hasTimeshifts()	0	16	4
B	timeshift_metabox()	0	48	5
A	update_post_metadata()	0	9	2
C	inject_metadata_timeshift()	4	25	8
A	inject_timeshift()	4	15	4
A	checkTable()	0	19	1
A	storeTimeshift()	0	7	1
B	pre_post_update()	0	22	4

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like Core often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Core, and based on these observations, apply Extract Interface, too.

<?php
/*
 *
 *
 * inspired by https://github.com/adamsilverstein/wp-post-meta-revisions/blob/master/wp-post-meta-revisions.php
 * many thx @adamsilverstein
 *
 */

namespace KMM\Timeshift;

class Core
{
    private $plugin_dir;
    private $last_author = false;
    private $timeshift_cached_meta;

    public function __construct($i18n)
    {
        global $wpdb;
function myFunction($a, $b) {
    // Do something
}
        $this->i18n = $i18n;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->wpdb = $wpdb;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->plugin_dir = plugin_dir_url(__FILE__) . '../';
        $this->add_filters();
        $this->add_actions();
        $this->add_metabox();
    }

    public function hasTimeshifts($post_id)
    {
        $post_type = get_post_type($post_id);
        $table_name = $this->wpdb->prefix . 'timeshift_' . $post_type;
        $this->checkTable($post_type);
        $sql = "select count(1) as amount from $table_name where post_id=" . $post_id;
        $r = $this->wpdb->get_results($sql);

        if ($r && count($r) == 1) {
            if (intval($r[0]->amount) > 0) {
                return true;
            }
        }

        return false;
    }

    public function timeshiftVisible()
    {
        $check = apply_filters('krn_timeshift_visible', true);

        return $check;
    }

    public function add_metabox()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $cl = $this;
        if (! $this->timeshiftVisible()) {
            return;
        }
        if (! isset($_GET['post']) || ! $this->hasTimeshifts($_GET['post'])) {
            return;
        }
        add_action('add_meta_boxes', function () use ($cl) {
            add_meta_box('krn-timeshift', __('Timeshift', 'kmm-timeshift'), [$cl, 'timeshift_metabox'], null, 'normal', 'core');
        });
    }

    public function timeshift_metabox()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        global $post;
function myFunction($a, $b) {
    // Do something
}
        if (! isset($_GET['post'])) {
            return;
        }
        $prod_post = get_post($_GET['post']);
        $table_name = $this->wpdb->prefix . 'timeshift_' . $post->post_type;
        $sql = "select * from $table_name where post_id=" . $post->ID . ' order by create_date desc';

        $last_editor = get_post_meta($prod_post->ID, '_edit_last', true);
        $row = $this->wpdb->get_results($sql);
        echo '<table class="widefat fixed">';
        echo '<thead>';
        echo '<tr>';
        echo '<th width=30></th>';
        echo '<th width="40%" id="columnname" class="manage-column column-columnname"  scope="col">' . __('Title', 'kmm-timeshift') . '</th>';
        echo '<th width="30%" id="columnname" class="manage-column column-columnname"  scope="col">' . __('Snapshot Date', 'kmm-timeshift') . '</th>';
        echo '<th width="10%" id="columnname" class="manage-column column-columnname"  scope="col">' . __('Author', 'kmm-timeshift') . '</th>';
        echo '<th width="10%" id="columnname" class="manage-column column-columnname"  scope="col">' . __('Actions', 'kmm-timeshift') . '</th>';
        echo '</tr>';
        echo ' </thead>';
        echo '<tbody>';
        echo '<tr style="font-weight: 800;">';
        echo '<td>' . get_avatar($last_editor, 30) . '</td>';
        echo '<td>' . $prod_post->post_title . '</td>';
        echo '<td>' . $prod_post->post_date . '</td>';
        echo '<td>' . get_the_author_meta('display_name', $last_editor) . '</td>';
        echo "<td><a href='post.php?post=" . $_GET['post'] . "&action=edit'><span class='dashicons dashicons-admin-site'></span></A></td>";
        echo '</tr>';

        foreach ($row as $rev) {
            $timeshift = unserialize($rev->post_payload);
            $style = '';
            if (isset($_GET['timeshift']) && $_GET['timeshift'] == $rev->id) {
                $style = 'style="font-style:italic;background-color: lightblue;"';
            }
            echo '<tr ' . $style . '>';
            echo '<td>' . get_avatar($timeshift->meta['_edit_last'][0], 30) . '</td>';
            echo '<td>' . $timeshift->post->post_title . '</td>';
            echo '<td>' . $rev->create_date . '</td>';
            echo '<td>' . get_the_author_meta('display_name', $timeshift->meta['_edit_last'][0]) . '</td>';
            echo "<td><a href='post.php?post=" . $_GET['post'] . '&action=edit&timeshift=' . $rev->id . "'><span class='dashicons dashicons-backup'></span></a></td>";
            echo '</tr>';
        }
        echo '</tbody>';
        echo '</table>';
    }

    public function add_filters()
    {
        // When revisioned post meta has changed, trigger a revision save.
        //add_filter('wp_save_post_revision_post_has_changed', [$this, '_wp_check_revisioned_meta_fields_have_changed'], 10, 3);


        add_filter('get_post_metadata', [$this, 'inject_metadata_timeshift'], 1, 4);
        add_filter('update_post_metadata', [$this, 'update_post_metadata'], 1, 5);
    }

    public function update_post_metadata($check, int $object_id, string $meta_key, $meta_value, $prev_value)

    {
        if ($meta_key == '_edit_last') {
            $lo = get_post_meta($object_id, '_edit_last', true);
            $this->last_author = $lo;
        }

        return null;
    }

    public function inject_metadata_timeshift($value, $post_id, $key, $single)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (! isset($_GET['timeshift'])) {
            return;
        }
        //Load timeshift
        if (! $this->timeshift_cached_meta) {
            $post_type = get_post_type($post_id);
            $table_name = $this->wpdb->prefix . 'timeshift_' . $post_type;
            $sql = "select * from $table_name where id=" . intval($_GET['timeshift']);
            $r = $this->wpdb->get_results($sql);
            if ($r && count($r) == 1) {

                $payload = unserialize($r[0]->post_payload);
                $this->timeshift_cached_meta = $payload->meta;
            }
        }
        if ($this->timeshift_cached_meta && isset($this->timeshift_cached_meta[$key])) {
            return $this->timeshift_cached_meta[$key];
        }
        if ($single) {
            return null;
        }

        return [];
    }

    public function inject_timeshift($p)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        global $post;
function myFunction($a, $b) {
    // Do something
}
        if (! isset($_GET['timeshift'])) {
            return;
        }
        //Load timeshift
        $table_name = $this->wpdb->prefix . 'timeshift_' . $post->post_type;
        $sql = "select * from $table_name where id=" . intval($_GET['timeshift']);
        $r = $this->wpdb->get_results($sql);
        if ($r && count($r) == 1) {

            $payload = unserialize($r[0]->post_payload);
            $post = $payload->post;
        }
    }

    public function add_actions()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        add_action('edit_form_top', [$this, 'inject_timeshift'], 1, 1);
        add_action('pre_post_update', [$this, 'pre_post_update'], 2, 1);
        add_action('admin_notices', function () {
            if (isset($_GET['timeshift']) && $_GET['timeshift']) {
                echo '<div class="notice notice-warning is-dismissible">
                         <p style="font-weight: 800; color: red">' . __('You are editing a historical version! if you save or publish, this will replace the current live one', 'kmm-timeshift') . '</p>
                                  </div>';
            }
        });
        add_action('krn_timeshift_create_snapshot', [$this, 'create_snapshot'], 1, 1);
    }

    public function checkTable($postType)
    {
        $table_name = $this->wpdb->prefix . 'timeshift_' . $postType;

        $charset_collate = $this->wpdb->get_charset_collate();

        $sql = "CREATE TABLE IF NOT EXISTS $table_name (
		              id int(12) NOT NULL AUTO_INCREMENT,
                  post_id int(12) NOT NULL,
								  create_date datetime default CURRENT_TIMESTAMP,
									post_payload TEXT
		              ,PRIMARY KEY  (id)
	        ) $charset_collate;";

        require_once(ABSPATH . 'wp-admin/includes/upgrade.php');
        $a = dbDelta($sql);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        return true;
    }

    public function storeTimeshift($timeshift)
    {
        $table_name = $this->wpdb->prefix . 'timeshift_' . $timeshift->post->post_type;
        $sql = "insert into $table_name (post_id, post_payload) VALUES(%d, '%s')";
        $query = $this->wpdb->prepare($sql, $timeshift->post->ID, serialize($timeshift));
        $this->wpdb->query($query);
    }

    public function create_snapshot($postID)
    {
        $this->pre_post_update($postID);
    }

    public function pre_post_update(int $post_ID, array $data = null)

    {
        if (wp_is_post_autosave($post_ID)) {
            return;
        }
        if (get_post_status($post_ID) == 'auto-draft') {
            return;
        }
        $post_type = get_post_type($post_ID);
        $this->checkTable($post_type);

        $mdata = get_metadata('post', $post_ID);
        $post = get_post($post_ID);

        if ($this->last_author) {
            $mdata['_edit_last'][0] = $this->last_author;
        }
        unset($mdata['_edit_lock']);

        $timeshift = (object) ['post' => $post, 'meta' => $mdata];
        $this->storeTimeshift($timeshift);
    }
}


Push — beta ( 3df37a...9fb6de )

Core B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

14 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			/*
3			*
4			*
5			* inspired by https://github.com/adamsilverstein/wp-post-meta-revisions/blob/master/wp-post-meta-revisions.php
6			* many thx @adamsilverstein
7			*
8			*/
9
10			namespace KMM\Timeshift;
11
12			class Core
13			{
14			private $plugin_dir;
15			private $last_author = false;
16			private $timeshift_cached_meta;
17
18	12		public function __construct($i18n)
19			{
20			global $wpdb;
			0 ignored issues – show Compatibility Best Practice introduced 2018-04-10 11:32 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
21	12		$this->i18n = $i18n;
			0 ignored issues – show Bug introduced 2018-04-10 12:59 UTC by Report Bug Copy Issue Report The property `i18n` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
22	12		$this->wpdb = $wpdb;
			0 ignored issues – show Bug introduced 2018-04-10 11:32 UTC by Report Bug Copy Issue Report The property `wpdb` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
23	12		$this->plugin_dir = plugin_dir_url(__FILE__) . '../';
24	12		$this->add_filters();
25	12		$this->add_actions();
26	12		$this->add_metabox();
27			}
28
29	2		public function hasTimeshifts($post_id)
30			{
31	2		$post_type = get_post_type($post_id);
32	2		$table_name = $this->wpdb->prefix . 'timeshift_' . $post_type;
33	2		$this->checkTable($post_type);
34	2		$sql = "select count(1) as amount from $table_name where post_id=" . $post_id;
35	2		$r = $this->wpdb->get_results($sql);
36
37	2		if ($r && count($r) == 1) {
38	1		if (intval($r[0]->amount) > 0) {
39	1		return true;
40			}
41			}
42
43	1		return false;
44			}
45
46	12		public function timeshiftVisible()
47			{
48	12		$check = apply_filters('krn_timeshift_visible', true);
49
50	12		return $check;
51			}
52
53	12		public function add_metabox()
			0 ignored issues – show Coding Style introduced 2018-04-10 11:32 UTC by Report Bug Copy Issue Report `add_metabox` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
54			{
55	12		$cl = $this;
56	12		if (! $this->timeshiftVisible()) {
57			return;
58			}
59	12		if (! isset($_GET['post']) \|\| ! $this->hasTimeshifts($_GET['post'])) {
60	12		return;
61			}
62			add_action('add_meta_boxes', function () use ($cl) {
63			add_meta_box('krn-timeshift', __('Timeshift', 'kmm-timeshift'), [$cl, 'timeshift_metabox'], null, 'normal', 'core');
64			});
65			}
66
67	2		public function timeshift_metabox()
			0 ignored issues – show Coding Style introduced 2018-04-10 11:32 UTC by Report Bug Copy Issue Report `timeshift_metabox` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
68			{
69			global $post;
			0 ignored issues – show Compatibility Best Practice introduced 2018-04-10 11:32 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
70	2		if (! isset($_GET['post'])) {
71	1		return;
72			}
73	1		$prod_post = get_post($_GET['post']);
74	1		$table_name = $this->wpdb->prefix . 'timeshift_' . $post->post_type;
75	1		$sql = "select * from $table_name where post_id=" . $post->ID . ' order by create_date desc';
76
77	1		$last_editor = get_post_meta($prod_post->ID, '_edit_last', true);
78	1		$row = $this->wpdb->get_results($sql);
79	1		echo '<table class="widefat fixed">';
80	1		echo '<thead>';
81	1		echo '<tr>';
82	1		echo '<th width=30></th>';
83	1		echo '<th width="40%" id="columnname" class="manage-column column-columnname" scope="col">' . __('Title', 'kmm-timeshift') . '</th>';
84	1		echo '<th width="30%" id="columnname" class="manage-column column-columnname" scope="col">' . __('Snapshot Date', 'kmm-timeshift') . '</th>';
85	1		echo '<th width="10%" id="columnname" class="manage-column column-columnname" scope="col">' . __('Author', 'kmm-timeshift') . '</th>';
86	1		echo '<th width="10%" id="columnname" class="manage-column column-columnname" scope="col">' . __('Actions', 'kmm-timeshift') . '</th>';
87	1		echo '</tr>';
88	1		echo ' </thead>';
89	1		echo '<tbody>';
90	1		echo '<tr style="font-weight: 800;">';
91	1		echo '<td>' . get_avatar($last_editor, 30) . '</td>';
92	1		echo '<td>' . $prod_post->post_title . '</td>';
93	1		echo '<td>' . $prod_post->post_date . '</td>';
94	1		echo '<td>' . get_the_author_meta('display_name', $last_editor) . '</td>';
95	1		echo "<td><a href='post.php?post=" . $_GET['post'] . "&action=edit'><span class='dashicons dashicons-admin-site'></span></A></td>";
96	1		echo '</tr>';
97
98	1		foreach ($row as $rev) {
99			$timeshift = unserialize($rev->post_payload);
100			$style = '';
101			if (isset($_GET['timeshift']) && $_GET['timeshift'] == $rev->id) {
102			$style = 'style="font-style:italic;background-color: lightblue;"';
103			}
104			echo '<tr ' . $style . '>';
105			echo '<td>' . get_avatar($timeshift->meta['_edit_last'][0], 30) . '</td>';
106			echo '<td>' . $timeshift->post->post_title . '</td>';
107			echo '<td>' . $rev->create_date . '</td>';
108			echo '<td>' . get_the_author_meta('display_name', $timeshift->meta['_edit_last'][0]) . '</td>';
109			echo "<td><a href='post.php?post=" . $_GET['post'] . '&action=edit&timeshift=' . $rev->id . "'><span class='dashicons dashicons-backup'></span></a></td>";
110			echo '</tr>';
111			}
112	1		echo '</tbody>';
113	1		echo '</table>';
114			}
115
116	12		public function add_filters()
117			{
118			// When revisioned post meta has changed, trigger a revision save.
119			//add_filter('wp_save_post_revision_post_has_changed', [$this, '_wp_check_revisioned_meta_fields_have_changed'], 10, 3);
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-04-10 11:32 UTC by Report Bug Copy Issue Report `74%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
120
121	12		add_filter('get_post_metadata', [$this, 'inject_metadata_timeshift'], 1, 4);
122	12		add_filter('update_post_metadata', [$this, 'update_post_metadata'], 1, 5);
123			}
124
125	1		public function update_post_metadata($check, int $object_id, string $meta_key, $meta_value, $prev_value)
			0 ignored issues – show Unused Code introduced 2018-04-11 09:56 UTC by Report Bug Copy Issue Report The parameter `$meta_value` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2018-04-11 09:56 UTC by Report Bug Copy Issue Report The parameter `$prev_value` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
126			{
127	1		if ($meta_key == '_edit_last') {
128	1		$lo = get_post_meta($object_id, '_edit_last', true);
129	1		$this->last_author = $lo;
130			}
131
132	1		return null;
133			}
134
135	3		public function inject_metadata_timeshift($value, $post_id, $key, $single)
			0 ignored issues – show Coding Style introduced 2018-04-10 11:32 UTC by Report Bug Copy Issue Report `inject_metadata_timeshift` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
136			{
137	3		if (! isset($_GET['timeshift'])) {
138	3		return;
139			}
140			//Load timeshift
141			if (! $this->timeshift_cached_meta) {
142			$post_type = get_post_type($post_id);
143			$table_name = $this->wpdb->prefix . 'timeshift_' . $post_type;
144			$sql = "select * from $table_name where id=" . intval($_GET['timeshift']);
145			$r = $this->wpdb->get_results($sql);
146		View Code Duplication	if ($r && count($r) == 1) {
			0 ignored issues – show Duplication introduced 2018-04-10 11:32 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
147			$payload = unserialize($r[0]->post_payload);
148			$this->timeshift_cached_meta = $payload->meta;
149			}
150			}
151			if ($this->timeshift_cached_meta && isset($this->timeshift_cached_meta[$key])) {
152			return $this->timeshift_cached_meta[$key];
153			}
154			if ($single) {
155			return null;
156			}
157
158			return [];
159			}
160
161	2		public function inject_timeshift($p)
			0 ignored issues – show Unused Code introduced 2018-04-11 09:56 UTC by Report Bug Copy Issue Report The parameter `$p` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Coding Style introduced 2018-04-11 09:56 UTC by Report Bug Copy Issue Report `inject_timeshift` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
162			{
163			global $post;
			0 ignored issues – show Compatibility Best Practice introduced 2018-04-10 11:32 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
164	2		if (! isset($_GET['timeshift'])) {
165	1		return;
166			}
167			//Load timeshift
168	1		$table_name = $this->wpdb->prefix . 'timeshift_' . $post->post_type;
169	1		$sql = "select * from $table_name where id=" . intval($_GET['timeshift']);
170	1		$r = $this->wpdb->get_results($sql);
171	1	View Code Duplication	if ($r && count($r) == 1) {
			0 ignored issues – show Duplication introduced 2018-04-10 11:32 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
172			$payload = unserialize($r[0]->post_payload);
173			$post = $payload->post;
174			}
175			}
176
177	12		public function add_actions()
			0 ignored issues – show Coding Style introduced 2018-04-10 11:32 UTC by Report Bug Copy Issue Report `add_actions` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
178			{
179	12		add_action('edit_form_top', [$this, 'inject_timeshift'], 1, 1);
180	12		add_action('pre_post_update', [$this, 'pre_post_update'], 2, 1);
181	12		add_action('admin_notices', function () {
182			if (isset($_GET['timeshift']) && $_GET['timeshift']) {
183			echo '<div class="notice notice-warning is-dismissible">
184			<p style="font-weight: 800; color: red">' . __('You are editing a historical version! if you save or publish, this will replace the current live one', 'kmm-timeshift') . '</p>
185			</div>';
186			}
187	12		});
188	12		add_action('krn_timeshift_create_snapshot', [$this, 'create_snapshot'], 1, 1);
189			}
190
191	4		public function checkTable($postType)
192			{
193	4		$table_name = $this->wpdb->prefix . 'timeshift_' . $postType;
194
195	4		$charset_collate = $this->wpdb->get_charset_collate();
196
197	4		$sql = "CREATE TABLE IF NOT EXISTS $table_name (
198			id int(12) NOT NULL AUTO_INCREMENT,
199			post_id int(12) NOT NULL,
200			create_date datetime default CURRENT_TIMESTAMP,
201			post_payload TEXT
202			,PRIMARY KEY (id)
203	4		) $charset_collate;";
204
205	4		require_once(ABSPATH . 'wp-admin/includes/upgrade.php');
206	4		$a = dbDelta($sql);
			0 ignored issues – show Unused Code introduced 2018-04-10 11:32 UTC by Report Bug Copy Issue Report `$a` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
207
208	4		return true;
209			}
210
211	2		public function storeTimeshift($timeshift)
212			{
213	2		$table_name = $this->wpdb->prefix . 'timeshift_' . $timeshift->post->post_type;
214	2		$sql = "insert into $table_name (post_id, post_payload) VALUES(%d, '%s')";
215	2		$query = $this->wpdb->prepare($sql, $timeshift->post->ID, serialize($timeshift));
216	2		$this->wpdb->query($query);
217			}
218
219			public function create_snapshot($postID)
220			{
221			$this->pre_post_update($postID);
222			}
223
224	1		public function pre_post_update(int $post_ID, array $data = null)
			0 ignored issues – show Unused Code introduced 2018-04-10 11:32 UTC by Report Bug Copy Issue Report The parameter `$data` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
225			{
226	1		if (wp_is_post_autosave($post_ID)) {
227			return;
228			}
229	1		if (get_post_status($post_ID) == 'auto-draft') {
230			return;
231			}
232	1		$post_type = get_post_type($post_ID);
233	1		$this->checkTable($post_type);
234
235	1		$mdata = get_metadata('post', $post_ID);
236	1		$post = get_post($post_ID);
237
238	1		if ($this->last_author) {
239			$mdata['_edit_last'][0] = $this->last_author;
240			}
241	1		unset($mdata['_edit_lock']);
242
243	1		$timeshift = (object) ['post' => $post, 'meta' => $mdata];
244	1		$this->storeTimeshift($timeshift);
245			}
246			}
247

KroneMultimedia / plugin-timeshift

Push — beta ( 3df37a...9fb6de )

Core B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

14 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like