Knp\Rad\ResourceResolver\RoutingNormalizer

Complexity

Total Complexity

13

Size/Duplication

Total Lines	66
Duplicated Lines	18.18 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	3
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	normalizeArray()	6	20	6
B	normalizeDeclaration()	3	18	5
A	normalizeString()	3	16	2

<?php

namespace Knp\Rad\ResourceResolver;

class RoutingNormalizer
{
    /**
     * Normalizes string and array declarations into associative array.
     *
     * @param string|array $declaration
     *
     * @return array

Consider making the return type a bit more specific; maybe use array<string,null|boolean|array>.

     */
    public function normalizeDeclaration($declaration)
    {
        if (is_string($declaration)) {
            return $this->normalizeString($declaration);
        }

        // Normalize numerically indexed array
        if (array_keys($declaration) === array_keys(array_values($declaration))) {
            return $this->normalizeArray($declaration);
        }

        if (isset($declaration['arguments']) && !is_array($declaration['arguments'])) {

This code seems to be duplicated across your project.

            throw new \InvalidArgumentException('The "arguments" parameter should be an array of arguments.');
        }

        // Adds default value to associative array
        return array_merge(['method' => null, 'required' => true, 'arguments' => []], $declaration);
    }

    private function normalizeString($declaration)
    {
        $service = $declaration;
        $method  = null;

        if (strpos($declaration, ':') !== false) {

This code seems to be duplicated across your project.

            list($service, $method) = explode(':', $declaration);
        }

        return [
            'service'   => $service,
            'method'    => $method,
            'arguments' => [],
            'required'  => true,
        ];
    }

    private function normalizeArray($declaration)
    {
        if (isset($declaration[1]) && !is_array($declaration[1])) {

This code seems to be duplicated across your project.

            throw new \InvalidArgumentException('The second argument for a resource configuration, when expressed with a numerically indexed array, should be an array of arguments.');

This line exceeds maximum limit of 180 characters; contains 183 characters

        }

        $service = $declaration[0];
        $method  = null;

        if (false !== strpos($declaration[0], ':')) {

This code seems to be duplicated across your project.

            list($service, $method) = explode(':', $declaration[0]);
        }

        return [
            'service'   => $service,
            'method'    => $method,
            'arguments' => isset($declaration[1]) ? $declaration[1] : [],
            'required'  => isset($declaration[2]) ? (bool) $declaration[2] : true,
        ];
    }
}