RoutingNormalizer::normalizeString() - Code Metrics - Inspection of "Support string syntax" - KnpLabs/rad-resource-resolver - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#34)

by Albin

created 2017-03-28 00:13 UTC

RoutingNormalizer::normalizeString() A

↳ Parent: RoutingNormalizer

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	16
rs	9.4285
c	1
b	0
f	0
cc	2
eloc	10
nc	2
nop	1

<?php

namespace Knp\Rad\ResourceResolver;

class RoutingNormalizer
{
    public function normalizeDeclaration($declaration)
    {
        if (is_string($declaration)) {
            return $this->normalizeString($declaration);
        }

        if (array_keys($declaration) === array_keys(array_values($declaration))) {
            if (false === strpos($declaration[0], ':')) {
                throw new \RuntimeException('The first argument for a resource configuration, when expressed with a numerically indexed array, should be a string containing the service and the method used, seperated by a colon.');

            } elseif (isset($declaration[1]) && !is_array($declaration[1])) {
                throw new \RuntimeException('The second argument for a resource configuration, when expressed with a numerically indexed array, should be an array of arguments.');
            }

            list($service, $method) = explode(':', $declaration[0]);

            return [
                'service'   => $service,
                'method'    => $method,
                'arguments' => isset($declaration[1]) ? $declaration[1] : [],
                'required'  => isset($declaration[2]) ? (bool) $declaration[2] : true,
            ];
        }

        return array_merge(['required' => true, 'arguments' => []], $declaration);
    }

    private function normalizeString($declaration)
    {
        $service = $declaration;
        $method  = null;

        if (strpos($declaration, ':') !== false) {
            list($service, $method) = explode(':', $declaration);
        }

        return [
            'service'   => $service,
            'method'    => $method,
            'arguments' => [],
            'required'  => true,
        ];
    }
}


1			<?php
2
3			namespace Knp\Rad\ResourceResolver;
4
5			class RoutingNormalizer
6			{
7			public function normalizeDeclaration($declaration)
8			{
9			if (is_string($declaration)) {
10			return $this->normalizeString($declaration);
11			}
12
13			if (array_keys($declaration) === array_keys(array_values($declaration))) {
14			if (false === strpos($declaration[0], ':')) {
15			throw new \RuntimeException('The first argument for a resource configuration, when expressed with a numerically indexed array, should be a string containing the service and the method used, seperated by a colon.');
			0 ignored issues – show Coding Style introduced 2017-03-28 00:16 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 180 characters; contains 230 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
16			} elseif (isset($declaration[1]) && !is_array($declaration[1])) {
17			throw new \RuntimeException('The second argument for a resource configuration, when expressed with a numerically indexed array, should be an array of arguments.');
18			}
19
20			list($service, $method) = explode(':', $declaration[0]);
21
22			return [
23			'service' => $service,
24			'method' => $method,
25			'arguments' => isset($declaration[1]) ? $declaration[1] : [],
26			'required' => isset($declaration[2]) ? (bool) $declaration[2] : true,
27			];
28			}
29
30			return array_merge(['required' => true, 'arguments' => []], $declaration);
31			}
32
33			private function normalizeString($declaration)
34			{
35			$service = $declaration;
36			$method = null;
37
38			if (strpos($declaration, ':') !== false) {
39			list($service, $method) = explode(':', $declaration);
40			}
41
42			return [
43			'service' => $service,
44			'method' => $method,
45			'arguments' => [],
46			'required' => true,
47			];
48			}
49			}
50

KnpLabs / rad-resource-resolver

Pull Request — master (#34)

RoutingNormalizer::normalizeString() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like