LegacyFactory::addProvider() - Code Metrics - Inspection of "[WIP] Reformat code and migrate to symfony v4" - KnpLabs/rad-fixtures-load - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#39)

by Pierre

created 2018-10-02 09:14 UTC

LegacyFactory::addProvider() A

↳ Parent: LegacyFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

declare(strict_types=1);

namespace Knp\Rad\FixturesLoad\FixturesFactory;

use Doctrine\Common\Persistence\ObjectManager;
use Knp\Rad\FixturesLoad\FixturesFactory;
use Nelmio\Alice\Fixtures;
use Nelmio\Alice\ProcessorInterface;

class LegacyFactory implements FixturesFactory
{
    /**
     * @var ProcessorInterface[]
     */
    protected $processors = [];

    /**
     * @var object[]
     */
    protected $providers = [];

    /**
     * {@inheritdoc}
     */
    public function addProcessor(ProcessorInterface $processor)
    {
        $this->processors[] = $processor;
    }

    /**
     * {@inheritdoc}
     */
    public function addProvider($provider)
    {
        $this->providers[] = $provider;
    }

    /**
     * {@inheritdoc}
     */
    public function create(ObjectManager $manager, $locale = null): Fixtures

    {
        $options = [
            'providers' => $this->providers,
        ];

        if (null !== $locale) {
            $options['locale'] = $locale;
        }

        return new Fixtures($manager, $options, $this->processors);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Knp\Rad\FixturesLoad\FixturesFactory;
6
7		use Doctrine\Common\Persistence\ObjectManager;
8		use Knp\Rad\FixturesLoad\FixturesFactory;
9		use Nelmio\Alice\Fixtures;
10		use Nelmio\Alice\ProcessorInterface;
11
12		class LegacyFactory implements FixturesFactory
13		{
14		/**
15		* @var ProcessorInterface[]
16		*/
17		protected $processors = [];
18
19		/**
20		* @var object[]
21		*/
22		protected $providers = [];
23
24		/**
25		* {@inheritdoc}
26		*/
27		public function addProcessor(ProcessorInterface $processor)
28		{
29		$this->processors[] = $processor;
30		}
31
32		/**
33		* {@inheritdoc}
34		*/
35		public function addProvider($provider)
36		{
37		$this->providers[] = $provider;
38		}
39
40		/**
41		* {@inheritdoc}
42		*/
43	View Code Duplication	public function create(ObjectManager $manager, $locale = null): Fixtures
		0 ignored issues – show Duplication introduced 2018-10-02 09:27 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		{
45		$options = [
46		'providers' => $this->providers,
47		];
48
49		if (null !== $locale) {
50		$options['locale'] = $locale;
51		}
52
53		return new Fixtures($manager, $options, $this->processors);
		0 ignored issues – show Documentation introduced 2015-11-23 08:29 UTC by Report Bug Copy Issue Report `$manager` is of type `object<Doctrine\Common\Persistence\ObjectManager>`, but the function expects a `object<Nelmio\Alice\PersisterInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
54		}
55		}
56

KnpLabs / rad-fixtures-load

Pull Request — master (#39)

LegacyFactory::addProvider() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like